AGENT-1517: run IRI deletion tests

[andfasano]

This patch adds the IRI deletion e2e tests to the iso-no-registry job.

Requires openshift/machine-config-operator#6041

IRI Deletion E2E Tests for Machine Config Operator CI

This PR updates the OpenShift CI configuration for the machine-config-operator repository to add IRI (Isolated Red Image) deletion validation to the iso-no-registry end-to-end job.

Practically, the change modifies the e2e-compact-ipv4-iso-no-registry step in ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yaml so the iri-e2e-step runs two commands: the existing standard IRI e2e tests (make test-e2e-iri) and then the deletion-specific IRI tests (TAGS=iri_delete make test-e2e-iri) under set -xeuo pipefail. This ensures both regular IRI behavior and IRI deletion are exercised in the machine-config-operator CI job that runs without a registry.

[openshift-ci-robot]

@andfasano: This pull request references AGENT-1517 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

This patch adds the IRI deletion e2e tests to the iso-no-registry job

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3bdde3d7-5674-421c-8d70-21f14c5a904c

📥 Commits

Reviewing files that changed from the base of the PR and between a9d552b and e249ac0.

📒 Files selected for processing (1)

• ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yaml

---

Walkthrough

The CI job e2e-compact-ipv4-iso-no-registry in the machine-config-operator configuration now runs the iri e2e test twice by replacing a single make test-e2e-iri command with a bash block that runs make test-e2e-iri then TAGS=iri_delete make test-e2e-iri (with set -xeuo pipefail).

Changes

e2e IRI Test Execution Strategy

Layer / File(s)	Summary
Dual e2e-iri test execution in CI ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yaml	Replaced commands: make test-e2e-iri with a bash script (set -xeuo pipefail) that runs make test-e2e-iri then TAGS=iri_delete make test-e2e-iri, causing the e2e-compact-ipv4-iso-no-registry validation step to execute the test twice with and without the iri_delete tag.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'AGENT-1517: run IRI deletion tests' directly and clearly summarizes the main change: adding IRI deletion e2e tests to the iso-no-registry job, which matches the PR objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only modifies CI operator YAML configuration for machine-config-operator, not Ginkgo test source files. No test names (It(), Describe(), etc.) are added or modified.
Test Structure And Quality	✅ Passed	PR contains only CI configuration changes (YAML), not Ginkgo test code. The custom check for test quality requirements is not applicable to CI configuration modifications.
Microshift Test Compatibility	✅ Passed	This PR modifies only CI configuration files (YAML). It does not add new Ginkgo test code. The check for MicroShift compatibility applies to test code additions, not CI configuration changes.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR modifies CI/CD YAML configuration only. It does not add new Ginkgo e2e test code. The check applies only when new test code is added, so it is not applicable here.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only a CI configuration file to add IRI deletion test execution, not deployment manifests, operator code, or controllers. Out of scope for topology-aware scheduling check.
Ote Binary Stdout Contract	✅ Passed	PR modifies only CI configuration YAML files, not source code. OTE Binary Stdout Contract checks target process-level code violations, which are not present in this change.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR only modifies CI configuration YAML files, not Ginkgo test source code. The custom check applies only when new e2e tests are added, which is not the case here.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andfasano
Once this PR has been reviewed and has the lgtm label, please assign isabella-janssen for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/machine-config-operator/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yaml`:
- Around line 109-111: The commands block currently runs two make invocations
without errexit so a failing first command could be masked; update the multiline
`commands:` block to enable shell errexit (e.g., add `set -o errexit` or `set
-e` as the first line) so that `make test-e2e-iri` failing will stop the step
before `TAGS=iri_delete make test-e2e-iri` runs; modify the `commands` block
containing `make test-e2e-iri` and `TAGS=iri_delete make test-e2e-iri`
accordingly.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 1f778a62-3c9b-4c9c-a1af-d04ac15fdc43

📥 Commits

Reviewing files that changed from the base of the PR and between 54c0523 and a9d552b.

📒 Files selected for processing (1)

• ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yaml

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@andfasano: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-machine-config-operator-main-e2e-agent-compact-ipv4-iso-no-registry	openshift/machine-config-operator	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@andfasano: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.