NETOBSERV-2635: Update Instance Types

[Amoghrd]

PR changes:

• Remove redundant OPENSHIFT_INFRA_NODE_INSTANCE_TYPE: r5.4xlarge env var since thats the default
• Use COMPUTE_NODE_TYPE: m6a.2xlarge for all NetObserv perf jobs

Instance Type Updates for NetObserv Performance Tests

This PR updates the AWS EC2 instance type configuration for the NetObserv repository's CI performance test jobs in the OpenShift release repository.

Changes Made

Removed redundant infrastructure node instance type setting: The OPENSHIFT_INFRA_NODE_INSTANCE_TYPE environment variable (which was set to r5.4xlarge) has been removed from all three test job definitions, as this matches the default value and is unnecessary to explicitly set.

Updated compute node instance types:

• node-density-heavy-25nodes (daily job): Downsized from m6i.4xlarge to m6i.2xlarge
• cluster-density-v2-250nodes (weekly cron job): Changed from m6i.4xlarge to m6a.2xlarge
• node-density-heavy-25nodes-service-without-loki (weekly job): No compute type change

These changes optimize the instance types used for NetObserv's performance testing infrastructure, reducing costs while maintaining appropriate test capacity for the workloads.

Affected repository: netobserv/netobserv-perf-tests (via CI configuration in the OpenShift release repo)

Related issue: NETOBSERV-2635

[openshift-ci-robot]

@Amoghrd: This pull request references NETOBSERV-2635 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

PR changes:

• Remove redundant OPENSHIFT_INFRA_NODE_INSTANCE_TYPE: r5.4xlarge env var since thats the default
• Use COMPUTE_NODE_TYPE: m6i.2xlarge for all NetObserv perf jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amoghrd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/netobserv/netobserv-perf-tests/OWNERS [Amoghrd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Walkthrough

This PR reduces resource allocation for netobserv AWS nightly performance tests by downgrading compute node instance types and removing explicit OpenShift infrastructure node instance type settings across three test job definitions in the CI operator configuration YAML.

Changes

NetObserv Performance Test Resource Configuration

Layer / File(s)	Summary
node-density-heavy-25nodes job resource tuning ci-operator/config/netobserv/netobserv-perf-tests/netobserv-netobserv-perf-tests-main__netobserv-aws-4.22-nightly-x86.yaml	COMPUTE_NODE_TYPE downgraded from m6i.4xlarge to m6i.2xlarge, and OPENSHIFT_INFRA_NODE_INSTANCE_TYPE: r5.4xlarge removed from the daily test job's environment configuration.
node-density-heavy-25nodes-service-without-loki job infrastructure node removal ci-operator/config/netobserv/netobserv-perf-tests/netobserv-netobserv-perf-tests-main__netobserv-aws-4.22-nightly-x86.yaml	OPENSHIFT_INFRA_NODE_INSTANCE_TYPE: r5.4xlarge removed from the weekly test job's environment configuration.
cluster-density-v2-250nodes job resource tuning ci-operator/config/netobserv/netobserv-perf-tests/netobserv-netobserv-perf-tests-main__netobserv-aws-4.22-nightly-x86.yaml	COMPUTE_NODE_TYPE downgraded from m6i.4xlarge to m6a.2xlarge, and OPENSHIFT_INFRA_NODE_INSTANCE_TYPE: r5.4xlarge removed from the weekly cron test job's environment configuration.

---

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and clearly identifies the main change: updating instance types across NetObserv performance test configurations, which aligns with the detailed changes in the YAML file.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The custom check requires analyzing Ginkgo test names for stability/determinism. This PR modifies only YAML CI configuration files without any Ginkgo test code. The check is not applicable.
Test Structure And Quality	✅ Passed	The custom check is not applicable. The PR modifies YAML CI operator configuration files, not Ginkgo test code. No Go test files are present in the changes.
Microshift Test Compatibility	✅ Passed	This PR modifies only CI/Prow configuration YAML files and does not add any new Ginkgo e2e tests. The MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR modifies only CI configuration YAML files (instance type settings), not Ginkgo e2e tests. The custom check targets new test code, not infrastructure configuration.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only CI test configuration (instance types), not deployment manifests, operator code, or controllers. Custom check scope does not apply.
Ote Binary Stdout Contract	✅ Passed	PR modifies only YAML CI configuration files. OTE Binary Stdout Contract applies to Go process-level code, not configuration. The check is not applicable to this PR.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This custom check applies only to new Ginkgo e2e tests. The PR modifies only CI configuration YAML files, not test code. No new test implementations are present.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/netobserv/netobserv-perf-tests/netobserv-netobserv-perf-tests-main__netobserv-aws-4.22-nightly-x86.yaml`:
- Line 159: The COMPUTE_NODE_TYPE value is inconsistent (currently set to
m6a.2xlarge) but the objective requires m6i.2xlarge; update the
COMPUTE_NODE_TYPE entry to "m6i.2xlarge" in this job spec and scan other job
specs in the same YAML for any remaining m6a.* or other mismatched
instance-family values (for example other COMPUTE_NODE_TYPE occurrences such as
the m6i.4xlarge entry) and make them consistent with the objective (use the m6i
family and the specified sizes).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c647a6cd-c012-4337-a41d-85c6ce03c428

📥 Commits

Reviewing files that changed from the base of the PR and between 54c0523 and c0b5be6.

📒 Files selected for processing (1)

• ci-operator/config/netobserv/netobserv-perf-tests/netobserv-netobserv-perf-tests-main__netobserv-aws-4.22-nightly-x86.yaml

[openshift-merge-bot]

@openshift-ci-robot: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@Amoghrd: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-netobserv-netobserv-perf-tests-main-netobserv-aws-4.22-nightly-x86-node-density-heavy-25nodes	N/A	periodic	Ci-operator config changed
periodic-ci-netobserv-netobserv-perf-tests-main-netobserv-aws-4.22-nightly-x86-node-density-heavy-25nodes-service-without-loki	N/A	periodic	Ci-operator config changed
periodic-ci-netobserv-netobserv-perf-tests-main-netobserv-aws-4.22-nightly-x86-cluster-density-v2-250nodes	N/A	periodic	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[Amoghrd]

/pj-rehearse periodic-ci-netobserv-netobserv-perf-tests-main-netobserv-aws-4.22-nightly-x86-node-density-heavy-25nodes

[openshift-merge-bot]

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@Amoghrd: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.