MCO-2279: Add AWS-SNO job variants for 5.0#79344
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@isabella-janssen: This pull request references MCO-2199 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
approved
WalkthroughThis PR adds two periodic e2e test job definitions to the OpenShift machine-config-operator release-5.0 configuration. One job runs standard single-node disruptive tests on AWS weekly; the second runs the same tests under TechPreviewNoUpgrade feature set conditions. Both use matching AWS infrastructure and disruptive test suite configurations. ChangesMCO Single-Node Disruptive Periodic Tests
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0__periodics.yaml (1)
158-166: ⚡ Quick winAdd
reporter_configto the two new SNO disruptive periodics for alert parity.Both new disruptive jobs omit
reporter_config, unlike the other disruptive variants in this file. That makes weekly failures easier to miss during stabilization.🔧 Suggested patch
- as: e2e-aws-mco-single-node-disruptive cron: 0 0 * * 0 + reporter_config: + channel: '#trt-alert-mco' + job_states_to_report: + - failure + - error + report_template: ':failed: Job *{{.Spec.Job}}* ended with *{{.Status.State}}*. + <{{.Status.URL}}|View logs> {{end}}' steps: cluster_profile: openshift-org-aws env: TEST_SUITE: openshift/machine-config-operator/disruptive @@ - as: e2e-aws-mco-single-node-disruptive-techpreview cron: 0 0 * * 6 + reporter_config: + channel: '#trt-alert-mco' + job_states_to_report: + - failure + - error + report_template: ':failed: Job *{{.Spec.Job}}* ended with *{{.Status.State}}*. + <{{.Status.URL}}|View logs> {{end}}' steps: cluster_profile: openshift-org-aws env: FEATURE_SET: TechPreviewNoUpgradeAlso applies to: 292-299
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0__periodics.yaml` around lines 158 - 166, The two new SNO disruptive periodics that use TEST_SUITE "openshift/machine-config-operator/disruptive" and workflow "openshift-e2e-aws-single-node" are missing reporter_config; add the same reporter_config block used by the other disruptive variants in this file (copy the reporter_config stanza from an existing disruptive job) to both SNO disruptive jobs (the one shown and the other at the 292-299 location) so their failures surface to alerts and dashboards.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0__periodics.yaml`:
- Around line 158-166: The two new SNO disruptive periodics that use TEST_SUITE
"openshift/machine-config-operator/disruptive" and workflow
"openshift-e2e-aws-single-node" are missing reporter_config; add the same
reporter_config block used by the other disruptive variants in this file (copy
the reporter_config stanza from an existing disruptive job) to both SNO
disruptive jobs (the one shown and the other at the 292-299 location) so their
failures surface to alerts and dashboards.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: de05e181-1be5-4f4c-9376-898f7fbf7987
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0__periodics.yaml
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy, isabella-janssen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse |
|
@isabella-janssen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retitle MCO-2279: Add AWS-SNO job variants for 5.0 |
openshift-ci
Bot
changed the title
|
@isabella-janssen: This pull request references MCO-2279 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pj-rehearse ack Tests are failing, but that is expected. The test launched as expected, so this is good to go. |
|
@isabella-janssen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
@isabella-janssen: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
Bot
merged commit f708841
into
openshift:main
3 participants
This adds a SNO and techpreview SNO suite for the MCO's disruptive tests for 5.0. This introduces the suite in 5.0 and running only once per week to allow us to test and stabilize the suites before running them at a more regular cadence. These tests should not contribute to our component readiness due to the following filtering that exists currently in Sippy:
https://github.com/openshift/sippy/blob/main/pkg/variantregistry/ocp.go#L773-L784