DNM Set gc-metrics=true for control-plane chain workloads#79346
DNM Set gc-metrics=true for control-plane chain workloads#79346mohit-sheth wants to merge 1 commit into
Conversation
Enable gc-metrics collection across all steps in the openshift-qe-control-plane chain: cluster-density-v2, node-density-cni, crd-scale, node-density, and udn-density-pods. Signed-off-by: Mohit Sheth <msheth@redhat.com>
|
Skipping CI for Draft Pull Request. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
WalkthroughThis PR enables garbage collection metrics collection by default across five OpenShift QE performance test steps. Environment variable defaults in YAML step definitions are toggled from ChangesGC Metrics Enablement
🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mohit-sheth The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.22-nightly-x86-payload-control-plane-6nodes |
|
@mohit-sheth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.22-nightly-x86-payload-control-plane-6nodes |
|
@mohit-sheth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
A total of 675 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
mohit-sheth
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ci-operator/step-registry/openshift-qe/cluster-density-v2/openshift-qe-cluster-density-v2-ref.yaml (1)
25-40:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winDuplicate environment variable definition.
The
GCenvironment variable is defined twice (lines 25-28 and 37-40). In YAML step registry definitions, duplicate environment variable names cause the second definition to override the first. While not introduced by this PR, this duplication should be resolved by removing one definition.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/step-registry/openshift-qe/cluster-density-v2/openshift-qe-cluster-density-v2-ref.yaml` around lines 25 - 40, Remove the duplicate GC environment variable entry and keep a single GC definition (ensure the retained block has the correct wording/typos fixed); specifically, delete one of the GC blocks so only one GC remains alongside GC_METRICS and PROFILE_TYPE, preserving the intended default "true" and the correct documentation text.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In
`@ci-operator/step-registry/openshift-qe/cluster-density-v2/openshift-qe-cluster-density-v2-ref.yaml`:
- Around line 25-40: Remove the duplicate GC environment variable entry and keep
a single GC definition (ensure the retained block has the correct wording/typos
fixed); specifically, delete one of the GC blocks so only one GC remains
alongside GC_METRICS and PROFILE_TYPE, preserving the intended default "true"
and the correct documentation text.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 7ab1f35e-e0bb-487d-9cbf-b8a35c6142e2
📒 Files selected for processing (5)
ci-operator/step-registry/openshift-qe/cluster-density-v2/openshift-qe-cluster-density-v2-ref.yamlci-operator/step-registry/openshift-qe/crd-scale/openshift-qe-crd-scale-commands.shci-operator/step-registry/openshift-qe/node-density-cni/openshift-qe-node-density-cni-ref.yamlci-operator/step-registry/openshift-qe/node-density/openshift-qe-node-density-commands.shci-operator/step-registry/openshift-qe/udn-density-pods/openshift-qe-udn-density-pods-commands.sh
|
/pj-rehearse periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.22-nightly-x86-payload-control-plane-6nodes |
|
@mohit-sheth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.21-nightly-x86-payload-control-plane-6nodes |
|
@mohit-sheth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-5.0-nightly-x86-payload-control-plane-6nodes |
|
@mohit-sheth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mohit-sheth: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Enable gc-metrics collection across all steps in the openshift-qe-control-plane chain: cluster-density-v2, node-density-cni, crd-scale, node-density, and udn-density-pods.
gc-metrics enabled for control-plane chain workloads
This PR enables garbage collection metrics collection by default across all performance test steps in the openshift-qe control-plane chain. The affected workloads are:
falsetotrueby defaultfalsetotrueby default--gc-metricsflag changed fromfalsetotruein the kube-burner invocation--gc-metricsflag changed fromfalsetotruein the workload runner--gc-metricsflag changed fromfalsetotruein the workload runnerImpact: Garbage collection metrics will now be collected by default during these performance tests, enabling better observability of GC behavior across control-plane workloads. This can be disabled on a per-invocation basis if needed by setting the environment variable or flag to
false.