Skip to content

ci-operator: ARO-HCP: bump snapshot timeout#79367

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
stevekuznetsov:skuznets/snapshot-timer
May 16, 2026
Merged

ci-operator: ARO-HCP: bump snapshot timeout#79367
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
stevekuznetsov:skuznets/snapshot-timer

Conversation

@stevekuznetsov
Copy link
Copy Markdown
Contributor

@stevekuznetsov stevekuznetsov commented May 16, 2026

This PR increases the timeout for the ARO-HCP (Azure Red Hat OpenShift - Hosted Control Plane) gather snapshot CI step from 5 minutes to 20 minutes.

The change affects the OpenShift CI infrastructure configuration, specifically the step registry definition that executes during snapshot gathering operations for ARO-HCP. By extending the timeout from 5 to 20 minutes, this allows the snapshot gathering step more time to complete, reducing the likelihood of timeout failures during CI runs for ARO-HCP.

Signed-off-by: Steve Kuznetsov <stekuznetsov@microsoft.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 306823eb-4de7-4127-adee-5368bf312058

📥 Commits

Reviewing files that changed from the base of the PR and between 650f61a and e16e560.

📒 Files selected for processing (1)
  • ci-operator/step-registry/aro-hcp/gather/snapshot/aro-hcp-gather-snapshot-ref.yaml

Walkthrough

This PR updates the timeout configuration for the ARO HCP gather snapshot step, increasing it from 5 minutes to 20 minutes. The change affects only a single line in the step registry YAML configuration file.

Changes

ARO HCP Gather Step Timeout Update

Layer / File(s) Summary
Gather step timeout configuration
ci-operator/step-registry/aro-hcp/gather/snapshot/aro-hcp-gather-snapshot-ref.yaml
The timeout field for the aro-hcp-gather-snapshot gather step is increased from 5m to 20m.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: increasing the snapshot timeout for the ARO-HCP gather step.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Custom check is for Ginkgo test titles. This PR only modifies a YAML CI config file, not test code. No Ginkgo tests present.
Test Structure And Quality ✅ Passed The custom check reviews Ginkgo test code, but this PR contains only YAML CI/CD config files and utility scripts. No Ginkgo test files are present, so the check is not applicable.
Microshift Test Compatibility ✅ Passed The PR only modifies a CI step registry YAML configuration file to increase a timeout value. No new Ginkgo e2e tests are added, so the MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR contains no Ginkgo e2e tests. It only modifies CI configuration (YAML timeout value). The SNO compatibility check applies only when new e2e tests are added, making it not applicable here.
Topology-Aware Scheduling Compatibility ✅ Passed The change modifies only a CI step registry timeout (5m to 20m). This is a CI configuration file, not a deployment manifest or operator code. No scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR primarily modifies YAML configuration file (increasing timeout value) and utility Go tools, not OTE test binaries. The OTE Binary Stdout Contract check is not applicable to these changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only modifies a YAML CI configuration file (timeout value), not adding any Ginkgo e2e tests. The custom check applies only to new test code.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@jupierce
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot requested review from roivaz and venkateshsredhat May 16, 2026 16:57
@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 16, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@stevekuznetsov: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-Azure-ARO-HCP-main-e2e-parallel Azure/ARO-HCP presubmit Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 16, 2026

@stevekuznetsov: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Contributor

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@stevekuznetsov
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@stevekuznetsov: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 16, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jupierce, raelga, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 93f7045 into openshift:main May 16, 2026
11 checks passed
obochan-rh pushed a commit to obochan-rh/release that referenced this pull request May 17, 2026
Signed-off-by: Steve Kuznetsov <stekuznetsov@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants