Skip to content

[DNM] Sync Serverless CI config/#79391

Closed
maschmid wants to merge 1 commit into
openshift:mainfrom
maschmid:sync-serverless-ci
Closed

[DNM] Sync Serverless CI config/#79391
maschmid wants to merge 1 commit into
openshift:mainfrom
maschmid:sync-serverless-ci

Conversation

@maschmid
Copy link
Copy Markdown
Contributor

Do not merge, test only

@maschmid
Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 4f373389-6995-4203-bd48-65441e94faae

📥 Commits

Reviewing files that changed from the base of the PR and between ce0233c and a4c5335.

⛔ Files ignored due to path filters (9)
  • ci-operator/jobs/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.21-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.21-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/eventing/openshift-knative-eventing-release-v1.17-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/eventing/openshift-knative-eventing-release-v1.21-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.17-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.21-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (11)
  • ci-operator/config/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17__421.yaml
  • ci-operator/config/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.21__421.yaml
  • ci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17__421.yaml
  • ci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.21__421.yaml
  • ci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.17__421.yaml
  • ci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.21__421.yaml
  • ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__416.yaml
  • ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__420.yaml
  • ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__421.yaml
  • ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.17__421.yaml
  • ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.21__421.yaml

Walkthrough

This PR adds Slack-based reporter configurations to test jobs across five Knative repositories to enable automated CI status notifications. Each modification adds a reporter_config block specifying the target Slack channel, job states to report (success, failure, error), and a templated message format with conditional emoji and log links.

Changes

CI Job Reporter Configuration

Layer / File(s) Summary
Eventing-istio reporter configurations
ci-operator/config/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17__421.yaml, ...v1.21__421.yaml
Reporter configs added to e2e-tests-c for both v1.17 and v1.21, posting success/failure/error states to #knative-eventing-ci with emoji-formatted status messages and log links.
Eventing-kafka-broker reporter configurations
ci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17__421.yaml, ...v1.21__421.yaml
Reporter configs added to five test variants in v1.17 (test-conformance-c, test-e2e-c, test-reconciler-c, test-reconciler-encryption-auth-c, test-reconciler-keda-c) and four variants in v1.21, all reporting to #knative-eventing-ci.
Eventing reporter configurations
ci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.17__421.yaml, ...v1.21__421.yaml
Reporter configs added to four test variants (test-conformance-c, test-e2e-c, test-encryption-auth-e2e-c, test-reconciler-c) in both v1.17 and v1.21, posting to #knative-eventing-ci.
Serverless-operator reporter configurations
ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__416.yaml, ...main__420.yaml, ...main__421.yaml
Reporter configs added to eight test variants in v416 (kitchensink-e2e-c, kitchensink-upgrade-c, mesh-e2e-c, operator-e2e-c, test-soak-c, test-upgrade-c, ui-e2e-c, upstream-e2e-kafka-c) and seven variants in v421, plus kitchensink-upgrade-c in v420, all posting to #serverless-ci.
Serving reporter configurations
ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.17__421.yaml, ...v1.21__421.yaml
Reporter configs added to test-e2e-c for both v1.17 and v1.21, posting to #knative-serving-ci with conditional success and failure/error message formatting.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

The PR consists of homogeneous additions of identical reporter configuration patterns across multiple files and job definitions. Each change is a straightforward YAML configuration block addition with no logic modifications, deletions, or cross-cutting concerns requiring complex reasoning.

Suggested labels

rehearsals-ack

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title '[DNM] Sync Serverless CI config/' is partially related to the changeset; it indicates the general purpose (syncing CI config) but uses the vague '[DNM]' prefix indicating do-not-merge status, and the trailing slash suggests incomplete formatting. Clarify the title to be more specific about the actual change (e.g., 'Add reporter_config to Serverless CI jobs') or remove incomplete elements like the trailing slash if this is a final PR.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only YAML CI configuration files (ci-operator/config/) with no Ginkgo test definitions. The custom check for stable/deterministic test names is not applicable to CI configuration files.
Test Structure And Quality ✅ Passed PR contains only YAML CI configuration changes (reporter_config additions), no Ginkgo test code. Check not applicable to non-test code.
Microshift Test Compatibility ✅ Passed PR does not add new Ginkgo e2e tests. Only YAML CI configuration changes that add Slack reporter_config to existing test jobs. Check condition "when new tests are added" is not met.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies YAML CI configuration files adding reporter_config blocks for Slack notifications. No new Ginkgo e2e tests are added, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR adds Slack notification configs to CI job definitions. No deployment manifests, controllers, or scheduling constraints are modified.
Ote Binary Stdout Contract ✅ Passed PR contains only YAML CI configuration changes (reporter_config additions) with no Go source code modifications. The OTE Binary Stdout Contract check is inapplicable to CI configuration files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR contains only YAML CI configuration changes (reporter_config blocks for Slack notifications) and support utility files. No new Ginkgo e2e test code is added, making this check not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maschmid
Once this PR has been reviewed and has the lgtm label, please assign creydr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@maschmid: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-knative-eventing-istio-release-v1.21-421-e2e-tests-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-421-test-soak-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serving-release-v1.21-421-test-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-416-mesh-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-421-test-upgrade-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.17-421-test-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-416-upstream-e2e-kafka-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.21-421-test-reconciler-encryption-auth-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serving-release-v1.17-421-test-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-release-v1.21-421-test-conformance-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-release-v1.17-421-test-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-416-ui-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-416-operator-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-421-upstream-e2e-kafka-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-416-test-upgrade-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-release-v1.21-421-test-encryption-auth-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-release-v1.21-421-test-reconciler-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.17-421-test-reconciler-keda-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-release-v1.17-421-test-reconciler-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-release-v1.17-421-test-encryption-auth-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-421-operator-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.17-421-test-reconciler-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-416-kitchensink-upgrade-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.21-421-test-reconciler-keda-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-421-ui-e2e-c N/A periodic Ci-operator config changed

A total of 37 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 18, 2026

@maschmid: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@maschmid maschmid closed this May 18, 2026
@maschmid maschmid deleted the sync-serverless-ci branch May 18, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant