[DO NOT MERGE] Rerun 4.17.54 multi arch jobs#79398
Conversation
WalkthroughThis PR updates two OpenShift multiarch nightly CI configurations by standardizing test job identifiers. Four test entries across both files are renamed with a ChangesTest identifier standardization in multiarch nightly configurations
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 11 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rh-akhatavk The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.17.yaml`:
- Line 362: The job names are inconsistent: add or remove the "-test" suffix
consistently across similar weekly tests (e.g., change
"ocp-e2e-ovn-remote-libvirt-s390x-test" and
"ocp-e2e-ovn-remote-s2s-libvirt-ppc64le" and the entries referenced at lines
with "ocp-e2e-ovn-remote-..." to follow a single convention), so update the
identifiers in the YAML so all weekly Friday scheduled OVN remote libvirt jobs
either all include "-test" (preferred) or none do, and update any references to
those job names elsewhere in the file/config to match; alternatively, if the
suffix is conditional, add a short comment in the file documenting the exact
criteria for appending "-test" to job identifiers.
- Line 362: The test identifier was changed to
"ocp-e2e-ovn-remote-libvirt-s390x-test" which deviates from other branches that
use "ocp-e2e-ovn-remote-libvirt-s390x"; search for both strings across all repos
and CI systems (grep in this repo, other release branch configs, Prow job
definitions, job triggers, dashboards, monitoring rules, and external CI
consumers) to find any downstream references, update those references to the new
identifier if safe, or rename this entry back to
"ocp-e2e-ovn-remote-libvirt-s390x" to match the canonical name, and document the
change in the PR description so integrators are aware.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: fd394793-7527-492c-852c-af048ed18b78
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/multiarch/openshift-multiarch-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (2)
ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.17-upgrade-from-nightly-4.16.yamlci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.17.yaml
| TEST_TYPE: upgrade-conformance | ||
| workflow: openshift-upgrade-azure | ||
| - as: ocp-e2e-ovn-remote-libvirt-s390x | ||
| - as: ocp-e2e-ovn-remote-libvirt-s390x-test |
There was a problem hiding this comment.
Consider standardizing test identifiers consistently across similar tests.
The -test suffix is applied to some weekly tests (lines 362, 458) but not others with similar characteristics. For example, Line 473 (ocp-e2e-ovn-remote-s2s-libvirt-ppc64le) runs on the same weekly Friday schedule as line 362 but doesn't receive the -test suffix. This creates inconsistent naming conventions within the same configuration file.
If the goal is to standardize test identifiers with a -test suffix, consider applying it consistently across all similar test entries, or document the criteria for when the suffix should be applied.
Also applies to: 458-458, 473-473, 489-489
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.17.yaml`
at line 362, The job names are inconsistent: add or remove the "-test" suffix
consistently across similar weekly tests (e.g., change
"ocp-e2e-ovn-remote-libvirt-s390x-test" and
"ocp-e2e-ovn-remote-s2s-libvirt-ppc64le" and the entries referenced at lines
with "ocp-e2e-ovn-remote-..." to follow a single convention), so update the
identifiers in the YAML so all weekly Friday scheduled OVN remote libvirt jobs
either all include "-test" (preferred) or none do, and update any references to
those job names elsewhere in the file/config to match; alternatively, if the
suffix is conditional, add a short comment in the file documenting the exact
criteria for appending "-test" to job identifiers.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Search for references to the old test identifier across the codebase
echo "=== Searching for references to old test name ==="
rg -n --type=yaml --type=md --type=sh --type=py 'ocp-e2e-ovn-remote-libvirt-s390x' -g '!openshift-multiarch-main__nightly-4.17.yaml'
echo -e "\n=== Checking CI job configuration references ==="
fd -e yaml -e json . ci-operator/jobs/ --exec rg -l 'ocp-e2e-ovn-remote-libvirt-s390x'
echo -e "\n=== Checking for generated job configs ==="
fd . ci-operator/jobs/openshift/multiarch --exec cat {} | grep -n 'ocp-e2e-ovn-remote-libvirt-s390x' || echo "No matches in generated jobs"Repository: openshift/release
Length of output: 147
🏁 Script executed:
# Check if ci-operator/jobs is generated (typically ignored)
git ls-files -o -i -k --exclude-standard | head -20
# Get info on ci-operator/jobs directory
ls -la ci-operator/jobs/openshift/multiarch/ 2>/dev/null | head -10
# Check for .gitignore patterns that might indicate generated files
cat .gitignore | grep -i "ci-operator/jobs" || echo "No gitignore rules found for jobs dir"Repository: openshift/release
Length of output: 474
🏁 Script executed:
# More targeted search: check config files for references to old identifier
# Limit to openshift/multiarch configs only
rg 'ocp-e2e-ovn-remote-libvirt-s390x' ci-operator/config/openshift/multiarch/ --type=yaml -n | head -20
# Check if there are template references in step registry or workflows
rg 'ocp-e2e-ovn-remote-libvirt-s390x' ci-operator/step-registry/ --type=yaml -n 2>/dev/null | head -20Repository: openshift/release
Length of output: 1983
🏁 Script executed:
# Check the actual file to understand the change context
sed -n '360,365p' ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.17.yaml
# Also check around line 458 mentioned in scratchpad
sed -n '456,461p' ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.17.yamlRepository: openshift/release
Length of output: 396
Verify that renaming this test identifier won't break external references.
The test identifier in 4.17 (ocp-e2e-ovn-remote-libvirt-s390x-test) differs from all other multiarch release branches, which use ocp-e2e-ovn-remote-libvirt-s390x (without the -test suffix). If external systems (CI dashboards, monitoring, job triggers) reference this identifier, the rename could cause failures. Verify no downstream dependencies exist before committing this change.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.17.yaml`
at line 362, The test identifier was changed to
"ocp-e2e-ovn-remote-libvirt-s390x-test" which deviates from other branches that
use "ocp-e2e-ovn-remote-libvirt-s390x"; search for both strings across all repos
and CI systems (grep in this repo, other release branch configs, Prow job
definitions, job triggers, dashboards, monitoring rules, and external CI
consumers) to find any downstream references, update those references to the new
identifier if safe, or rename this entry back to
"ocp-e2e-ovn-remote-libvirt-s390x" to match the canonical name, and document the
change in the PR description so integrators are aware.
|
/pj-rehearse periodic-ci-openshift-multiarch-main-nightly-4.17-upgrade-from-nightly-4.16-ocp-ovn-remote-s2s-libvirt-multi-p-p-test |
|
@rh-akhatavk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-multiarch-main-nightly-4.17-upgrade-from-nightly-4.16-ocp-ovn-remote-libvirt-multi-z-z-test |
|
@rh-akhatavk: your |
|
/pj-rehearse periodic-ci-openshift-multiarch-main-nightly-4.17-upgrade-from-nightly-4.16-ocp-ovn-remote-libvirt-multi-z-z-test |
|
@rh-akhatavk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-multiarch-main-nightly-4.17-ocp-e2e-ovn-remote-libvirt-s390x-test |
|
@rh-akhatavk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-multiarch-main-nightly-4.17-ocp-fips-ovn-remote-libvirt-multi-z-z-test |
|
@rh-akhatavk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@rh-akhatavk, |
|
/pj-rehearse periodic-ci-openshift-multiarch-main-nightly-4.17-ocp-fips-ovn-remote-libvirt-multi-z-z-test |
|
@rh-akhatavk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@rh-akhatavk: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
This pull request updates the CI configuration for multi-architecture OpenShift 4.17 nightly build testing. Specifically, it modifies test job identifiers in two configuration files:
openshift-multiarch-main__nightly-4.17.yaml - Renames two test jobs by appending
-testsuffix:ocp-e2e-ovn-remote-libvirt-s390x→ocp-e2e-ovn-remote-libvirt-s390x-testocp-fips-ovn-remote-libvirt-multi-z-z→ocp-fips-ovn-remote-libvirt-multi-z-z-testopenshift-multiarch-main__nightly-4.17-upgrade-from-nightly-4.16.yaml - Renames two upgrade test jobs:
ocp-ovn-remote-libvirt-multi-z-z→ocp-ovn-remote-libvirt-multi-z-z-testocp-ovn-remote-s2s-libvirt-multi-p-p→ocp-ovn-remote-s2s-libvirt-multi-p-p-testThese changes affect the OpenShift multiarch CI pipeline, specifically the Libvirt-based E2E test jobs that validate multi-architecture (s390x, ppc64le, ARM) support. The "-test" suffix addition triggers Prow to re-run these periodic jobs for the 4.17.54 release cycle, which is reflected in the PR title "[DO NOT MERGE] Rerun 4.17.54 multi arch jobs". The title indicates this is a temporary/administrative change intended for re-execution of existing tests rather than merging new functionality into the main codebase.