Skip to content

ROSAENG-1077: use separated shard for hcp provision#79446

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bmeng:hcp-shard
May 20, 2026
Merged

ROSAENG-1077: use separated shard for hcp provision#79446
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bmeng:hcp-shard

Conversation

@bmeng
Copy link
Copy Markdown
Contributor

@bmeng bmeng commented May 19, 2026

  • Use the new created e2e shard for the CI testing
  • Update the test filter as the MC access should be available now

Summary

This PR updates the ROSA (Red Hat OpenShift Service on AWS) E2E CI testing configuration to use a new shard for HCP (Hosted Control Plane) test variants.

Changes

Updated the periodic test definitions in the OpenShift Online ROSA E2E CI configuration to change the test filter for HCP variants. The LABEL_FILTER environment variable is updated from excluding Machine Config access ('!Access:MC') to filtering by HCP platform ('Platform:HCP').

This change applies to five HCP test variants spanning multiple OpenShift versions:

  • Stable releases: 4.19, 4.20, 4.21
  • Candidate release: 4.22
  • Nightly release: 5.0

The classic STS (AWS Secure Token Service) test variants remain unchanged, still using the filter Platform:Classic && !Access:MC.

Impact

The HCP E2E tests will now use a separated shard with tests specifically labeled for the HCP platform. The test filter change reflects that Machine Config access is now available in HCP environments, eliminating the need to exclude those tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 19, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 19, 2026

@bmeng: This pull request references ROSAENG-1077 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

  • Use the new created e2e shard for the CI testing
  • Update the test filter as the MC access should be available now

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f55031df-fbfc-43ab-873f-a417afc69aa0

📥 Commits

Reviewing files that changed from the base of the PR and between b9a138c and c9d38f4.

📒 Files selected for processing (1)
  • ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__periodics.yaml

Walkthrough

OpenShift Online ROSA E2E periodic test jobs are updated to refine test targeting for HCP variants. Five job definitions (stable 4.19–4.21, candidate 4.22, nightly 5.0) replace their LABEL_FILTER label-selection logic with platform-based filtering and assign cluster sector explicitly.

Changes

HCP Test Configuration Updates

Layer / File(s) Summary
Update LABEL_FILTER and CLUSTER_SECTOR for HCP variants
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__periodics.yaml
Five HCP test variants (stable 4.19–4.21, candidate 4.22, nightly 5.0) have LABEL_FILTER changed from excluding Access:MC to filtering by Platform:HCP, and CLUSTER_SECTOR set to rosa-e2e. Other test variants remain unchanged.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested Labels

lgtm

Suggested Reviewers

  • ravitri
  • dustman9000
🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: updating ROSA E2E periodic workflow definitions to use a separated shard for HCP provision by changing the LABEL_FILTER from excluding MC access to filtering by Platform:HCP.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR modifies only YAML CI workflow configuration files, not Ginkgo test code. The custom check targets test code (It(), Describe(), etc.), which is not present in this PR.
Test Structure And Quality ✅ Passed PR modifies only YAML CI workflow configuration files. No Ginkgo test code is included. The check requires reviewing Ginkgo test code quality, making it not applicable to this PR.
Microshift Test Compatibility ✅ Passed PR modifies only CI/CD YAML configuration, not Ginkgo e2e tests. The custom check applies only when new tests are added, making it not applicable here.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo test code added. PR modifies only YAML CI configurations and scripts. Check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Check does not apply. PR modifies CI/CD test job configs (Prow), not deployment manifests, operator code, or controllers that would introduce topology-aware scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The OTE Binary Stdout Contract check is not applicable. The PR modifies only YAML CI workflow configuration files and CI infrastructure tools, not executable source code for OTE binaries.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies test filtering in YAML configuration, not adding new Ginkgo e2e tests. Check applies only to new tests being added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2026
@openshift-ci openshift-ci Bot requested review from jfrazierRedHat and tiwillia May 19, 2026 02:51
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@bmeng: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-nightly-5-0 N/A periodic Ci-operator config changed
periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-stable-4-19 N/A periodic Ci-operator config changed
periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-stable-4-20 N/A periodic Ci-operator config changed
periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-stable-4-21 N/A periodic Ci-operator config changed
periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-candidate-4-22 N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@bmeng
Copy link
Copy Markdown
Contributor Author

bmeng commented May 19, 2026

/pj-rehearse more

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bmeng
Copy link
Copy Markdown
Contributor Author

bmeng commented May 19, 2026

/retest

@bmeng
Copy link
Copy Markdown
Contributor Author

bmeng commented May 19, 2026

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-stable-4-19 periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-nightly-5-0

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bmeng
Copy link
Copy Markdown
Contributor Author

bmeng commented May 19, 2026

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-candidate-4-22

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bmeng
Copy link
Copy Markdown
Contributor Author

bmeng commented May 19, 2026

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-stable-4-21

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bmeng
Copy link
Copy Markdown
Contributor Author

bmeng commented May 19, 2026

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-stable-4-19 periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-nightly-5-0

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@deepsm007
Copy link
Copy Markdown
Contributor

/test openshift-image-mirror-mappings

@bmeng
Copy link
Copy Markdown
Contributor Author

bmeng commented May 19, 2026

/retest required

@bmeng
Copy link
Copy Markdown
Contributor Author

bmeng commented May 19, 2026

/hold
waiting for openshift-online/rosa-e2e#53

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2026
@bmeng
Copy link
Copy Markdown
Contributor Author

bmeng commented May 19, 2026

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 19, 2026
@bmeng
Copy link
Copy Markdown
Contributor Author

bmeng commented May 19, 2026

/retest required

@bmeng
Copy link
Copy Markdown
Contributor Author

bmeng commented May 19, 2026

/test openshift-image-mirror-mappings

@bmeng
Copy link
Copy Markdown
Contributor Author

bmeng commented May 19, 2026

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2026
@dustman9000
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, dustman9000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

@bmeng: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-stable-4-21 c9d38f4 link unknown /pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-stable-4-21
ci/rehearse/periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-stable-4-19 c9d38f4 link unknown /pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-stable-4-19
ci/rehearse/periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-nightly-5-0 c9d38f4 link unknown /pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-nightly-5-0
ci/rehearse/periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-candidate-4-22 c9d38f4 link unknown /pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-candidate-4-22

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit da6cec6 into openshift:main May 20, 2026
15 of 19 checks passed
wgahnagl pushed a commit to wgahnagl/release that referenced this pull request May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants