Skip to content

METAL-1831: Add periodic sync for NGS with rebasebot#79481

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
elfosardo:add-ngs-rebasebot-config
May 20, 2026
Merged

METAL-1831: Add periodic sync for NGS with rebasebot#79481
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
elfosardo:add-ngs-rebasebot-config

Conversation

@elfosardo
Copy link
Copy Markdown
Contributor

@elfosardo elfosardo commented May 19, 2026

Summary

This PR adds a new periodic rebasebot sync job to OpenShift's CI infrastructure for automatically rebasing the OpenStack networking-generic-switch project.

Changes

The PR adds a scheduled rebasebot job to the OpenShift CI configuration that will:

  • Sync upstream OpenStack project: Automatically tracks changes from openstack/networking-generic-switch on the master branch
  • Rebase into OpenShift fork: Applies those changes to OpenShift's openshift-networking-generic-switch:main branch
  • Use ironic-bot credentials: Leverages the existing metal3/ironic infrastructure team's bot credentials and GitHub app (ID 259896)
  • Run on schedule: Executes periodically at 10:40 AM on Monday, Wednesday, and Friday
  • Notify on completion: Sends results to the team-ocp-metal-platform Slack channel
  • Use consistent resources: Allocates 4Gi memory limits and 100m CPU/200Mi memory requests, consistent with other OpenStack jobs

The job follows the established pattern used by other OpenStack projects already configured in the rebasebot infrastructure (sushy, ironic, ironic-python-agent, ironic-prometheus-exporter), extending automated upstream tracking to the networking-generic-switch project.

@elfosardo elfosardo changed the title Add periodic sync for NGS with rebasebot METAL-1831: Add periodic sync for NGS with rebasebot May 19, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 19, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 19, 2026

@elfosardo: This pull request references METAL-1831 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 669d5926-5c53-428f-a4f9-f2f300e25a15

📥 Commits

Reviewing files that changed from the base of the PR and between 76d0cff and 63e72b5.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift-eng/rebasebot/openshift-eng-rebasebot-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift-eng/rebasebot/openshift-eng-rebasebot-main.yaml

Walkthrough

Adds a new scheduled rebasebot CI job for openstack-networking-generic-switch that runs on Monday, Wednesday, and Friday at 10:40 UTC. The job rebases changes from upstream openstack to the openshift fork and includes required credentials and resource configuration.

Changes

Scheduled Rebasebot Job

Layer / File(s) Summary
openstack-networking-generic-switch job definition
ci-operator/config/openshift-eng/rebasebot/openshift-eng-rebasebot-main.yaml
Adds a new test job entry that schedules rebasebot to run against openstack/networking-generic-switch:master, rebases into openshift/openstack-networking-generic-switch:main, configures secret mounts for Slack and ironic-bot credentials, and sets memory/cpu resource requests and limits.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'METAL-1831: Add periodic sync for NGS with rebasebot' accurately describes the main change: adding a scheduled rebasebot job for OpenStack Networking Generic Switch (NGS).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR adds CI/CD job configuration (YAML), not Ginkgo tests. The custom check for stable Ginkgo test names is not applicable to this change.
Test Structure And Quality ✅ Passed The custom check for Ginkgo test quality is not applicable. The PR modifies only a CI-operator YAML configuration file, not Ginkgo test code. No test files, Go code, or test assertions are present.
Microshift Test Compatibility ✅ Passed This PR does not add any new Ginkgo e2e tests. It only modifies a CI configuration file to add a periodic rebasebot sync job. The custom check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR does not add any Ginkgo e2e tests. It only updates CI/CD configuration (a rebasebot job entry). The SNO compatibility check is not applicable to CI configuration files.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies a ci-operator config file, not deployment manifests. No Kubernetes pod specs, scheduling constraints, or topology assumptions are present.
Ote Binary Stdout Contract ✅ Passed PR modifies only YAML CI configuration. No test code, OTE binaries, or process-level stdout operations added. Check is not applicable to configuration-only changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo e2e tests were added in this PR. The changes only add a rebasebot CI job configuration entry in a YAML file, not test code. The custom check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from mdbooth and theobarberbany May 19, 2026 15:25
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@elfosardo: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-eng-rebasebot-main-openstack-networking-generic-switch N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@elfosardo
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@elfosardo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@elfosardo
Copy link
Copy Markdown
Contributor Author

@elmiko @JoelSpeed @RadekManak please review and approve this, thanks!

@elfosardo
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@elfosardo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 20, 2026
@iurygregory
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2026
@JoelSpeed
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, iurygregory, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

@elfosardo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit cb7ab1e into openshift:main May 20, 2026
17 checks passed
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@openshift-ci[bot]: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

1 similar comment
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@openshift-ci[bot]: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

wgahnagl pushed a commit to wgahnagl/release that referenced this pull request May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants