Skip to content

reporter_config: propagate from jobs to config#79501

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
Prucek:deterministic-prowjobs
May 20, 2026
Merged

reporter_config: propagate from jobs to config#79501
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
Prucek:deterministic-prowjobs

Conversation

@Prucek
Copy link
Copy Markdown
Member

@Prucek Prucek commented May 20, 2026

Summary

This PR systematically adds Slack reporting configuration to test job definitions across the OpenShift CI infrastructure by introducing reporter_config blocks to ci-operator configuration files. The changes implement a standardized approach to propagate reporter settings from Prow jobs into the central ci-operator config, enabling consistent automated notifications of test results.

Changes

The PR updates 65 ci-operator configuration files across numerous OpenShift ecosystem projects. Each modification adds a reporter_config section to selected test jobs with:

  • Slack channel specification: Routes notifications to project-specific channels (e.g., #tektoncd-pipeline-ci, #odf-ocp-ci-results, #team-network-observability)
  • Job state filtering: Specifies which job outcomes trigger notifications (success, failure, error, and occasionally aborted)
  • Templated message formatting: Go templates that conditionally format Slack messages—showing green indicators for success and red/failed indicators for failures, including links to job logs via .Status.URL and job identifiers via .Spec.Job

Affected Components

Changes span 19+ projects including:

  • OpenShift Pipelines: Multiple release versions (1.11-1.22) and OCP version combinations
  • HyperShift: MCE periodic tests, particularly IBM Z conformance tests
  • ODF (OpenShift Data Foundation): Interop test suite across OCP 4.15-4.21
  • Network Observability: Performance test jobs
  • ROSA: E2E and classic tests
  • Quay, StackRox, Kueue, OLS: Component-specific test configurations
  • RedHat QE: Interop testing for CNV and ODF combinations
  • Additional infrastructure projects (WMCO, hyperfleet, codeready-toolchain)

Impact

This standardization ensures comprehensive Slack visibility into CI test execution across the release infrastructure, replacing manual status checks with automated notifications. All changes are configuration-only additions with no modifications to test logic or existing fields.

Total lines changed: ~500 additions across all files

@openshift-ci openshift-ci Bot requested review from amp-rh and asood-rh May 20, 2026 07:21
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

Walkthrough

This PR adds reporter_config blocks to 45+ CI test job definitions across the OpenShift release repository, enabling Slack notifications for job state changes. Each addition specifies a Slack channel, which job states to report (success/failure/error), and a Go-templated message format that varies by job state.

Changes

Slack reporter configuration for CI jobs

Layer / File(s) Summary
OpenShift Pipelines release test reporting
ci-operator/config/openshift-pipelines/release-tests/*
Adds reporter_config to 25+ release test job definitions across pipeline versions v1.11–v1.22, configuring Slack channel #tektoncd-pipeline-ci and state-conditional message templates for AWS, IBM Cloud, ROSA, and hypershift test variants.
Hypershift and periodic test reporting
ci-operator/config/openshift/hypershift/*periodics-mce.yaml, ci-operator/config/openshift/cluster-control-plane-machine-set-operator/*periodics.yaml
Adds reporter_config to 6 periodic test entries (IBMZ and S390X conformance, openstack) configuring Slack channels (#ibmz-prowci-notifier, #shiftstack-bot) and state-based message templates for Hypershift and control-plane MCE tests.
Infrastructure and specialized workload test reporting
ci-operator/config/openshift/kueue-operator/*, ci-operator/config/openshift/ols-load-generator/*, ci-operator/config/openshift/openshift-tests-private/*, ci-operator/config/openshift/release/*, ci-operator/config/openshift/windows-machine-config-operator/*, ci-operator/config/quay/quay-tests/*, ci-operator/config/red-hat-storage/ocs-ci/*, ci-operator/config/redhat-performance/backstage-performance/*, ci-operator/config/stackrox/stackrox/*
Adds reporter_config to 40+ test definitions across kueue, OLS load generator (10–1000 worker scales), OpenShift private tests, vSphere CSI, Windows operators, Quay, OCS storage, backstage performance, and StackRox jobs with project-specific Slack channels and failure/success state templates.
Interop testing configuration updates
ci-operator/config/RedHatQE/interop-testing/*, ci-operator/config/netobserv/netobserv-perf-tests/*, ci-operator/config/openshift-hyperfleet/hyperfleet-e2e/*, ci-operator/config/openshift-online/rosa-e2e/*, ci-operator/config/quay/quay-tests/*
Adds reporter_config to 8 interop test suites (CNV/ODF, network observability, hyperfleet, ROSA, Quay) configuring Slack channels and templated status messages with state-conditional rendering and logs links.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • openshift/release#78976: Migration from .config.prowgen slack_reporter to inline per-test reporter_config blocks with Slack channel and message templating.

Suggested labels

lgtm, rehearsals-ack

Suggested reviewers

  • aliok
  • deepsm007
  • gdbranco
🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'reporter_config: propagate from jobs to config' accurately summarizes the main change—adding reporter_config blocks across multiple CI job configurations throughout the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR modifies only YAML CI configuration files. The repository contains no Ginkgo test code, so the test name stability check is not applicable.
Test Structure And Quality ✅ Passed The PR modifies only YAML configuration files (ci-operator/config/*.yaml), not Ginkgo test code. The check for test structure quality is not applicable to CI configuration changes.
Microshift Test Compatibility ✅ Passed PR only adds reporter_config (Slack notification) blocks to existing CI test configurations in YAML files; no new Ginkgo e2e tests are added, so MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR contains only CI configuration (YAML) changes adding Slack reporter_config blocks. No new Ginkgo e2e tests are added, so SNO Test Compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR adds only reporter_config blocks for Slack notifications in CI job definitions; no deployment manifests, operator code, or scheduling constraints present.
Ote Binary Stdout Contract ✅ Passed PR contains only YAML CI configuration changes to test definitions, no Go code or executable code modifications; OTE Binary Stdout Contract check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests were added in this PR. Changes are exclusively CI/CD configuration file updates adding Slack reporter_config blocks, not test code.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Prucek: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kueue-operator-release-1.3-test-e2e-downstream-4-20-disruptive openshift/kueue-operator presubmit Ci-operator config changed
pull-ci-openshift-kueue-operator-release-1.3-test-e2e-downstream-4-21-disruptive openshift/kueue-operator presubmit Ci-operator config changed
pull-ci-openshift-kueue-operator-main-test-e2e-downstream-4-20-disruptive openshift/kueue-operator presubmit Ci-operator config changed
pull-ci-openshift-kueue-operator-main-test-e2e-downstream-4-21-disruptive openshift/kueue-operator presubmit Ci-operator config changed
periodic-ci-openshift-ols-load-generator-main-mcp-ols-load-test-1000workers-mcp N/A periodic Ci-operator config changed
periodic-ci-openshift-pipelines-release-tests-release-v1.17-openshift-pipelines-ocp4.17-lp-rosa-classic-openshift-pipelines-interop-rosa-aws N/A periodic Ci-operator config changed
periodic-ci-quay-quay-tests-master-ocp-4.23-quay-lp-interop-aws-fips N/A periodic Ci-operator config changed
periodic-ci-netobserv-netobserv-perf-tests-main-netobserv-aws-4.22-nightly-x86-cluster-density-v2-250nodes N/A periodic Ci-operator config changed
periodic-ci-openshift-pipelines-release-tests-release-v1.15-openshift-pipelines-ocp4.16-lp-interop-openshift-pipelines-interop-aws N/A periodic Ci-operator config changed
periodic-ci-openshift-pipelines-release-tests-release-v1.15-openshift-pipelines-ocp4.15-lp-interop-openshift-pipelines-interop-aws N/A periodic Ci-operator config changed
periodic-ci-red-hat-storage-ocs-ci-master-odf-ocp4.20-lp-interop-odf-interop-aws N/A periodic Ci-operator config changed
periodic-ci-openshift-kueue-operator-release-1.3-test-e2e-downstream-4-20-disruptive N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.20-e2e-vsphere-ovn-csi N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-azure-ipi-ovn-hypershift-arm-nodepool-mgmt-f7 N/A periodic Ci-operator config changed
periodic-ci-openshift-pipelines-release-tests-release-v1.19-openshift-pipelines-ocp4.20-lp-interop-openshift-pipelines-interop-aws N/A periodic Ci-operator config changed
periodic-ci-red-hat-storage-ocs-ci-master-odf-ocp-4.21-lp-interop-cr-odf-interop-aws N/A periodic Ci-operator config changed
periodic-ci-openshift-pipelines-release-tests-release-v1.20-openshift-pipelines-ocp4.20-lp-interop-openshift-pipelines-interop-aws-fips N/A periodic Ci-operator config changed
periodic-ci-openshift-pipelines-release-tests-release-v1.14-openshift-pipelines-ocp4.15-lp-rosa-hypershift-openshift-pipelines-rosa-hypershift N/A periodic Ci-operator config changed
periodic-ci-openshift-ols-load-generator-main-mcp-ols-load-test-10workers-mcp N/A periodic Ci-operator config changed
periodic-ci-openshift-pipelines-release-tests-release-v1.15-openshift-pipelines-ocp4.17-lp-interop-openshift-pipelines-interop-aws N/A periodic Ci-operator config changed
periodic-ci-openshift-pipelines-release-tests-release-v1.13-openshift-pipelines-ocp4.15-lp-interop-openshift-pipelines-interop-aws N/A periodic Ci-operator config changed
periodic-ci-openshift-pipelines-release-tests-release-v1.17-openshift-pipelines-ocp4.18-lp-interop-openshift-pipelines-interop-aws N/A periodic Ci-operator config changed
periodic-ci-red-hat-storage-ocs-ci-master-odf-ocp4.19-lp-interop-odf-interop-aws N/A periodic Ci-operator config changed
periodic-ci-RedHatQE-interop-testing-master-cnv-odf-ocp-4.22-lp-interop-aws-fips N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-ibmz-ovn-conformance N/A periodic Ci-operator config changed

A total of 96 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.11__openshift-pipelines-ocp4.14-lp-interop.yaml`:
- Around line 32-41: You changed the reporter_config (report_template) in the CI
config but did not regenerate downstream CI artifacts; run the repository's
generation step (execute `make update`) to regenerate all generated artifacts,
verify the generated diffs reflect the reporter_config/report_template change,
and include and commit those resulting files (the updated generated CI
job/config diffs) alongside this ci-operator/config change so downstream
artifacts remain in sync.

In
`@ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.15__openshift-pipelines-ocp4.16-lp-rosa-hypershift.yaml`:
- Around line 44-53: You changed the CI reporter settings (see reporter_config
and report_template) but didn't regenerate downstream artifacts; run the
repository's generation step (execute make update) to regenerate CI artifacts,
commit the updated generated files produced by that command, and push those
changes so the CI config change under ci-operator/config is accompanied by the
corresponding generated outputs.

In
`@ci-operator/config/RedHatQE/interop-testing/RedHatQE-interop-testing-master__cnv-odf-ocp-4.23-lp-interop.yaml`:
- Line 81: The YAML channel value is set to '`#cnv-release-4-22-z`' but should
match the 4.23 release; update the channel key in this cnv-odf-ocp-4.23 config
by replacing the current value '`#cnv-release-4-22-z`' with '`#cnv-release-4-23-z`'
so notifications align with the 4.23 versioning pattern.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0b55b310-86d8-4ab2-b942-3540619efa87

📥 Commits

Reviewing files that changed from the base of the PR and between 87f83f6 and 863d4d3.

📒 Files selected for processing (57)
  • ci-operator/config/RedHatQE/interop-testing/RedHatQE-interop-testing-master__cnv-odf-ocp-4.22-lp-interop.yaml
  • ci-operator/config/RedHatQE/interop-testing/RedHatQE-interop-testing-master__cnv-odf-ocp-4.23-lp-interop.yaml
  • ci-operator/config/codeready-toolchain/toolchain-e2e/codeready-toolchain-toolchain-e2e-master.yaml
  • ci-operator/config/netobserv/netobserv-perf-tests/netobserv-netobserv-perf-tests-main__netobserv-aws-4.22-nightly-x86.yaml
  • ci-operator/config/openshift-hyperfleet/hyperfleet-e2e/openshift-hyperfleet-hyperfleet-e2e-main__e2e.yaml
  • ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.11__openshift-pipelines-ocp4.14-lp-interop.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.13__openshift-pipelines-ocp4.15-lp-interop.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.14__openshift-pipelines-ocp4.14-lp-interop.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.14__openshift-pipelines-ocp4.15-lp-interop.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.14__openshift-pipelines-ocp4.15-lp-rosa-hypershift.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.14__openshift-pipelines-ocp4.16-lp-interop.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.15__openshift-pipelines-ocp4.15-lp-interop.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.15__openshift-pipelines-ocp4.16-lp-interop.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.15__openshift-pipelines-ocp4.16-lp-rosa-hypershift.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.15__openshift-pipelines-ocp4.17-lp-interop.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.15__openshift-pipelines-ocp4.18-lp-interop.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.16__openshift-pipelines-ocp4.17-lp-rosa-classic.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.17__openshift-pipelines-ocp4.17-lp-rosa-classic.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.17__openshift-pipelines-ocp4.17-lp-rosa-hypershift.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.17__openshift-pipelines-ocp4.18-lp-interop.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.18__openshift-pipelines-ocp4.19-lp-interop.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.19__openshift-pipelines-ocp4.20-lp-interop.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.20__openshift-pipelines-ocp-4.21-lp-interop-cr.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.20__openshift-pipelines-ocp4.20-lp-interop.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.21__openshift-pipelines-ocp-4.21-lp-interop-cr.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.21__openshift-pipelines-ocp-4.21-lp-interop.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.21__openshift-pipelines-ocp4.21-e2e-osp.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.22__ocp-4.22-lp-interop.yaml
  • ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.22__openshift-pipelines-ocp4.21-lp-rosa-hypershift.yaml
  • ci-operator/config/openshift/cluster-control-plane-machine-set-operator/openshift-cluster-control-plane-machine-set-operator-release-4.14__periodics.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.16__periodics-mce.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.17__periodics-mce.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.18__periodics-mce.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.19__periodics-mce.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.20__periodics-mce.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.21__periodics-mce.yaml
  • ci-operator/config/openshift/kueue-operator/openshift-kueue-operator-main.yaml
  • ci-operator/config/openshift/kueue-operator/openshift-kueue-operator-release-1.3.yaml
  • ci-operator/config/openshift/ols-load-generator/openshift-ols-load-generator-main__mcp.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.16__amd64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.20.yaml
  • ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml
  • ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-4.22-quay-lp-interop.yaml
  • ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-4.23-quay-lp-interop.yaml
  • ci-operator/config/red-hat-storage/ocs-ci/red-hat-storage-ocs-ci-master__odf-ocp-4.21-lp-interop-cr.yaml
  • ci-operator/config/red-hat-storage/ocs-ci/red-hat-storage-ocs-ci-master__odf-ocp4.15-lp-interop.yaml
  • ci-operator/config/red-hat-storage/ocs-ci/red-hat-storage-ocs-ci-master__odf-ocp4.16-lp-interop.yaml
  • ci-operator/config/red-hat-storage/ocs-ci/red-hat-storage-ocs-ci-master__odf-ocp4.17-lp-interop.yaml
  • ci-operator/config/red-hat-storage/ocs-ci/red-hat-storage-ocs-ci-master__odf-ocp4.18-lp-interop.yaml
  • ci-operator/config/red-hat-storage/ocs-ci/red-hat-storage-ocs-ci-master__odf-ocp4.19-lp-interop.yaml
  • ci-operator/config/red-hat-storage/ocs-ci/red-hat-storage-ocs-ci-master__odf-ocp4.20-lp-interop.yaml
  • ci-operator/config/red-hat-storage/ocs-ci/red-hat-storage-ocs-ci-master__odf-ocp4.21-lp-interop.yaml
  • ci-operator/config/redhat-performance/backstage-performance/redhat-performance-backstage-performance-main.yaml
  • ci-operator/config/stackrox/stackrox/stackrox-stackrox-master__ocp-4.21-lp-interop-cr-acs-latest.yaml
  • ci-operator/config/stackrox/stackrox/stackrox-stackrox-release-4.9__ocp-4-21-lp-interop-cr.yaml

Comment on lines +32 to +41
reporter_config:
channel: '#tektoncd-pipeline-ci'
job_states_to_report:
- success
- failure
- error
report_template: '{{if eq .Status.State "success"}} :slack-green: Job *{{.Spec.Job}}*
ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs> {{else}} :failed:
Job *{{.Spec.Job}}* ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs>
{{end}}'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Regenerate generated CI artifacts for this config change.

Please run make update and include resulting generated diffs (if any) so downstream job/config artifacts stay in sync with this ci-operator/config update.

As per coding guidelines, "After modifying CI configuration files in ci-operator/config/, regenerate downstream artifacts by running make update."

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.11__openshift-pipelines-ocp4.14-lp-interop.yaml`
around lines 32 - 41, You changed the reporter_config (report_template) in the
CI config but did not regenerate downstream CI artifacts; run the repository's
generation step (execute `make update`) to regenerate all generated artifacts,
verify the generated diffs reflect the reporter_config/report_template change,
and include and commit those resulting files (the updated generated CI
job/config diffs) alongside this ci-operator/config change so downstream
artifacts remain in sync.

Comment on lines +44 to +53
reporter_config:
channel: '#tektoncd-pipeline-ci'
job_states_to_report:
- success
- failure
- error
report_template: '{{if eq .Status.State "success"}} :slack-green: Job *{{.Spec.Job}}*
ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs> {{else}} :failed:
Job *{{.Spec.Job}}* ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs>
{{end}}'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Run make update for this CI config change before merge.

This PR modifies files under ci-operator/config/, but the required downstream artifact regeneration is not shown in the provided changes. Please run make update and include any generated updates.

As per coding guidelines, "After modifying CI configuration files in ci-operator/config/, regenerate downstream artifacts by running make update."

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.15__openshift-pipelines-ocp4.16-lp-rosa-hypershift.yaml`
around lines 44 - 53, You changed the CI reporter settings (see reporter_config
and report_template) but didn't regenerate downstream artifacts; run the
repository's generation step (execute make update) to regenerate CI artifacts,
commit the updated generated files produced by that command, and push those
changes so the CI config change under ci-operator/config is accompanied by the
corresponding generated outputs.

- as: aws-fips
cron: 0 23 31 2 *
reporter_config:
channel: '#cnv-release-4-22-z'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Compare channel assignments for closely-related 4.22/4.23 interop configs.
fd -a 'RedHatQE-interop-testing-master__cnv-odf-ocp-4\.2[23]-lp-interop\.yaml$' ci-operator/config/RedHatQE/interop-testing \
| xargs -r rg -n -C2 'variant:|as: aws-fips|channel:'

Repository: openshift/release

Length of output: 3578


🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Look for all channel assignments in 4.23-related configs to see if there's a pattern
fd -a 'cnv-odf-ocp-4\.23' ci-operator/config/RedHatQE/interop-testing \
| xargs -r rg -n 'channel:' 

# Also search for any references to 4-23-z channel in the entire codebase
rg -n 'cnv-release-4-23-z' ci-operator/config/

Repository: openshift/release

Length of output: 99


🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Look at channel assignments in other cnv configs to see if there's a versioning pattern
rg -n 'channel:.*cnv-release' ci-operator/config/RedHatQE/interop-testing | sort -u

# Also check if 4.22 was recently copied to create 4.23
fd -a 'cnv-odf-ocp-4\.2[0-9]-lp-interop\.yaml$' ci-operator/config/RedHatQE/interop-testing | sort

Repository: openshift/release

Length of output: 1785


Update the Slack channel to match the 4.23 version.

Line 81 uses #cnv-release-4-22-z, but the pattern across all cnv-odf-ocp configs shows each version uses its corresponding channel (4.19→4-19-z, 4.20→4-20-z, 4.21→4-21-z, 4.22→4-22-z). The 4.23 config should use #cnv-release-4-23-z to align with the established versioning pattern and ensure notifications route correctly.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/RedHatQE/interop-testing/RedHatQE-interop-testing-master__cnv-odf-ocp-4.23-lp-interop.yaml`
at line 81, The YAML channel value is set to '`#cnv-release-4-22-z`' but should
match the 4.23 release; update the channel key in this cnv-odf-ocp-4.23 config
by replacing the current value '`#cnv-release-4-22-z`' with '`#cnv-release-4-23-z`'
so notifications align with the 4.23 versioning pattern.

@danilo-gemoli
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, Prucek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Prucek
Copy link
Copy Markdown
Member Author

Prucek commented May 20, 2026

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@Prucek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 20, 2026
@Prucek
Copy link
Copy Markdown
Member Author

Prucek commented May 20, 2026

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

@Prucek: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 8f34dd9 into openshift:main May 20, 2026
15 checks passed
wgahnagl pushed a commit to wgahnagl/release that referenced this pull request May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants