reporter_config: propagate from jobs to config#79501
Conversation
WalkthroughThis PR adds ChangesSlack reporter configuration for CI jobs
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER]
A total of 96 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.11__openshift-pipelines-ocp4.14-lp-interop.yaml`:
- Around line 32-41: You changed the reporter_config (report_template) in the CI
config but did not regenerate downstream CI artifacts; run the repository's
generation step (execute `make update`) to regenerate all generated artifacts,
verify the generated diffs reflect the reporter_config/report_template change,
and include and commit those resulting files (the updated generated CI
job/config diffs) alongside this ci-operator/config change so downstream
artifacts remain in sync.
In
`@ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.15__openshift-pipelines-ocp4.16-lp-rosa-hypershift.yaml`:
- Around line 44-53: You changed the CI reporter settings (see reporter_config
and report_template) but didn't regenerate downstream artifacts; run the
repository's generation step (execute make update) to regenerate CI artifacts,
commit the updated generated files produced by that command, and push those
changes so the CI config change under ci-operator/config is accompanied by the
corresponding generated outputs.
In
`@ci-operator/config/RedHatQE/interop-testing/RedHatQE-interop-testing-master__cnv-odf-ocp-4.23-lp-interop.yaml`:
- Line 81: The YAML channel value is set to '`#cnv-release-4-22-z`' but should
match the 4.23 release; update the channel key in this cnv-odf-ocp-4.23 config
by replacing the current value '`#cnv-release-4-22-z`' with '`#cnv-release-4-23-z`'
so notifications align with the 4.23 versioning pattern.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 0b55b310-86d8-4ab2-b942-3540619efa87
📒 Files selected for processing (57)
ci-operator/config/RedHatQE/interop-testing/RedHatQE-interop-testing-master__cnv-odf-ocp-4.22-lp-interop.yamlci-operator/config/RedHatQE/interop-testing/RedHatQE-interop-testing-master__cnv-odf-ocp-4.23-lp-interop.yamlci-operator/config/codeready-toolchain/toolchain-e2e/codeready-toolchain-toolchain-e2e-master.yamlci-operator/config/netobserv/netobserv-perf-tests/netobserv-netobserv-perf-tests-main__netobserv-aws-4.22-nightly-x86.yamlci-operator/config/openshift-hyperfleet/hyperfleet-e2e/openshift-hyperfleet-hyperfleet-e2e-main__e2e.yamlci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.11__openshift-pipelines-ocp4.14-lp-interop.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.13__openshift-pipelines-ocp4.15-lp-interop.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.14__openshift-pipelines-ocp4.14-lp-interop.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.14__openshift-pipelines-ocp4.15-lp-interop.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.14__openshift-pipelines-ocp4.15-lp-rosa-hypershift.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.14__openshift-pipelines-ocp4.16-lp-interop.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.15__openshift-pipelines-ocp4.15-lp-interop.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.15__openshift-pipelines-ocp4.16-lp-interop.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.15__openshift-pipelines-ocp4.16-lp-rosa-hypershift.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.15__openshift-pipelines-ocp4.17-lp-interop.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.15__openshift-pipelines-ocp4.18-lp-interop.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.16__openshift-pipelines-ocp4.17-lp-rosa-classic.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.17__openshift-pipelines-ocp4.17-lp-rosa-classic.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.17__openshift-pipelines-ocp4.17-lp-rosa-hypershift.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.17__openshift-pipelines-ocp4.18-lp-interop.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.18__openshift-pipelines-ocp4.19-lp-interop.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.19__openshift-pipelines-ocp4.20-lp-interop.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.20__openshift-pipelines-ocp-4.21-lp-interop-cr.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.20__openshift-pipelines-ocp4.20-lp-interop.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.21__openshift-pipelines-ocp-4.21-lp-interop-cr.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.21__openshift-pipelines-ocp-4.21-lp-interop.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.21__openshift-pipelines-ocp4.21-e2e-osp.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.22__ocp-4.22-lp-interop.yamlci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.22__openshift-pipelines-ocp4.21-lp-rosa-hypershift.yamlci-operator/config/openshift/cluster-control-plane-machine-set-operator/openshift-cluster-control-plane-machine-set-operator-release-4.14__periodics.yamlci-operator/config/openshift/hypershift/openshift-hypershift-release-4.16__periodics-mce.yamlci-operator/config/openshift/hypershift/openshift-hypershift-release-4.17__periodics-mce.yamlci-operator/config/openshift/hypershift/openshift-hypershift-release-4.18__periodics-mce.yamlci-operator/config/openshift/hypershift/openshift-hypershift-release-4.19__periodics-mce.yamlci-operator/config/openshift/hypershift/openshift-hypershift-release-4.20__periodics-mce.yamlci-operator/config/openshift/hypershift/openshift-hypershift-release-4.21__periodics-mce.yamlci-operator/config/openshift/kueue-operator/openshift-kueue-operator-main.yamlci-operator/config/openshift/kueue-operator/openshift-kueue-operator-release-1.3.yamlci-operator/config/openshift/ols-load-generator/openshift-ols-load-generator-main__mcp.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.16__amd64-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yamlci-operator/config/openshift/release/openshift-release-main__nightly-4.20.yamlci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yamlci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-4.22-quay-lp-interop.yamlci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-4.23-quay-lp-interop.yamlci-operator/config/red-hat-storage/ocs-ci/red-hat-storage-ocs-ci-master__odf-ocp-4.21-lp-interop-cr.yamlci-operator/config/red-hat-storage/ocs-ci/red-hat-storage-ocs-ci-master__odf-ocp4.15-lp-interop.yamlci-operator/config/red-hat-storage/ocs-ci/red-hat-storage-ocs-ci-master__odf-ocp4.16-lp-interop.yamlci-operator/config/red-hat-storage/ocs-ci/red-hat-storage-ocs-ci-master__odf-ocp4.17-lp-interop.yamlci-operator/config/red-hat-storage/ocs-ci/red-hat-storage-ocs-ci-master__odf-ocp4.18-lp-interop.yamlci-operator/config/red-hat-storage/ocs-ci/red-hat-storage-ocs-ci-master__odf-ocp4.19-lp-interop.yamlci-operator/config/red-hat-storage/ocs-ci/red-hat-storage-ocs-ci-master__odf-ocp4.20-lp-interop.yamlci-operator/config/red-hat-storage/ocs-ci/red-hat-storage-ocs-ci-master__odf-ocp4.21-lp-interop.yamlci-operator/config/redhat-performance/backstage-performance/redhat-performance-backstage-performance-main.yamlci-operator/config/stackrox/stackrox/stackrox-stackrox-master__ocp-4.21-lp-interop-cr-acs-latest.yamlci-operator/config/stackrox/stackrox/stackrox-stackrox-release-4.9__ocp-4-21-lp-interop-cr.yaml
| reporter_config: | ||
| channel: '#tektoncd-pipeline-ci' | ||
| job_states_to_report: | ||
| - success | ||
| - failure | ||
| - error | ||
| report_template: '{{if eq .Status.State "success"}} :slack-green: Job *{{.Spec.Job}}* | ||
| ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs> {{else}} :failed: | ||
| Job *{{.Spec.Job}}* ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs> | ||
| {{end}}' |
There was a problem hiding this comment.
Regenerate generated CI artifacts for this config change.
Please run make update and include resulting generated diffs (if any) so downstream job/config artifacts stay in sync with this ci-operator/config update.
As per coding guidelines, "After modifying CI configuration files in ci-operator/config/, regenerate downstream artifacts by running make update."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.11__openshift-pipelines-ocp4.14-lp-interop.yaml`
around lines 32 - 41, You changed the reporter_config (report_template) in the
CI config but did not regenerate downstream CI artifacts; run the repository's
generation step (execute `make update`) to regenerate all generated artifacts,
verify the generated diffs reflect the reporter_config/report_template change,
and include and commit those resulting files (the updated generated CI
job/config diffs) alongside this ci-operator/config change so downstream
artifacts remain in sync.
| reporter_config: | ||
| channel: '#tektoncd-pipeline-ci' | ||
| job_states_to_report: | ||
| - success | ||
| - failure | ||
| - error | ||
| report_template: '{{if eq .Status.State "success"}} :slack-green: Job *{{.Spec.Job}}* | ||
| ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs> {{else}} :failed: | ||
| Job *{{.Spec.Job}}* ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs> | ||
| {{end}}' |
There was a problem hiding this comment.
Run make update for this CI config change before merge.
This PR modifies files under ci-operator/config/, but the required downstream artifact regeneration is not shown in the provided changes. Please run make update and include any generated updates.
As per coding guidelines, "After modifying CI configuration files in ci-operator/config/, regenerate downstream artifacts by running make update."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift-pipelines/release-tests/openshift-pipelines-release-tests-release-v1.15__openshift-pipelines-ocp4.16-lp-rosa-hypershift.yaml`
around lines 44 - 53, You changed the CI reporter settings (see reporter_config
and report_template) but didn't regenerate downstream artifacts; run the
repository's generation step (execute make update) to regenerate CI artifacts,
commit the updated generated files produced by that command, and push those
changes so the CI config change under ci-operator/config is accompanied by the
corresponding generated outputs.
| - as: aws-fips | ||
| cron: 0 23 31 2 * | ||
| reporter_config: | ||
| channel: '#cnv-release-4-22-z' |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Compare channel assignments for closely-related 4.22/4.23 interop configs.
fd -a 'RedHatQE-interop-testing-master__cnv-odf-ocp-4\.2[23]-lp-interop\.yaml$' ci-operator/config/RedHatQE/interop-testing \
| xargs -r rg -n -C2 'variant:|as: aws-fips|channel:'Repository: openshift/release
Length of output: 3578
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Look for all channel assignments in 4.23-related configs to see if there's a pattern
fd -a 'cnv-odf-ocp-4\.23' ci-operator/config/RedHatQE/interop-testing \
| xargs -r rg -n 'channel:'
# Also search for any references to 4-23-z channel in the entire codebase
rg -n 'cnv-release-4-23-z' ci-operator/config/Repository: openshift/release
Length of output: 99
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Look at channel assignments in other cnv configs to see if there's a versioning pattern
rg -n 'channel:.*cnv-release' ci-operator/config/RedHatQE/interop-testing | sort -u
# Also check if 4.22 was recently copied to create 4.23
fd -a 'cnv-odf-ocp-4\.2[0-9]-lp-interop\.yaml$' ci-operator/config/RedHatQE/interop-testing | sortRepository: openshift/release
Length of output: 1785
Update the Slack channel to match the 4.23 version.
Line 81 uses #cnv-release-4-22-z, but the pattern across all cnv-odf-ocp configs shows each version uses its corresponding channel (4.19→4-19-z, 4.20→4-20-z, 4.21→4-21-z, 4.22→4-22-z). The 4.23 config should use #cnv-release-4-23-z to align with the established versioning pattern and ensure notifications route correctly.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/RedHatQE/interop-testing/RedHatQE-interop-testing-master__cnv-odf-ocp-4.23-lp-interop.yaml`
at line 81, The YAML channel value is set to '`#cnv-release-4-22-z`' but should
match the 4.23 release; update the channel key in this cnv-odf-ocp-4.23 config
by replacing the current value '`#cnv-release-4-22-z`' with '`#cnv-release-4-23-z`'
so notifications align with the 4.23 versioning pattern.
|
/lgtm |
|
/pj-rehearse ack |
|
@Prucek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest-required |
|
@Prucek: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
This PR systematically adds Slack reporting configuration to test job definitions across the OpenShift CI infrastructure by introducing
reporter_configblocks to ci-operator configuration files. The changes implement a standardized approach to propagate reporter settings from Prow jobs into the central ci-operator config, enabling consistent automated notifications of test results.Changes
The PR updates 65 ci-operator configuration files across numerous OpenShift ecosystem projects. Each modification adds a
reporter_configsection to selected test jobs with:#tektoncd-pipeline-ci,#odf-ocp-ci-results,#team-network-observability)success,failure,error, and occasionallyaborted).Status.URLand job identifiers via.Spec.JobAffected Components
Changes span 19+ projects including:
Impact
This standardization ensures comprehensive Slack visibility into CI test execution across the release infrastructure, replacing manual status checks with automated notifications. All changes are configuration-only additions with no modifications to test logic or existing fields.
Total lines changed: ~500 additions across all files