Skip to content

prowgen: migrate last .config.prowgen files to ci-operator config#79505

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
Prucek:deprecate-last-prowgen-configs
May 20, 2026
Merged

prowgen: migrate last .config.prowgen files to ci-operator config#79505
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
Prucek:deprecate-last-prowgen-configs

Conversation

@Prucek
Copy link
Copy Markdown
Member

@Prucek Prucek commented May 20, 2026

Summary

  • Migrates the last 2 remaining .config.prowgen sidecar files to ci-operator config fields
  • openshift/hypershift: moves slack_reporter into per-test reporter_config on e2e-aws-ovn-conformance-ccm and e2e-aws-ovn-conformance-ccm-techpreview tests
  • stolostron/acm-config: moves private: true / expose: true into prowgen: block

Test plan

  • make update passes
  • Zero diff in generated jobs before/after migration

🤖 Generated with Claude Code

Summary

This PR completes the migration of the last remaining .config.prowgen sidecar configuration files to their corresponding ci-operator config fields, eliminating the need for separate prowgen configuration files.

Changes

openshift/hypershift: Migrates Slack reporting configuration for AWS OVN conformance CCM tests by moving the slack_reporter block from .config.prowgen into per-test reporter_config blocks in the job definitions. This affects two monthly release jobs (e2e-aws-ovn-conformance-ccm and e2e-aws-ovn-conformance-ccm-techpreview) in both the 4.23 and 5.0 release branches. The reporting behavior remains identical—failures and errors are reported to the #forum-ocp-splat-alerts-aws Slack channel with the same templated message format.

stolostron/acm-config: Migrates the private and expose workflow settings from .config.prowgen into a prowgen configuration block within the workflow YAML file itself.

Validation

Per the test plan:

  • make update passes
  • Zero diff in generated Prow jobs before and after the migration, confirming behavioral equivalence

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0ddd4c42-acd6-4ab2-83ec-1253e113843f

📥 Commits

Reviewing files that changed from the base of the PR and between 49ee15c and 77e76cb.

📒 Files selected for processing (5)
  • ci-operator/config/openshift/hypershift/.config.prowgen
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.23__periodics.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0.yaml
  • ci-operator/config/stolostron/acm-config/.config.prowgen
  • ci-operator/config/stolostron/acm-config/stolostron-acm-config-main.yaml
💤 Files with no reviewable changes (2)
  • ci-operator/config/stolostron/acm-config/.config.prowgen
  • ci-operator/config/openshift/hypershift/.config.prowgen

Walkthrough

This PR updates CI configuration for two separate projects. HyperShift receives reporter configuration additions for AWS OVN conformance test jobs across release versions 4.23 and 5.0, directing failure and error notifications to a Slack channel with templated messages. ACM-config moves its prowgen settings from a dedicated configuration file into the workflow YAML itself.

Changes

HyperShift conformance job reporting

Layer / File(s) Summary
AWS OVN conformance job reporter configuration
ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.23__periodics.yaml, ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0.yaml
Adds reporter_config blocks to e2e-aws-ovn-conformance-ccm and e2e-aws-ovn-conformance-ccm-techpreview jobs in both 4.23 and 5.0 release streams, configuring Slack notifications for job failures and errors with templated messages including logs and history links.

ACM-config prowgen configuration migration

Layer / File(s) Summary
Prowgen settings inline configuration
ci-operator/config/stolostron/acm-config/stolostron-acm-config-main.yaml
Adds a prowgen configuration section directly in the workflow YAML with expose: true and private: true settings.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

lgtm, approved, rehearsals-ack

Suggested reviewers

  • deepsm007
  • mtodor
  • janisz
🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: migrating .config.prowgen files to ci-operator config, which aligns with all modified files in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains only CI/CD YAML configuration changes (prowgen and reporter_config migration), not Ginkgo test code. No test names to evaluate.
Test Structure And Quality ✅ Passed Check is not applicable: PR contains only CI operator configuration files (YAML), not Ginkgo test code. Check targets test structure quality (BeforeEach/AfterEach, timeouts, assertions).
Microshift Test Compatibility ✅ Passed PR contains only CI configuration changes (YAML) in ci-operator/config; no new Ginkgo e2e tests added. Check not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR contains no new Ginkgo e2e tests; it only migrates CI/Prowgen configuration. The SNO compatibility check applies only to new test code additions.
Topology-Aware Scheduling Compatibility ✅ Passed PR contains only CI/Prow configuration changes; no deployment manifests, operator code, or controllers are modified. Topology-aware scheduling check does not apply.
Ote Binary Stdout Contract ✅ Passed PR only modifies configuration files (YAML and .config.prowgen) with no source code changes. OTE binary stdout contract check is inapplicable as there are no test binaries or logging code modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only migrates job configuration (YAML), not new Ginkgo test code. No Ginkgo tests (It, Describe, Context, When) are added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from dhaiducek and jparrill May 20, 2026 08:00
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Prucek: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-aws-ovn-conformance-ccm N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-aws-ovn-conformance-ccm-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-e2e-aws-ovn-conformance-ccm N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-e2e-aws-ovn-conformance-ccm-techpreview N/A periodic Ci-operator config changed
periodic-ci-stolostron-acm-config-main-fast-forward N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

@Prucek: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danilo-gemoli
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, Prucek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Prucek
Copy link
Copy Markdown
Member Author

Prucek commented May 20, 2026

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@Prucek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 20, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 285c896 into openshift:main May 20, 2026
14 checks passed
wgahnagl pushed a commit to wgahnagl/release that referenced this pull request May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants