setup assisted-installer version v2.53#79507
Conversation
WalkthroughThis PR adds four parallel CI operator configuration files for the OpenShift Assisted Installer ecosystem, all versioned for v2.53. Each file defines build roots, base images, promotion targets to v2.53, OCP 4.22 nightly releases, resource requests, and corresponding test job matrices including lint, unit tests, and multiple e2e scenarios. ChangesAssisted Installer v2.53 Release CI Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
A total of 53 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse ack |
|
@pastequo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/retest |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.53.yaml (1)
104-104: ⚡ Quick winConsider aligning
subsystem-awsclaim version with the 4.22 release target.Line 104 pins
cluster_claim.versionto4.15while this config otherwise targets 4.22, which can make subsystem coverage less representative for this branch. If intentional, add a short note; otherwise align it.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.53.yaml` at line 104, The cluster_claim.version is set to "4.15" while the rest of this config targets 4.22; update the subsystem-aws claim to match by changing cluster_claim.version from "4.15" to "4.22" (or, if the 4.15 pin is intentional, add a short inline comment next to cluster_claim.version explaining the reason for the divergence); locate the key named cluster_claim.version and either replace the value or add the explanatory note accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.53.yaml`:
- Around line 125-127: The three image variables AGENT_DOCKER_IMAGE,
CONTROLLER_IMAGE, and INSTALLER_IMAGE are using mutable :latest tags; change
each to an immutable reference (either the v2.53 tag or an image digest) so the
job is reproducible—replace the :latest suffix with the explicit v2.53 tag (or
`@sha256`:<digest>) for each variable and verify the registry path and tag/digest
match the intended v2.53 artifacts for ARM worker images.
---
Nitpick comments:
In
`@ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.53.yaml`:
- Line 104: The cluster_claim.version is set to "4.15" while the rest of this
config targets 4.22; update the subsystem-aws claim to match by changing
cluster_claim.version from "4.15" to "4.22" (or, if the 4.15 pin is intentional,
add a short inline comment next to cluster_claim.version explaining the reason
for the divergence); locate the key named cluster_claim.version and either
replace the value or add the explanatory note accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 6a8d60df-c345-4902-9b5d-1f8ba43a3e22
⛔ Files ignored due to path filters (8)
ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.53-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.53-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.53-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.53-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.53-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.53-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.53-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.53-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (4)
ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.53.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.53.yamlci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.53.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.53.yaml
| AGENT_DOCKER_IMAGE=quay.io/redhat-user-workloads/assisted-installer-tenant/assisted-installer-application-ds-main/assisted-installer-agent-ds-main:latest | ||
| CONTROLLER_IMAGE=quay.io/redhat-user-workloads/assisted-installer-tenant/assisted-installer-application-ds-main/assisted-installer-controller-ds-main:latest | ||
| INSTALLER_IMAGE=quay.io/redhat-user-workloads/assisted-installer-tenant/assisted-installer-application-ds-main/assisted-installer-ds-main:latest |
There was a problem hiding this comment.
Pin the day2 ARM worker images to immutable refs (not :latest).
Line 125–127 use mutable :latest tags, so this job can silently test code outside v2.53 and produce non-reproducible results. Please pin to the intended v2.53 tag or digest.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.53.yaml`
around lines 125 - 127, The three image variables AGENT_DOCKER_IMAGE,
CONTROLLER_IMAGE, and INSTALLER_IMAGE are using mutable :latest tags; change
each to an immutable reference (either the v2.53 tag or an image digest) so the
job is reproducible—replace the :latest suffix with the explicit v2.53 tag (or
`@sha256`:<digest>) for each variable and verify the registry path and tag/digest
match the intended v2.53 artifacts for ARM worker images.
|
/pj-rehearse ack |
|
@andrej1991: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrej1991, pastequo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
@pastequo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Co-authored-by: pastequo <infrastructure-operator@redhat.com>
3 participants
This PR establishes CI/operator infrastructure for the assisted-installer v2.53 release by adding CI configuration files for four OpenShift assisted-installer ecosystem components:
Affected Components:
openshift/assisted-image-serviceopenshift/assisted-installer-agentopenshift/assisted-installeropenshift/assisted-serviceWhat's Being Configured:
Each component receives a new CI-operator configuration file that defines:
Base Image Pinning: All components pin their build base images and dependencies to v2.53 (cross-referencing other v2.53 assisted components), with OpenShift nightly release candidates locked to version 4.22.
Build and Promotion Targets: Defines image build outputs and sets promotion rules to publish built images to the
v2.53release target inedge-infrastructure.Test Workflows: Each configuration includes a comprehensive test suite covering:
Resource Configuration: Sets default resource requests (100m CPU, 200Mi memory) for test execution.
Parameterized Test Environments: Test jobs use environment variable configurations (
ASSISTED_CONFIG) to inject version-specific settings likeSERVICE_BASE_REF=v2.53andOPENSHIFT_VERSION=4.22.Net Effect: This enables the OpenShift CI infrastructure to automatically build, test, and promote container images for all four assisted-installer components at the v2.53 release level, with integrated testing against OCP 4.22 nightly builds.
Total additions: ~955 lines of CI configuration across the four files.