Skip to content

remove the duplicated volume entries in the slack bot deployment#79530

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
droslean:slack-bot-dedup
May 20, 2026
Merged

remove the duplicated volume entries in the slack bot deployment#79530
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
droslean:slack-bot-dedup

Conversation

@droslean
Copy link
Copy Markdown
Member

@droslean droslean commented May 20, 2026

Deduplication of slack-bot deployment volumes

Removes redundant PagerDuty configuration entries from the slack-bot Deployment manifest in the app.ci cluster. Specifically eliminates:

  • The container argument referencing the PagerDuty token file (--pager-duty-token-file=/etc/pagerduty/token)
  • The corresponding pagerduty volumeMount definition
  • The pagerduty Secret volume source definition

This cleans up duplicate/unused volume declarations in the deployment configuration, reducing unnecessary resource references in the slack bot service deployed on the OpenShift CI infrastructure's app.ci cluster.

Signed-off-by: Nikolaos Moraitis <nmoraiti@redhat.com>
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 20, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@droslean: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c34abe58-a5f4-4047-ba6a-6994a558f3c2

📥 Commits

Reviewing files that changed from the base of the PR and between eb7b925 and f582f72.

📒 Files selected for processing (1)
  • clusters/app.ci/assets/slack-bot.yaml
💤 Files with no reviewable changes (1)
  • clusters/app.ci/assets/slack-bot.yaml

Walkthrough

The pull request removes all PagerDuty-related configuration from the slack-bot Kubernetes Deployment manifest in a single, coordinated change: the container argument that references the PagerDuty token file is deleted, the corresponding volumeMount is removed, and the underlying pagerduty Secret volume is removed.

Changes

PagerDuty Configuration Removal

Layer / File(s) Summary
Remove PagerDuty integration from Slack bot Deployment
clusters/app.ci/assets/slack-bot.yaml
Container args no longer include the PagerDuty token file flag; the volumeMounts section removes the pagerduty mount point; the volumes section removes the pagerduty Secret volume definition. Surrounding mounts and resource configurations remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title describes removing duplicated volume entries, but the actual changes involve removing PagerDuty-related configuration entirely, not deduplicating existing entries. Revise the title to accurately reflect the main change, such as 'Remove PagerDuty configuration from slack-bot deployment' or similar.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only a Kubernetes manifest file (slack-bot.yaml), not Ginkgo tests. The custom check for stable test names is not applicable.
Test Structure And Quality ✅ Passed The custom check requires reviewing Ginkgo test code for quality requirements, but this PR only modifies a Kubernetes manifest file (slack-bot.yaml) with no test code changes.
Microshift Test Compatibility ✅ Passed PR modifies only a Kubernetes manifest file (slack-bot.yaml), not Ginkgo e2e tests. No test code was added, so MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No Ginkgo e2e tests added in this PR. Changes are to a Kubernetes manifest file (slack-bot.yaml), not test code. SNO compatibility check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR removes unused PagerDuty config from slack-bot deployment. No scheduling constraints introduced or modified. Existing affinity is soft/preferred and topology-agnostic.
Ote Binary Stdout Contract ✅ Passed Custom check is not applicable—this PR modifies only a Kubernetes manifest YAML file with no executable code, test frameworks, or stdout operations.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only a Kubernetes manifest (slack-bot.yaml) to remove PagerDuty config; no Ginkgo e2e tests are added. Check is not applicable to non-test configuration files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2026
@openshift-ci openshift-ci Bot requested review from deepsm007 and hector-vido May 20, 2026 12:22
@bear-redhat
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bear-redhat, droslean

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

@droslean: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit fc70660 into openshift:main May 20, 2026
8 checks passed
@droslean droslean deleted the slack-bot-dedup branch May 20, 2026 12:51
wgahnagl pushed a commit to wgahnagl/release that referenced this pull request May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants