Update ROSA CI daily status bot with separate E2E category links#79552
Conversation
WalkthroughThe CI operator ROSA E2E main config updates the ChangesROSA E2E CI reporting configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5 | ❌ 7❌ Failed checks (7 inconclusive)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
b7bf5bb to
6277a5a
Compare
Split the single ROSA E2E Prow filter link into three separate links (ROSA HCP E2E, ROSA STS E2E, OSD GCP E2E) so each category is individually navigable from the daily Slack status message.
6277a5a to
8ded313
Compare
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
1 similar comment
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml (1)
83-83: 💤 Low valueConsider aligning the label with the job pattern naming.
The second link uses the label "ROSA STS E2E" but the job pattern contains
rosa-classic-sts-e2e. Consider whether the label should be "ROSA Classic STS E2E" for clarity, or confirm that "STS" alone is the preferred shorthand.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml` at line 83, The label "ROSA STS E2E" in the markdown line should match the job pattern naming for clarity; update the label text that follows the job pattern containing `rosa-classic-sts-e2e` to either "ROSA Classic STS E2E" or another agreed shorthand, ensuring the visible label (currently "ROSA STS E2E") accurately reflects the job pattern `rosa-classic-sts-e2e` used in that link.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml`:
- Line 83: The label "ROSA STS E2E" in the markdown line should match the job
pattern naming for clarity; update the label text that follows the job pattern
containing `rosa-classic-sts-e2e` to either "ROSA Classic STS E2E" or another
agreed shorthand, ensuring the visible label (currently "ROSA STS E2E")
accurately reflects the job pattern `rosa-classic-sts-e2e` used in that link.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 2051b230-9a2f-4618-a641-e4b11f965d78
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml
|
@dustman9000: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustman9000, jfrazierRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Test plan
make jobsregeneration matchesSummary
This PR updates the ROSA CI daily Slack status report to split the previous single "ROSA E2E" periodic filter into three distinct Prow filter links, improving navigability and signal for each test category.
Change details:
Impact:
#wg-rosa-ci-enhancement) can now jump directly to job sets for HCP, Classic STS, or GCP, reducing noise from a broad wildcard and improving visibility into category-specific test health.Testing:
make jobsand verify the Prow filter links resolve to the intended job sets.