Downsize GCP ARM Compute Instances#79564
Open
patrickdillon wants to merge 1 commit into
Open
Conversation
We're hitting capacity exhaustion issues (GCP does not have enough ARM machines for us) causing nightlies to fail. This drops compute nodes to the minimum requirement size, which is a much more readily available instance size.
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
WalkthroughThis PR downsizes GCP compute resources across OpenShift multiarch nightly CI configurations by uniformly changing machine types from ChangesGCP Machine Type Downsizing
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5 | ❌ 7❌ Failed checks (7 inconclusive)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
[REHEARSALNOTIFIER]
A total of 29 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.20-upgrade-from-nightly-4.19.yaml`:
- Line 94: You changed the CI config value COMPUTE_NODE_TYPE in the
openshift-multiarch-main__nightly-4.20-upgrade-from-nightly-4.19.yaml but did
not regenerate downstream artifacts; run the repository's generation step (make
update) to produce updated files derived from ci-operator/config/**/*.yaml and
commit those generated artifacts alongside this change so downstream configs,
job definitions, and any generated manifests reflect the new COMPUTE_NODE_TYPE.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 2c6d1418-874e-4679-ad34-3976c0fb79eb
📒 Files selected for processing (14)
ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.20-upgrade-from-nightly-4.19.yamlci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.20-upgrade-from-stable-4.19.yamlci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.21-upgrade-from-nightly-4.20.yamlci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.21-upgrade-from-stable-4.20.yamlci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.21.yamlci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.22-upgrade-from-nightly-4.21.yamlci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.22-upgrade-from-stable-4.21.yamlci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.22.yamlci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.23-upgrade-from-nightly-4.22.yamlci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.23-upgrade-from-stable-4.22.yamlci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.23.yamlci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-5.0-upgrade-from-nightly-4.22.yamlci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-5.0-upgrade-from-stable-4.22.yamlci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-5.0.yaml
Member
|
/pj-rehearse |
Contributor
|
@tthvo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Member
|
/pj-rehearse more |
Contributor
|
@tthvo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're hitting capacity exhaustion issues (GCP does not have enough ARM machines for us) causing nightlies to fail. This drops compute nodes to the minimum requirement size, which is a much more readily available instance size.
The 4.20 nightly is already using this type:
release/ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.20.yaml
Line 672 in d4371cb