Update chainsaw command to match kuttl capabilities#79648
Conversation
Update the shell script that triggers chainsaw tests for the
openstack-k8s-operators:
- Fixes the location of the test directory, which has now moved
from 'tests' to 'test'
- Add missing features which have been implemented in the equivalent
kuttl shell script (e.g. depends-on, deployment wait...)
Signed-off-by: Damien Ciabrini <dciabrin@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughA single CI operator script for OpenStack-K8s-Operators chainsaw testing now detects and checks out dependent ChangesChainsaw CI Script Improvements
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@lmiccini: changing LGTM is restricted to collaborators DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/pj-rehearse pull-ci-openstack-k8s-operators-mariadb-operator-main-mariadb-operator-build-deploy-chainsaw |
|
@lmiccini: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest |
|
/pj-rehearse pull-ci-openstack-k8s-operators-mariadb-operator-main-mariadb-operator-build-deploy-chainsaw |
|
@lmiccini: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openstack-k8s-operators-mariadb-operator-main-mariadb-operator-build-deploy-chainsaw |
|
@lmiccini: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openstack-k8s-operators-mariadb-operator-main-mariadb-operator-build-deploy-chainsaw |
|
@lmiccini: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openstack-k8s-operators-mariadb-operator-main-mariadb-operator-build-deploy-chainsaw |
|
@lmiccini: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openstack-k8s-operators-mariadb-operator-main-mariadb-operator-build-deploy-chainsaw |
|
@lmiccini: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openstack-k8s-operators-mariadb-operator-main-mariadb-operator-build-deploy-chainsaw |
|
@dciabrin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
| PR_BODY=$(curl -s -X GET \ | ||
| -H "Accept: application/vnd.github+json" \ | ||
| -H "X-GitHub-Api-Version: 2022-11-28" \ | ||
| https://api.github.com/repos/${REF_ORG}/${REF_REPO}/pulls/${PR_NUMBER} | | ||
| jq -r '.body') |
There was a problem hiding this comment.
Since we're not authenticating here, are we at all worried about rate-limiting? Not a blocking issue, just want to get your opinion.
There was a problem hiding this comment.
Good point. I don't think this is an immediate concern, at least for chainsaw tests, because they are only available for the mariadb-operator.
That being said, I mimicked what we have in https://github.com/openshift/release/blob/main/ci-operator/step-registry/openstack-k8s-operators/kuttl/openstack-k8s-operators-kuttl-commands.sh for feature-parity, so we might want to think about this one as kuttl tests is used by a lot of operators.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, dciabrin, lmiccini The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse ack |
|
@abays: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/test ci/prow/ci-operator-registry |
|
/test release-controller-config |
|
/test pull-ci-openshift-release-main-ci-operator-registry |
|
/test ci-operator-registry |
|
@dciabrin: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@abays: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
3 participants
Update the shell script that triggers chainsaw tests for the openstack-k8s-operators:
Fixes the location of the test directory, which has now moved from 'tests' to 'test'
Add missing features which have been implemented in the equivalent kuttl shell script (e.g. depends-on, deployment wait...)
Summary by CodeRabbit
This PR updates the Chainsaw test step script for OpenStack K8s operators' CI pipeline to align with the kuttl test runner's capabilities and fix recent directory structure changes.
Practical Changes
Test Directory Structure Update: The script now references the correct test configuration paths, which have been reorganized from
tests/chainsawtotest/chainsaw(singular directory). This affects how the CI system locates chainsaw configuration files (config.yaml) and test definitions.PR Dependency Handling: The script now queries GitHub to check if the PR description includes a
depends-on ... install_yamlsreference. If found, it automatically fetches and checks out the matching install_yamls PR, allowing component tests to coordinate with supporting infrastructure changes.Per-Service Test Reporting: Chainsaw reports are now named per-operator (
chainsaw-report-${SERVICE_NAME}.json) instead of using a genericchainsaw-report.json, which better supports CI artifact collection and analysis across multiple services.Improved OpenStack Deployment Testing: When testing the openstack-operator specifically, the script now:
quay.io/openstack-k8s-operators/openstack-operator-index:18.0-fr2-latest) for initial deployment instead of the build artifactopenstackcontrolplanereadiness using label selectorcore.openstack.org/openstackcontrolplanebefore proceedingThese changes enhance test stability and reliability by ensuring proper orchestration between operator deployments and test execution, particularly for upgrade scenarios.