bump CI images version that were out of sync#79697
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (2)
WalkthroughThis PR updates OpenShift version references in metallb-operator CI test configurations across four files. Each file's test ChangesCI Test Configuration Version Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
🚥 Pre-merge checks | ✅ 11 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yahlifried The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/metallb-operator/openshift-metallb-operator-release-4.22.yaml`:
- Line 71: The downstream ProwJob artifacts weren’t regenerated after changing
ci-operator/config/openshift/metallb-operator/openshift-metallb-operator-release-4.22.yaml;
run make update in the repo root to regenerate
ci-operator/jobs/openshift/metallb-operator/, verify changes with git diff
--name-only origin/main -- ci-operator/jobs/openshift/metallb-operator/, and
commit the updated job YAMLs so the job artifacts reflect the version bump.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 5c3e2e2f-ebf0-442c-bb37-ecfb756cfadb
📒 Files selected for processing (4)
ci-operator/config/openshift/metallb-operator/openshift-metallb-operator-main.yamlci-operator/config/openshift/metallb-operator/openshift-metallb-operator-release-4.18.yamlci-operator/config/openshift/metallb-operator/openshift-metallb-operator-release-4.21.yamlci-operator/config/openshift/metallb-operator/openshift-metallb-operator-release-4.22.yaml
| product: ocp | ||
| timeout: 1h0m0s | ||
| version: "4.20" | ||
| version: "4.22" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check if ProwJob artifacts were regenerated after config changes
echo "=== Checking for corresponding ProwJob updates ==="
# Check if job files exist and were modified for metallb-operator
fd -t f 'openshift-metallb-operator.*\.yaml' ci-operator/jobs/openshift/metallb-operator/ --exec echo "Found: {}"
echo ""
echo "=== Checking git diff for ci-operator/jobs changes ==="
git diff --name-only origin/main -- ci-operator/jobs/openshift/metallb-operator/
echo ""
echo "If no job files are shown above, make update may not have been run."Repository: openshift/release
Length of output: 4191
Regenerate downstream ProwJob artifacts via make update
After the CI config change in ci-operator/config/openshift/metallb-operator/openshift-metallb-operator-release-4.22.yaml, git diff --name-only origin/main -- ci-operator/jobs/openshift/metallb-operator/ shows no updated job YAMLs, indicating make update didn’t regenerate downstream artifacts. Run make update and commit the resulting ci-operator/jobs/openshift/metallb-operator/ changes.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/metallb-operator/openshift-metallb-operator-release-4.22.yaml`
at line 71, The downstream ProwJob artifacts weren’t regenerated after changing
ci-operator/config/openshift/metallb-operator/openshift-metallb-operator-release-4.22.yaml;
run make update in the repo root to regenerate
ci-operator/jobs/openshift/metallb-operator/, verify changes with git diff
--name-only origin/main -- ci-operator/jobs/openshift/metallb-operator/, and
commit the updated job YAMLs so the job artifacts reflect the version bump.
|
this repo is larget repo, it worth making the commit/PR title specific to which component (metallb-operator)
|
Bumped yamls for 4.21, 4.22, 4.18 and main. all other unsynced version follows main. Signed-off-by: yahlifried <yfriedla@redhat.com>
yahlifried
force-pushed
the
bump-metallb-operator-ci
branch
from
4dd0553 to
4699648
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse |
|
@yahlifried: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@yahlifried: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Bumped yamls for 4.21, 4.22, 4.18 and main. all other unsynced version follows main.
Summary by CodeRabbit
This PR updates OpenShift CI configuration for the metallb-operator repository to synchronize CI test and release version metadata with their target OpenShift branches. Practically, it ensures the operator-e2e job and release integration versions run against the correct OpenShift releases:
ci-operator/config/openshift/metallb-operator/openshift-metallb-operator-main.yaml
ci-operator/config/openshift/metallb-operator/openshift-metallb-operator-release-4.22.yaml
ci-operator/config/openshift/metallb-operator/openshift-metallb-operator-release-4.21.yaml
ci-operator/config/openshift/metallb-operator/openshift-metallb-operator-release-4.18.yaml
All changes are limited to CI YAML metadata (version fields for operator-e2e and release integration) so the operator's CI pipeline will run against the intended OpenShift release versions.