Skip to content

OSAC-360: Update Go version in fulfillment service config#79713

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
adriengentil:patch-8
May 26, 2026
Merged

OSAC-360: Update Go version in fulfillment service config#79713
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
adriengentil:patch-8

Conversation

@adriengentil
Copy link
Copy Markdown
Contributor

@adriengentil adriengentil commented May 26, 2026

Summary by CodeRabbit

This PR updates the Go build environment for the OSAC Project's fulfillment-service CI configuration. Specifically, it updates the build_root image stream tag used by the CI system to build the fulfillment-service component:

  • Go version: Updated from 1.25 to 1.26
  • OpenShift target version: Updated from 4.21 to 5.0

The change modifies a single configuration file (osac-project-fulfillment-service-main.yaml) that defines the CI pipeline for this service. The build_root image is the base container used by the CI system to compile and build the fulfillment-service, so this update ensures the component is built with the newer Go toolchain and against the updated OpenShift release stream.

The PR references OSAC-360 but lacks a proper target version specification in the corresponding Jira issue, as noted by the OpenShift CI automation.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 26, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 26, 2026

@adriengentil: This pull request references OSAC-360 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 4242d82d-bb22-4d51-8922-2585d58613d0

📥 Commits

Reviewing files that changed from the base of the PR and between 9a0b5ca and 1a190c9.

📒 Files selected for processing (1)
  • ci-operator/config/osac-project/fulfillment-service/osac-project-fulfillment-service-main.yaml

Walkthrough

Updated the build root image stream tag in CI configuration from Go 1.25 / OpenShift 4.21 to Go 1.26 / OpenShift 5.0. No other build configuration or test workflows were modified.

Changes

Build Image Configuration

Layer / File(s) Summary
Build root image stream tag upgrade
ci-operator/config/osac-project/fulfillment-service/osac-project-fulfillment-service-main.yaml
Build root image stream tag updated to use RHEL 9 release with Go 1.26 and OpenShift 5.0 instead of Go 1.25 and OpenShift 4.21.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • openshift/release#79318: Both PRs update build_root.image_stream_tag to different RHEL 9 Golang release image tags in OpenShift pipeline YAMLs.
  • openshift/release#79494: Both PRs modify build_root.image_stream_tag to bump the Go release artifact image version.

Suggested labels

lgtm, approved, rehearsals-ack

Suggested reviewers

  • bparees
  • tisnik
  • mshort55
🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: updating the Go version in the fulfillment service configuration, which directly matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains no Ginkgo tests. All Go test files use standard Go testing (func Test*). The Ginkgo test names check is not applicable.
Test Structure And Quality ✅ Passed PR modifies only YAML CI/CD configuration, not Ginkgo test code. The custom check for Ginkgo test quality is not applicable to this YAML configuration change.
Microshift Test Compatibility ✅ Passed PR changes only the build_root.image_stream_tag in a YAML CI configuration file; no new Ginkgo e2e tests are added, making the MicroShift compatibility check not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only updates Go version in a YAML configuration file. No new Ginkgo e2e tests (It(), Describe(), Context(), etc.) are added, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR changes only a CI build configuration (Go version in build_root.image_stream_tag), not deployment manifests, operator code, or controllers. No scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR only modifies YAML CI/CD configuration (Go version/tag), not executable code. OTE Stdout Contract check applies to code execution contexts, not configuration metadata.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies CI config (image_stream_tag), not Ginkgo e2e tests. No new tests added; check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@adriengentil
Copy link
Copy Markdown
Contributor Author

/cc @omer-vishlitzky

@openshift-ci openshift-ci Bot requested a review from omer-vishlitzky May 26, 2026 13:56
@adriengentil
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@adriengentil: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2026
@openshift-ci openshift-ci Bot requested review from akshaynadkarni and trewest May 26, 2026 13:57
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@adriengentil: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-osac-project-fulfillment-service-main-e2e-vmaas osac-project/fulfillment-service presubmit Ci-operator config changed
pull-ci-osac-project-fulfillment-service-main-images osac-project/fulfillment-service presubmit Ci-operator config changed
pull-ci-osac-project-fulfillment-service-main-unit osac-project/fulfillment-service presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@omer-vishlitzky
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, omer-vishlitzky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 26, 2026

@adriengentil: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@adriengentil
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@adriengentil: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 26, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit e8c47e3 into openshift:main May 26, 2026
17 checks passed
oharan2 pushed a commit to oharan2/release that referenced this pull request May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants