[NVIDIA-859] Precompiled signed drivers support#79757
Conversation
Signed-off-by: Jose Castillo Lema <josecastillolema@gmail.com>
WalkthroughThis PR updates a single CI configuration file to introduce a new signed-driver test job. It adds a release selector for signed-driver with narrowed version bounds, renames an existing test job to reference this release, and configures the job with GPU driver environment variables including precompiled artifact settings and subscription channel specifications. ChangesSigned-driver test job setup
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/rh-ecosystem-edge/nvidia-ci/rh-ecosystem-edge-nvidia-ci-main__4.21-stable.yaml`:
- Around line 163-167: The NVIDIAGPU_GPU_CLUSTER_POLICY_PATCH currently points
to a non-public Quay image tag
(quay.io/jcastillolema/gpu-driver-rhel9:580.159.03) which CI cannot discover;
update the patch value used by NVIDIAGPU_GPU_CLUSTER_POLICY_PATCH to reference a
publicly accessible/official driver repository and tag (or replace with a known
public mirror) or coordinate to publish the specified tag so it is pullable by
CI; modify the string value inside NVIDIAGPU_GPU_CLUSTER_POLICY_PATCH in the
YAML (the JSON patch entries for /spec/driver/repository, /spec/driver/image,
/spec/driver/version) to the public repository, image and tag that are reachable
by CI.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 33c15f19-f485-4b40-95df-d6ae606c8d17
⛔ Files ignored due to path filters (1)
ci-operator/jobs/rh-ecosystem-edge/nvidia-ci/rh-ecosystem-edge-nvidia-ci-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/rh-ecosystem-edge/nvidia-ci/rh-ecosystem-edge-nvidia-ci-main__4.21-stable.yaml
|
/pj-rehearse pull-ci-rh-ecosystem-edge-nvidia-ci-main-4.21-stable-nvidia-gpu-operator-signed-driver |
|
@josecastillolema: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-rh-ecosystem-edge-nvidia-ci-main-4.21-stable-nvidia-gpu-operator-signed-driver |
|
@josecastillolema: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@josecastillolema: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Looks like it worked fine:
|
|
cc @ShiraEzra |
|
Nice! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: empovit, josecastillolema The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@josecastillolema: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
This is intentionally very hardcoded regarding versions because the available image tags in registry.stage.redhat.io use either:
rhcos4.20(OpenShift version-based)rhel9_6(with underscore, not dot)When this gets fixed we will move this test to that registry instead cc @enriquebelarte