Skip to content

Revert "Add resource limits for CPU and memory (#79706)"#79771

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
sosiouxme:20260527-revert-ctm-limits
May 27, 2026
Merged

Revert "Add resource limits for CPU and memory (#79706)"#79771
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
sosiouxme:20260527-revert-ctm-limits

Conversation

@sosiouxme
Copy link
Copy Markdown
Member

This reverts commit 9a0b5ca which added limits on ci-test-mapping jobs. I'll add appropriate limits after I address the real memory problems from the jobs -- right now they are making it impossible for anything to pass.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: ccdc949a-1a84-46e0-8fed-6b0040aa2661

📥 Commits

Reviewing files that changed from the base of the PR and between 09e9bdf and c7c6c3f.

📒 Files selected for processing (1)
  • ci-operator/config/openshift-eng/ci-test-mapping/openshift-eng-ci-test-mapping-main.yaml
💤 Files with no reviewable changes (1)
  • ci-operator/config/openshift-eng/ci-test-mapping/openshift-eng-ci-test-mapping-main.yaml

Walkthrough

This PR updates the OpenShift CI test mapping configuration to change resource specifications from Kubernetes limits to requests. The CPU and memory values (100m and 200Mi respectively) remain unchanged; only the allocation type is modified.

Changes

Resource Request Configuration

Layer / File(s) Summary
CPU/Memory request specification
ci-operator/config/openshift-eng/ci-test-mapping/openshift-eng-ci-test-mapping-main.yaml
Resource specification changed from limits to requests for per-project resource allocation, keeping CPU at 100m and memory at 200Mi.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: reverting a commit that added resource limits for CPU and memory.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains only YAML CI configuration changes, no Ginkgo test files. The check for stable Ginkgo test names is not applicable to this PR.
Test Structure And Quality ✅ Passed This PR reverts resource limits in a CI configuration YAML file; it contains no Ginkgo test code, so the check for test structure and quality is not applicable.
Microshift Test Compatibility ✅ Passed PR reverts CI resource limits in a YAML config file; no new Ginkgo e2e tests are added, so MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests added in this PR. The change is a CI configuration revert affecting resource limits only; the SNO test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR reverts resource limits from CI test mapping config. No topology-incompatible scheduling constraints (anti-affinity, spread rules, node selectors) are introduced.
Ote Binary Stdout Contract ✅ Passed PR contains only YAML configuration changes; no source code modifications that could violate OTE Binary Stdout Contract requirements.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR is a configuration revert with no new Ginkgo e2e tests. Custom check is not applicable to YAML configuration changes.
No-Weak-Crypto ✅ Passed PR contains only CI configuration changes (YAML) with no cryptographic code, weak crypto usage (MD5/SHA1/DES/RC4/etc.), or insecure comparisons.
Container-Privileges ✅ Passed PR reverts resource limits from ci-test-mapping config file; no privileged containers, hostPID/Network/IPC, SYS_ADMIN capabilities, or allowPrivilegeEscalation are added or present.
No-Sensitive-Data-In-Logs ✅ Passed The PR modifies a YAML configuration file with no logging statements containing sensitive data such as passwords, tokens, API keys, PII, session IDs, internal hostnames, or customer data.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from deepsm007 and smg247 May 27, 2026 16:54
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@sosiouxme: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-eng-ci-test-mapping-main-lint openshift-eng/ci-test-mapping presubmit Ci-operator config changed
pull-ci-openshift-eng-ci-test-mapping-main-mapping openshift-eng/ci-test-mapping presubmit Ci-operator config changed
pull-ci-openshift-eng-ci-test-mapping-main-unit openshift-eng/ci-test-mapping presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@sosiouxme
Copy link
Copy Markdown
Member Author

/pj-rehearse ack

(lint is going to be broken regardless)

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, sosiouxme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@openshift-merge-bot[bot]: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@sosiouxme: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

@sosiouxme
Copy link
Copy Markdown
Member Author

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@sosiouxme: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 27, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit b9a0848 into openshift:main May 27, 2026
12 of 14 checks passed
@sosiouxme sosiouxme deleted the 20260527-revert-ctm-limits branch May 27, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants