Skip to content

Promote rebasebot image#79778

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
RadekManak:t3code/2189079f
Jun 1, 2026
Merged

Promote rebasebot image#79778
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
RadekManak:t3code/2189079f

Conversation

@RadekManak

@RadekManak RadekManak commented May 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add promotion for the openshift-eng/rebasebot image so postsubmits publish ci/rebasebot:latest
  • generate the matching branch-ci-openshift-eng-rebasebot-main-images postsubmit job
  • keep CAPA migration changes out of this PR so the shared image can bootstrap first

Test plan

  • make update
  • confirm only the rebasebot config and generated postsubmits file changed

Made with Cursor

Summary by CodeRabbit

This PR adds image promotion configuration to the OpenShift CI setup for the openshift-eng/rebasebot repository. Specifically, it enables the rebasebot container image to be published to ci/rebasebot:latest after successful postsubmit builds on the main branch.

The change adds a promotion section (lines 27-30) to the rebasebot CI configuration file, which instructs the CI system to push the built image to the shared OpenShift CI image registry with the latest tag. This allows downstream jobs to consume the rebasebot image directly from the CI registry without requiring bootstrap rehearsal workarounds.

This is a foundational change that unblocks follow-up work by establishing the shared image infrastructure, with CAPA migration changes intentionally excluded to allow the image bootstrap to complete first.

Publish the shared rebasebot image to ci/rebasebot:latest so follow-up jobs can consume it without bootstrap rehearsal failures.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

This PR adds a promotion configuration block to the rebasebot job, specifying that built images are promoted to the ci namespace with the latest tag. The change is a straightforward configuration addition with no code or logic modifications.

Changes

Rebasebot image promotion

Layer / File(s) Summary
Promotion configuration
ci-operator/config/openshift-eng/rebasebot/openshift-eng-rebasebot-main.yaml
Adds a promotion block specifying the destination namespace (ci) and the promoted tag (latest).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR adds no Ginkgo tests, only modifies CI/CD YAML configs and non-Ginkgo Go test data files. Check is not applicable.
Test Structure And Quality ✅ Passed PR modifies only YAML configuration files (CI/CD job definition), not Ginkgo test code. Custom check for test quality requirements does not apply to this pull request.
Microshift Test Compatibility ✅ Passed PR modifies only CI configuration file (openshift-eng-rebasebot-main.yaml), not Ginkgo e2e tests. MicroShift test compatibility check is not applicable to non-test files.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR modifies CI operator configurations and generated job files for rebasebot image promotion. No new Ginkgo e2e tests are added, making this check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR adds only image promotion config to ci-operator; no deployment manifests, operator code, or scheduling constraints (affinity, topology spread, nodeSelector, etc.) are introduced.
Ote Binary Stdout Contract ✅ Passed This PR modifies only YAML CI configuration files, not executable code. The OTE Binary Stdout Contract check applies to Go binaries; YAML config files cannot produce stdout.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds only CI configuration (YAML), not Ginkgo e2e tests. Custom check is not applicable since it applies only when new e2e tests are added.
No-Weak-Crypto ✅ Passed PR contains only CI/CD configuration files with no cryptographic code or weak crypto algorithms (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB) detected.
Container-Privileges ✅ Passed No privilege escalation detected: no privileged:true, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation. Root usage is justified for package installation; drops to non-root user 1001.
No-Sensitive-Data-In-Logs ✅ Passed PR adds only a 4-line promotion config section with namespace and tag values. No passwords, tokens, API keys, PII, or other sensitive data exposed in logs.
Title check ✅ Passed The title 'Promote rebasebot image' directly aligns with the main objective of adding promotion configuration for the rebasebot image to publish to ci/rebasebot:latest.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2026
@openshift-ci openshift-ci Bot requested review from mdbooth and theobarberbany May 27, 2026 17:55
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@RadekManak: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-eng-rebasebot-main-images openshift-eng/rebasebot presubmit Ci-operator config changed
pull-ci-openshift-eng-rebasebot-main-lint openshift-eng/rebasebot presubmit Ci-operator config changed
pull-ci-openshift-eng-rebasebot-main-unit openshift-eng/rebasebot presubmit Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-autoscaling-karpenter-provider-aws N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-migtools-kopia-oadp-1-5 N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-opentelemetry-operator N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-cloud-provider-powervs N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-openstack-ironic N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-cloud-provider-azure N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-openshift-velero-plugin-for-microsoft-azure-oadp-dev N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-openstack-ironic-python-agent N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-cloud-provider-nutanix N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-openshift-oadp-operator-oadp-dev N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-migtools-kubevirt-velero-plugin-main N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-cloud-provider-vpc-controller N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-cloud-provider-aws N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-cluster-api-provider-aws N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-tempo-operator N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-openstack-ironic-prometheus-exporter N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-openshift-velero-oadp-dev N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-openshift-oadp-operator-oadp-1-5 N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-cluster-api-provider-ibmcloud N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-migtools-udistribution-main N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-migtools-filebrowser-oadp-dev N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-rebasebot-main-apiserver-network-proxy N/A periodic Ci-operator config changed

A total of 43 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@RadekManak RadekManak changed the title Bootstrap rebasebot image promotion Promote rebasebot image May 27, 2026
@RadekManak

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-eng-rebasebot-main-cluster-api-provider-aws
Should not affect it.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RadekManak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@RadekManak

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RadekManak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 27, 2026

@damdo damdo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2026
@openshift-ci

openshift-ci Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, RadekManak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

@RadekManak: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 7f99c44 into openshift:main Jun 1, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants