Skip to content

Add ove connected job#79826

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
mhanss:add-ove-conn
May 29, 2026
Merged

Add ove connected job#79826
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
mhanss:add-ove-conn

Conversation

@mhanss
Copy link
Copy Markdown
Contributor

@mhanss mhanss commented May 28, 2026

Summary by CodeRabbit

This PR updates OpenShift CI configuration in the openshift/release repository for the agent QE infrastructure: it adds a new nightly test job entry "baremetal-ove-compact-konflux" to the agent-qe-infra 4.21 amd64-nightly config. The job targets Equinix Metal QE hardware (equinix-ocp-metal-qe), uses the OVE Konflux workflow (agent-qe-baremetal-install-ove-disconnected-konflux), and configures a connected OVE scenario by setting DISCONNECTED: "false" (with SNAPSHOT set to an empty value and vendor set to "dell"). The cluster topology is IPv4-only with 3 masters and 0 workers, and the job includes the standard cluster health check step. This complements the existing disconnected variant to provide coverage for connected OVE installations.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 720bfd3f-ad38-4168-8882-69de2c00b6db

📥 Commits

Reviewing files that changed from the base of the PR and between 0bfc014 and 10d6d3e.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift-eng/agent-qe-infra/openshift-eng-agent-qe-infra-release-4.21-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift-eng/agent-qe-infra/openshift-eng-agent-qe-infra-release-4.21__amd64-nightly.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift-eng/agent-qe-infra/openshift-eng-agent-qe-infra-release-4.21__amd64-nightly.yaml

Walkthrough

Adds a new baremetal-ove-compact-konflux nightly test entry to the 4.21 agent QE ci-operator config, with Equinix Metal profile, OVE environment values (SNAPSHOT empty, VENDOR=dell), IPv4-only, 3 masters/0 workers, DISCONNECTED: "false", cluster-health check, and the agent-qe-baremetal-install-ove-disconnected-konflux workflow.

Changes

OVE Konflux Baremetal Test Configuration

Layer / File(s) Summary
New baremetal-ove-compact-konflux test configuration
ci-operator/config/openshift-eng/agent-qe-infra/openshift-eng-agent-qe-infra-release-4.21__amd64-nightly.yaml
Adds a tests[] job baremetal-ove-compact-konflux with Equinix Metal cluster profile, OVE env vars (SNAPSHOT: "", VENDOR: dell), IPv4-only networking, masters: "3", workers: "0", DISCONNECTED: "false", wires cucushift-installer-check-cluster-health, and sets workflow agent-qe-baremetal-install-ove-disconnected-konflux.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

rehearsals-ack

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add ove connected job' accurately describes the main change: adding a new test configuration entry for an OVE (OpenStack Virtual Edition) connected job variant to the nightly OpenShift release config.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies CI/CD configuration YAML, not Ginkgo test code. The check applies to Go test titles (It(), Describe()), not CI job names.
Test Structure And Quality ✅ Passed PR only modifies YAML CI configuration files, not Ginkgo test code. The custom check targets Ginkgo test structure and quality, which is not applicable to this PR.
Microshift Test Compatibility ✅ Passed This PR only adds CI job configuration (YAML) to the openshift/release repository; it does not add any Ginkgo e2e tests, so the MicroShift test compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR adds CI job configuration in YAML only, not new Ginkgo e2e tests; custom check applies only to test code additions.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies a CI/CD test job configuration file, not deployment manifests, operator code, or controllers; check does not apply.
Ote Binary Stdout Contract ✅ Passed PR modifies only YAML CI configuration files, not OTE test binaries. The check applies to stdout handling in Go test code (main/BeforeSuite/AfterSuite), which is not present in these changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR adds only CI test job configuration in YAML files, not new Ginkgo e2e tests. The check's scope is explicitly limited to "when new Ginkgo e2e tests are added," which does not apply here.
No-Weak-Crypto ✅ Passed PR only adds YAML test configuration with no cryptographic code, implementations, or secret handling that the check is designed to flag.
Container-Privileges ✅ Passed PR modifies a CI Operator config file (not K8s manifest), adding a test job with no container security definitions or privileged settings.
No-Sensitive-Data-In-Logs ✅ Passed PR adds test config with standard values (hostnames, vendor, flags) already established in the public repository. No passwords, tokens, API keys, PII, or secrets exposed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

@openshift-ci openshift-ci Bot requested review from bmanzari and pamoedom May 28, 2026 14:37
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@mhanss: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-eng-agent-qe-infra-release-4.21-amd64-nightly-baremetal-ove-compact-konflux N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@pamoedom
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhanss, pamoedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhanss
Copy link
Copy Markdown
Contributor Author

mhanss commented May 29, 2026

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@mhanss: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 29, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2026

@mhanss: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 674c464 into openshift:main May 29, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants