[WIP] Jv perf scale baseline only has nightlies#79848
Conversation
…set job_type to its own function
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
WalkthroughExtracts Orion baseline job classification into three Bash helpers, replaces inline computation with those helpers, and adds an ORION_BASELINE_JOB_TYPE env var to several Orion steps and the StackRox perfscale chain; also adds a new StackRox perf-scale CI config file. ChangesOrion baseline job type classification refactoring
🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 13 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (13 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@JoukoVirtanen, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
Actionable comments posted: 0 |
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JoukoVirtanen The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
A total of 276 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/stackrox/stackrox/stackrox-stackrox-jv-test-perf-scale__perf-scale.yaml`:
- Around line 66-70: The zz_generated_metadata block contains a temporary
personal branch (branch: jv-test-perf-scale) and should not be merged as-is;
either remove this temporary test config file entirely or update the
zz_generated_metadata (branch, org, repo, variant) to point to the correct
production values (or a tracked canonical branch) and add a PR comment
confirming the change before unblocking the PR; specifically edit the
zz_generated_metadata entry in
stackrox-stackrox-jv-test-perf-scale__perf-scale.yaml to remove or replace the
branch: jv-test-perf-scale value and ensure the file is intended for mainline
config before merge.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 2f15cffa-9d9f-4a3c-ae00-7527ceaca646
⛔ Files ignored due to path filters (1)
ci-operator/jobs/stackrox/stackrox/stackrox-stackrox-jv-test-perf-scale-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/stackrox/stackrox/stackrox-stackrox-jv-test-perf-scale__perf-scale.yaml
| zz_generated_metadata: | ||
| branch: jv-test-perf-scale | ||
| org: stackrox | ||
| repo: stackrox | ||
| variant: perf-scale |
There was a problem hiding this comment.
Confirm this temporary test config is removed before merge.
The metadata targets a personal branch (jv-test-perf-scale) and the commit message states this job was "Temporarily adding a job to test changes". This file looks like a scratch artifact for exercising the Orion baseline refactor, not a production config destined for main. The PR is already WIP//hold, so this is just a reminder to drop it (or repoint to a real branch) before lifting the hold.
Want me to open a tracking issue so this temporary config isn't accidentally merged?
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/stackrox/stackrox/stackrox-stackrox-jv-test-perf-scale__perf-scale.yaml`
around lines 66 - 70, The zz_generated_metadata block contains a temporary
personal branch (branch: jv-test-perf-scale) and should not be merged as-is;
either remove this temporary test config file entirely or update the
zz_generated_metadata (branch, org, repo, variant) to point to the correct
production values (or a tracked canonical branch) and add a PR comment
confirming the change before unblocking the PR; specifically edit the
zz_generated_metadata entry in
stackrox-stackrox-jv-test-perf-scale__perf-scale.yaml to remove or replace the
branch: jv-test-perf-scale value and ensure the file is intended for mainline
config before merge.
|
/test pull-ci-stackrox-stackrox-jv-test-perf-scale-perf-scale-24nodes-scale-test |
|
@JoukoVirtanen: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/pj-rehearse pull-ci-stackrox-stackrox-jv-test-perf-scale-perf-scale-24nodes-scale-test |
|
@JoukoVirtanen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-stackrox-stackrox-jv-test-perf-scale-perf-scale-24nodes-scale-test |
|
@JoukoVirtanen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-stackrox-stackrox-jv-test-perf-scale-perf-scale-24nodes-scale-test |
|
@JoukoVirtanen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@JoukoVirtanen: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Summary by CodeRabbit
This PR makes Orion baseline selection configurable and centralizes the baseline-detection logic used by OpenShift CI perf/scale steps.
What changed in practical terms:
The script now uses these helpers instead of inline case/if logic to compute job_type and pull_number for Orion queries.
Effect and rationale:
Other notes: