OLS-2941: add api-lint presubmit for lightspeed-agentic-operator by onmete · Pull Request #79869 · openshift/release

onmete · 2026-05-29T11:30:55Z

Summary

Add api-lint presubmit for openshift/lightspeed-agentic-operator running make api-lint (kube-api-linter on CRD types)
Completes prow CI coverage for OLS-2941 alongside existing generate and unit jobs

Test plan

make update ran cleanly and regenerated presubmits
/test api-lint passes on a lightspeed-agentic-operator PR after this merges

Made with Cursor

Summary by CodeRabbit

This PR updates OpenShift CI configuration for the openshift/lightspeed-agentic-operator repository to add an API lint presubmit and standardize GOFLAGS for existing tests.

Practical details:

A new presubmit test "api-lint" was added in ci-operator/config/openshift/lightspeed-agentic-operator/openshift-lightspeed-agentic-operator-main.yaml. It runs GOFLAGS="-mod=mod" GOLANGCI_LINT_CACHE=/tmp/.cache make api-lint in the src container (invokes kube-api-linter against the repo's CRD types).
The existing "generate" and "unit" tests were adjusted to run with GOFLAGS="-mod=mod".
The new api-lint job is placed between "generate" and "unit" and uses the same skip_if_only_changed pattern as those jobs.
Test plan: author ran make update to regenerate presubmits; expects /test api-lint to succeed on lightspeed-agentic-operator PRs after this change is merged.
Metadata: references Jira OLS-2941; openshift-ci-robot confirmed the Jira reference but warned the Jira issue has no target version set for the target branch.

The change is a small CI configuration update that completes presubmit coverage for API linting alongside existing generate and unit jobs.

openshift-ci-robot · 2026-05-29T11:30:59Z

@onmete: This pull request references OLS-2941 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Add api-lint presubmit for openshift/lightspeed-agentic-operator running make api-lint (kube-api-linter on CRD types)

Completes prow CI coverage for OLS-2941 alongside existing generate and unit jobs

Test plan

make update ran cleanly and regenerated presubmits

/test api-lint passes on a lightspeed-agentic-operator PR after this merges

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-05-29T11:31:21Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

Updates the OpenShift CI tests matrix: set GOFLAGS="-mod=mod" for existing generate and unit jobs and add a new api-lint job that runs with GOFLAGS and a golangci-lint cache in the src container using the existing skip-if-only-changed pattern.

Changes

CI Test Jobs Update

Layer / File(s)	Summary
Update generate job `ci-operator/config/openshift/lightspeed-agentic-operator/openshift-lightspeed-agentic-operator-main.yaml`	`generate` job command changed to run `make manifests` with `GOFLAGS="-mod=mod"`; container and skip-if-only-changed unchanged.
Add api-lint job `ci-operator/config/openshift/lightspeed-agentic-operator/openshift-lightspeed-agentic-operator-main.yaml`	New `api-lint` job runs `GOFLAGS="-mod=mod" GOLANGCI_LINT_CACHE=/tmp/.cache make api-lint` in the `src` container with the same skip-if-only-changed rule.
Update unit job `ci-operator/config/openshift/lightspeed-agentic-operator/openshift-lightspeed-agentic-operator-main.yaml`	`unit` job command updated to include `GOFLAGS="-mod=mod"` for `make test`; wiring unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels: rehearsals-ack

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding an api-lint presubmit job for lightspeed-agentic-operator, which matches the core purpose of the pull request.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR modifies CI configuration files only, not Ginkgo test code. The custom check targets Ginkgo test names which are not present in this PR, making it inapplicable.
Test Structure And Quality	✅ Passed	PR modifies OpenShift CI configuration only (YAML files defining test jobs), not Ginkgo test code. The check is inapplicable to CI config changes.
Microshift Test Compatibility	✅ Passed	This PR only modifies CI configuration to add an api-lint job; it does not add any Ginkgo e2e tests, so MicroShift test compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR does not add any Ginkgo e2e tests; it only modifies CI configuration for linting and build jobs. SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only CI operator configuration defining test jobs. Does not add/modify deployment manifests, operator code, or controllers. No scheduling constraints introduced.
Ote Binary Stdout Contract	✅ Passed	PR modifies only CI configuration (YAML), not Go source code. OTE Binary Stdout Contract check applies to Go code with process-level stdout writes; not applicable to CI config changes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR modifies only a CI configuration file (openshift-lightspeed-agentic-operator-main.yaml) to add an api-lint presubmit job. No new Ginkgo e2e tests are being added. The check is not applicable.
No-Weak-Crypto	✅ Passed	PR modifies only a CI/CD configuration YAML file with no cryptographic implementations or weak crypto algorithms present.
Container-Privileges	✅ Passed	The PR adds CI test configuration with no privileged containers, hostPID/hostNetwork/hostIPC, SYS_ADMIN capabilities, allowPrivilegeEscalation flags, or root privileges defined.
No-Sensitive-Data-In-Logs	✅ Passed	The PR modifies only CI configuration, adding environment variables and test jobs with standard Go build flags and temporary cache paths; no logging statements or sensitive data exposure detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-merge-bot · 2026-05-29T11:31:27Z

@onmete, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto 604343800fb88e023877d0fcf451710018449db5 due to conflicts

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

onmete · 2026-05-29T11:45:08Z

/pj-rehearse

openshift-merge-bot · 2026-05-29T11:45:12Z