Skip to content

NO_ISSUE: test streaming pull optimization (cluster-tool)#79872

Closed
omer-vishlitzky wants to merge 1 commit into
openshift:mainfrom
omer-vishlitzky:test-streaming-pull
Closed

NO_ISSUE: test streaming pull optimization (cluster-tool)#79872
omer-vishlitzky wants to merge 1 commit into
openshift:mainfrom
omer-vishlitzky:test-streaming-pull

Conversation

@omer-vishlitzky
Copy link
Copy Markdown
Contributor

@omer-vishlitzky omer-vishlitzky commented May 29, 2026

Point CLUSTER_TOOL_COMMIT to optimize-pull-streaming branch to test skopeo-based streaming pull pipeline in CI rehearsals.

Summary by CodeRabbit

This PR modifies the Prow step registry configuration for the OSAC project's cluster-tool boot step to test a new streaming pull optimization in CI rehearsals.

Change Details:

  • Updated the CLUSTER_TOOL_COMMIT environment variable default in osac-project-cluster-tool-boot-ref.yaml from main to optimize-pull-streaming
  • This step is part of the OpenShift CI infrastructure and is responsible for booting an OSAC cluster from a pre-built snapshot using the cluster-tool utility

Practical Impact:
CI rehearsals will now use the optimize-pull-streaming branch of the cluster-tool repository, which contains a skopeo-based streaming pull pipeline optimization, instead of the main branch. This allows testing of the improved pull performance in CI environments before deciding on a stable merge.

Point CLUSTER_TOOL_COMMIT to optimize-pull-streaming branch to test
skopeo-based streaming pull pipeline in CI rehearsals.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@omer-vishlitzky
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-osac-project-osac-operator-main-e2e-vmaas pull-ci-osac-project-fulfillment-service-main-e2e-vmaas pull-ci-osac-project-osac-test-infra-main-e2e-vmaas pull-ci-osac-project-osac-installer-main-e2e-vmaas pull-ci-osac-project-osac-aap-main-e2e-vmaas

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@omer-vishlitzky: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 105bdc87-3b23-4201-9ad6-d7aaaa8c9d6d

📥 Commits

Reviewing files that changed from the base of the PR and between 09f6faf and 451daf5.

📒 Files selected for processing (1)
  • ci-operator/step-registry/osac-project/cluster-tool/boot/osac-project-cluster-tool-boot-ref.yaml

Walkthrough

This PR updates the default git reference for the cluster-tool dependency in the osac-project cluster-tool boot step registry configuration. The CLUSTER_TOOL_COMMIT environment variable default is changed from main to optimize-pull-streaming.

Changes

Cluster Tool Boot Configuration

Layer / File(s) Summary
Cluster tool commit reference update
ci-operator/step-registry/osac-project/cluster-tool/boot/osac-project-cluster-tool-boot-ref.yaml
CLUSTER_TOOL_COMMIT environment variable default changed from main to optimize-pull-streaming to specify the git ref for cluster-tool downloads.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: testing a streaming pull optimization feature in the cluster-tool component by pointing to a new branch.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains only CI configuration file updates, no Ginkgo tests present. Custom check for stable Ginkgo test names is not applicable.
Test Structure And Quality ✅ Passed PR changes YAML config and shell script only; no Ginkgo test code present to review against the test structure check requirements.
Microshift Test Compatibility ✅ Passed PR only updates CI config files (YAML) and tools; no new Ginkgo e2e tests added, so MicroShift test compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR does not add any new Ginkgo e2e tests; it only updates a CI configuration variable. Check is not applicable to this PR.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only a CI step configuration file that sets a git branch reference, not deployment manifests, operator code, or controllers. No scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR only modifies CI configuration YAML file (osac-project-cluster-tool-boot-ref.yaml) changing CLUSTER_TOOL_COMMIT default; no code changes subject to OTE Binary Stdout Contract check.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR does not add new Ginkgo e2e tests - only modifies CI configuration YAML and shell scripts. Custom check not applicable.
No-Weak-Crypto ✅ Passed PR modifies only a YAML CI/CD configuration file. No weak cryptography, custom crypto implementations, or non-constant-time comparisons found.
Container-Privileges ✅ Passed The PR modifies a CI Operator step reference file that only updates an environment variable, containing no K8s container manifest or privilege escalation settings.
No-Sensitive-Data-In-Logs ✅ Passed PR only changes a git ref name default in YAML; no new logging of sensitive data (passwords, tokens, API keys, PII, etc.) is introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: omer-vishlitzky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2026
@openshift-ci openshift-ci Bot requested review from jhernand and trewest May 29, 2026 12:48
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@omer-vishlitzky: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-osac-project-osac-test-infra-main-e2e-vmaas osac-project/osac-test-infra presubmit Registry content changed
pull-ci-osac-project-fulfillment-service-main-e2e-vmaas osac-project/fulfillment-service presubmit Registry content changed
pull-ci-osac-project-osac-installer-main-e2e-vmaas osac-project/osac-installer presubmit Registry content changed
pull-ci-osac-project-osac-aap-main-e2e-vmaas osac-project/osac-aap presubmit Registry content changed
pull-ci-osac-project-osac-operator-main-e2e-vmaas osac-project/osac-operator presubmit Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@omer-vishlitzky
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-osac-project-osac-operator-main-e2e-vmaas pull-ci-osac-project-fulfillment-service-main-e2e-vmaas pull-ci-osac-project-osac-test-infra-main-e2e-vmaas pull-ci-osac-project-osac-installer-main-e2e-vmaas pull-ci-osac-project-osac-aap-main-e2e-vmaas

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@omer-vishlitzky: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2026

@omer-vishlitzky: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant