CNTRLPLANE-772: Add request serving test to HCM periodics#79884
CNTRLPLANE-772: Add request serving test to HCM periodics#79884jiezhao16 wants to merge 2 commits into
Conversation
Enable REQUEST_SERVING_COMPONENT_TEST in the HCM periodic e2e-aws job to validate request-serving topology against real ROSA management clusters. The hypershift-aws-run-e2e-external-commands.sh script already supports this flag — this change only sets the env var in the job config. Related: openshift/hypershift#7031 (test implementation) Related: openshift#70989 (self-managed CI workflow)
openshift-ci-robot
added
the
jira/valid-reference
|
@jiezhao16: This pull request references CNTRLPLANE-772 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughAdds a new periodic job ChangesHyperShift Release 4.21 Periodic Tests
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/pj-rehearse periodic-ci-openshift-hypershift-release-4.21-periodics-hcm-e2e-aws |
|
@jiezhao16: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jiezhao16 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/pj-rehearse periodic-ci-openshift-hypershift-release-4.21-periodics-hcm-e2e-aws-request-serving |
|
@jiezhao16: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.21__periodics-hcm.yaml`:
- Around line 41-47: The new periodic job "e2e-aws-request-serving" was added to
ci-operator config but the generated Prow job artifacts under ci-operator/jobs
were not updated; run the repository's job generation (e.g., execute make update
or the project’s generation target) to regenerate Prow job configs, verify the
generated changes include the new periodic job, and commit those generated files
(or if generation intentionally yields no diffs, add a short note/evidence in
the PR describing why no generated changes occurred); ensure the job name
"e2e-aws-request-serving" appears in the regenerated artifacts before finalizing
the PR.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 3882d26e-43a1-4224-a023-259434eff010
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.21-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.21__periodics-hcm.yaml
| - as: e2e-aws-request-serving | ||
| cron: 0 4 * * * | ||
| steps: | ||
| cluster_profile: hypershift-aws | ||
| env: | ||
| REQUEST_SERVING_COMPONENT_TEST: "true" | ||
| workflow: hypershift-aws-e2e-metrics |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify whether this PR includes generated ci-operator/jobs changes for the new periodic test.
# Expected: at least one changed file under ci-operator/jobs/ for structural test additions.
git diff --name-only -- ci-operator/config ci-operator/jobs | sed 's#^`#-` #'
echo
echo "Changed generated job files:"
git diff --name-only -- ci-operator/jobs | sed 's#^`#-` #'Repository: openshift/release
Length of output: 91
Regenerate and include Prow job configs for e2e-aws-request-serving.
The new periodic test entry (e2e-aws-request-serving, lines 41-47) was added to ci-operator/config, but no regenerated changes under ci-operator/jobs/** are included—please run make update and commit the generated artifacts, or provide evidence that regeneration intentionally produced no diffs.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.21__periodics-hcm.yaml`
around lines 41 - 47, The new periodic job "e2e-aws-request-serving" was added
to ci-operator config but the generated Prow job artifacts under
ci-operator/jobs were not updated; run the repository's job generation (e.g.,
execute make update or the project’s generation target) to regenerate Prow job
configs, verify the generated changes include the new periodic job, and commit
those generated files (or if generation intentionally yields no diffs, add a
short note/evidence in the PR describing why no generated changes occurred);
ensure the job name "e2e-aws-request-serving" appears in the regenerated
artifacts before finalizing the PR.
|
@jiezhao16: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary
REQUEST_SERVING_COMPONENT_TESTin the HCM periodic e2e-aws job for 4.21Related
Test plan
/pj-rehearseto verify the job runs successfullySummary by CodeRabbit
This PR updates the OpenShift CI configuration in the openshift/release repository to enable request-serving validation in the Hypershift Control Plane Manager (HCM) periodic jobs for the 4.21 branch.
What changed
Why it matters
Other notes