OCPBUGS-86879: pre-install skopeo for OCL e2e tests#79990
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@umohnani8: This pull request references Jira Issue OCPBUGS-86879, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pj-rehearse |
|
@umohnani8: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds a CI build image Changessrc-with-skopeo image and test updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
|
@umohnani8: This pull request references Jira Issue OCPBUGS-86879, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/pj-rehearse cancel |
|
@umohnani8: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-ocl-part1 |
|
@umohnani8: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@umohnani8: job(s): cancel either don't exist or were not found to be affected, and cannot be rehearsed |
|
@umohnani8: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
Skopeo v1.23.0 (released 2026-05-26) requires Go 1.25, but the CI build root image only has Go 1.24. The OCL tests install skopeo from source at runtime via hack/install-skopeo.sh, which always fetches the latest release. This causes all OCL test suites to fail. Add a src-with-skopeo overlay image that installs skopeo from RHEL repos via dnf at image build time, and use it for the OCL test steps. This avoids the GitHub API dependency and Go version mismatch entirely. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Urvashi <umohnani@redhat.com>
umohnani8
force-pushed
the
mco-fix-ocl-skopeo-main
branch
from
dc789d0 to
b368c1b
Compare
|
/pj-rehearse pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-ocl-part1 |
|
@umohnani8: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
A total of 68 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-ocl-part2 |
|
@umohnani8: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@umohnani8: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dkhater-redhat, eggfoobar, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@umohnani8 Feel free to |
4 participants
Skopeo v1.23.0 (released 2026-05-26) requires Go 1.25, but the CI build root image only has Go 1.24. The OCL tests install skopeo from source at runtime via hack/install-skopeo.sh, which always fetches the latest release. This causes all OCL test suites to fail.
Add a src-with-skopeo overlay image that installs skopeo from RHEL repos via dnf at image build time, and use it for the OCL test steps. This avoids the GitHub API dependency and Go version mismatch entirely.
Summary by CodeRabbit
This PR updates the OpenShift CI configuration for the machine-config-operator to fix OCL (on-cluster layering) e2e test failures caused by a skopeo/Go version mismatch and runtime installation from GitHub.
Background: Skopeo v1.23.0 requires Go 1.25 while the CI build root image provides Go 1.24. OCL tests previously built and installed the latest skopeo from source at runtime (hack/install-skopeo.sh), which failed due to the Go mismatch and created a dependency on GitHub releases.
What changed:
Impact: OCL tests no longer install skopeo from source at runtime, avoiding Go toolchain incompatibilities and reliance on external GitHub releases.