[rhosdt] Fix OpenTelemetry Operator CI: Go 1.26 builder and opentelemetry-operator-system namespace#80005
Conversation
WalkthroughCI configs and step scripts migrate OpenTelemetry/Tempo installs to ChangesOperator Namespace Migration and Parameter Validation
Build Configuration Updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/distributed-tracing/tests/opentelemetry/stage/distributed-tracing-tests-opentelemetry-stage-commands.sh`:
- Line 81: The shell command invoking oc -n opentelemetry-operator-system patch
csv $OTEL_CSV_NAME should quote the variable to prevent word-splitting and
globbing; update the invocation to use "$OTEL_CSV_NAME" (referencing the
OTEL_CSV_NAME variable and the patch csv command) so the CSV name is treated as
a single safe argument.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 4ad4c50a-492e-469a-ac8d-a24b3398c716
📒 Files selected for processing (14)
ci-operator/config/openshift/open-telemetry-opentelemetry-operator/openshift-open-telemetry-opentelemetry-operator-main__opentelemetry-product-ocp-4.12-stage.yamlci-operator/config/openshift/open-telemetry-opentelemetry-operator/openshift-open-telemetry-opentelemetry-operator-main__opentelemetry-product-ocp-4.14-arm-stage.yamlci-operator/config/openshift/open-telemetry-opentelemetry-operator/openshift-open-telemetry-opentelemetry-operator-main__opentelemetry-product-ocp-4.14-stage.yamlci-operator/config/openshift/open-telemetry-opentelemetry-operator/openshift-open-telemetry-opentelemetry-operator-main__opentelemetry-product-ocp-4.16-ibm-z-stage.yamlci-operator/config/openshift/open-telemetry-opentelemetry-operator/openshift-open-telemetry-opentelemetry-operator-main__opentelemetry-product-ocp-4.17-fips-stage.yamlci-operator/config/openshift/open-telemetry-opentelemetry-operator/openshift-open-telemetry-opentelemetry-operator-main__opentelemetry-product-ocp-4.17-ibm-p-stage.yamlci-operator/config/openshift/open-telemetry-opentelemetry-operator/openshift-open-telemetry-opentelemetry-operator-main__opentelemetry-product-ocp-4.19-stage.yamlci-operator/config/openshift/open-telemetry-opentelemetry-operator/openshift-open-telemetry-opentelemetry-operator-main__opentelemetry-product-ocp-4.20-stage.yamlci-operator/config/openshift/open-telemetry-opentelemetry-operator/openshift-open-telemetry-opentelemetry-operator-main__opentelemetry-product-ocp-4.21-stage.yamlci-operator/config/openshift/open-telemetry-opentelemetry-operator/openshift-open-telemetry-opentelemetry-operator-main__upstream-ocp-4.12-amd64.yamlci-operator/config/openshift/open-telemetry-opentelemetry-operator/openshift-open-telemetry-opentelemetry-operator-main__upstream-ocp-4.21-amd64.yamlci-operator/config/openshift/open-telemetry-opentelemetry-operator/openshift-open-telemetry-opentelemetry-operator-main__upstream-ocp-4.22-amd64.yamlci-operator/step-registry/distributed-tracing/tests/opentelemetry/stage/distributed-tracing-tests-opentelemetry-stage-commands.shci-operator/step-registry/distributed-tracing/tests/tempo/stage/distributed-tracing-tests-tempo-stage-commands.sh
|
/pj-rehearse pull-ci-openshift-open-telemetry-opentelemetry-operator-main-upstream-ocp-4.22-amd64-opentelemetry-upstream-tests |
|
@IshwarKanse: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-open-telemetry-opentelemetry-operator-main-upstream-ocp-4.22-amd64-opentelemetry-upstream-tests |
|
@IshwarKanse: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@IshwarKanse: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
openshift-ci
Bot
removed
the
approved
openshift-merge-bot
Bot
removed
the
rehearsals-ack
IshwarKanse
force-pushed
the
updatetracing
branch
from
baa3e2a to
9a84048
Compare
openshift-ci
Bot
added
the
approved
IshwarKanse
force-pushed
the
updatetracing
branch
from
c7dc5bd to
a3cebd3
Compare
…pace Assisted by Claude Code.
IshwarKanse
force-pushed
the
updatetracing
branch
from
11370a6 to
373ee87
Compare
|
[REHEARSALNOTIFIER]
A total of 30 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[REHEARSALNOTIFIER]
A total of 30 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-open-telemetry-opentelemetry-operator-main-upstream-ocp-4.22-amd64-opentelemetry-upstream-tests |
|
@IshwarKanse: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@IshwarKanse: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IshwarKanse, pavolloffay The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@IshwarKanse: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
Bot
merged commit 6580326
into
openshift:main
…pace (openshift#80005) Assisted by Claude Code.
…pace (openshift#80005) Assisted by Claude Code.
2 participants
Summary
Fix upstream build failures: Bump
build_roottorhel-9-golang-1.26-openshift-5.0for all three upstream OpenTelemetry Operator CI variants (4.12, 4.21, 4.22) — the operator'sgo.modnow requiresgo >= 1.26.0; remove the now-unnecessaryCONTROLLER_TOOLS_VERSION=v0.20.1pin frombinary_build_commandsStandardise install namespace: Replace
openshift-opentelemetry-operatorwithopentelemetry-operator-systemin all stage job configs (9 files) and the stage step script — operator tests hardcode this namespace; downstream configs and steps are intentionally left unchangedRemove hardcoded
MULTISTAGE_PARAM_OVERRIDE_*defaults: Drop stale IIB and Konflux bundle image values fromsteps.envacross all OpenTelemetry Operator, Tempo Operator, and Distributed Tracing QE stage job configs; for arm/ibm-z/ibm-p variants that use inline install steps, replace the stale Konflux SHA default withdefault: ""and add a runtime guard that fails immediately with a clear error if the value is not supplied; ref YAML documentation updated accordinglyParameterise stage test clone and branch: Switch the git clone URL in both otel and tempo stage test steps from a personal fork to
https://github.com/os-observability/opentelemetry-operator.git/https://github.com/os-observability/tempo-operator.git; replace the hardcoded branch (rhosdt-3.9) withOTEL_TESTS_BRANCH/TEMPO_TESTS_BRANCHvariables (declared withdefault: ""in the ref YAML, following the same pattern asMULTISTAGE_PARAM_OVERRIDE_*); a runtime guard fails early if the branch is not providedTest plan
upstream-ocp-4.12-amd64,upstream-ocp-4.21-amd64,upstream-ocp-4.22-amd64) build successfully with Go 1.26opentelemetry-operator-systemand tests passopenshift-opentelemetry-operatorMULTISTAGE_PARAM_OVERRIDE_*orOTEL_TESTS_BRANCH/TEMPO_TESTS_BRANCHfail immediately with a clear error messagesteps.envor Gangway API) clone the correct fork and run against the specified branch