Skip to content

[DO NOT MERGE] Test e2e-kubevirt-aws-ovn-gpu with hypershift-aws profile#80145

Open
rutvik23 wants to merge 1 commit into
openshift:mainfrom
rutvik23:e2e-kubevirt-aws-gpu
Open

[DO NOT MERGE] Test e2e-kubevirt-aws-ovn-gpu with hypershift-aws profile#80145
rutvik23 wants to merge 1 commit into
openshift:mainfrom
rutvik23:e2e-kubevirt-aws-gpu

Conversation

@rutvik23
Copy link
Copy Markdown

@rutvik23 rutvik23 commented Jun 5, 2026

  • Testing credential fix for OCPBUGS-86964 by switching from aws-kubevirt to hypershift-aws cluster profile.

Summary by CodeRabbit

This PR updates OpenShift CI configuration to test a credential fix for OCPBUGS-86964 by running the e2e-kubevirt-aws-ovn-gpu periodic job against HyperShift AWS infrastructure. Concretely, in ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics-mce.yaml the job's cluster_profile is changed from aws-kubevirt to hypershift-aws. The job's dependency overrides (OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE and RELEASE_IMAGE_LATEST) remain pointed at release:stable-latest, and a custom BASE_DOMAIN environment setting was removed so the hypershift-aws profile defaults are used. This change is specific to the 4.22 HyperShift periodic; older release streams continue to use the aws-kubevirt profile. The PR is marked with a hold and is intended for testing.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d82bac70-49a3-4f8e-ad45-acc3a4f02931

📥 Commits

Reviewing files that changed from the base of the PR and between da76496 and 96173d4.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.22-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics-mce.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics-mce.yaml

Walkthrough

This PR updates one periodic test step: the e2e-kubevirt-aws-ovn-gpu test switches its cluster_profile from aws-kubevirt to hypershift-aws and removes the BASE_DOMAIN: cnv-qe.rhood.us env entry; release image dependency overrides are unchanged.

Changes

Periodic test configuration update

Layer / File(s) Summary
e2e-kubevirt-aws-ovn-gpu cluster profile migration
ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics-mce.yaml
The e2e-kubevirt-aws-ovn-gpu test step changes its cluster_profile from aws-kubevirt to hypershift-aws and removes the BASE_DOMAIN: cnv-qe.rhood.us environment variable while keeping the OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE and RELEASE_IMAGE_LATEST dependencies unchanged.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

jira/valid-reference

Suggested reviewers

  • csrwng
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: switching the cluster profile for the e2e-kubevirt-aws-ovn-gpu test to hypershift-aws, which aligns with the actual changeset modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR modifies CI/CD configuration files, not Ginkgo test code. The check for stable Ginkgo test names is not applicable to YAML workflow configurations.
Test Structure And Quality ✅ Passed This PR modifies only CI configuration YAML files, not Ginkgo test code. The custom check for Ginkgo test quality is not applicable to CI configuration files.
Microshift Test Compatibility ✅ Passed PR modifies CI config files only, not adding new Ginkgo e2e tests. Custom check applies only when new tests are added; no test code changes present.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR modifies CI configuration only, changing a cluster profile for an existing test job. No new Ginkgo e2e tests are added, so the SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR only modifies CI test configuration files, not deployment manifests, operator code, or scheduling constraints that affect actual workload deployment.
Ote Binary Stdout Contract ✅ Passed PR modifies only YAML CI/CD configuration (test job setup), not binary code. OTE Binary Stdout Contract check applies to binary-level code changes only, not configuration files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies CI operator configuration (YAML), not Ginkgo e2e test code. No new test code with It(), Describe(), Context(), When() is added, making the custom check non-applicable.
No-Weak-Crypto ✅ Passed The PR modifies a YAML CI/CD configuration file with no cryptographic code, weak crypto algorithms, custom implementations, or secret comparisons.
Container-Privileges ✅ Passed PR modifies CI config file with no container privilege settings. No privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation found.
No-Sensitive-Data-In-Logs ✅ Passed PR does not introduce logging or config exposing passwords, tokens, API keys, PII, session IDs, hostnames, or customer data. Actually removes internal hostname from 4.22 config.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rutvik23
Once this PR has been reviewed and has the lgtm label, please assign jparrill for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rutvik23
Copy link
Copy Markdown
Author

rutvik23 commented Jun 5, 2026

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2026
@rutvik23 rutvik23 marked this pull request as ready for review June 5, 2026 10:32
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2026
@openshift-ci openshift-ci Bot requested review from cblecker and enxebre June 5, 2026 10:32
@rutvik23
Copy link
Copy Markdown
Author

rutvik23 commented Jun 5, 2026

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-aws-ovn-gpu

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@rutvik23: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

…file

Testing credential fix for OCPBUGS-86964 by switching from aws-kubevirt
to hypershift-aws cluster profile."
@rutvik23 rutvik23 force-pushed the e2e-kubevirt-aws-gpu branch from da76496 to 96173d4 Compare June 5, 2026 11:52
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@rutvik23: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-aws-ovn-gpu N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rutvik23
Copy link
Copy Markdown
Author

rutvik23 commented Jun 5, 2026

/test generated-config

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2026

@rutvik23: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-aws-ovn-gpu da76496 link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-aws-ovn-gpu

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rutvik23
Copy link
Copy Markdown
Author

rutvik23 commented Jun 5, 2026

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-aws-ovn-gpu

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@rutvik23: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@cblecker
Copy link
Copy Markdown
Member

cblecker commented Jun 5, 2026

/uncc

@openshift-ci openshift-ci Bot removed the request for review from cblecker June 5, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants