terraform-redhat/rosa modules: consolidate presubmits to pre-push-checks#80215
terraform-redhat/rosa modules: consolidate presubmits to pre-push-checks#80215amandahla wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughTwo CI operator configuration files for ROSA infrastructure variants consolidate their test verification steps. Separate verify-format and verify-gen test steps are replaced with a single always-run pre-push-checks step across both the classic and HCP ROSA configurations. ChangesCI Test Consolidation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amandahla The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse |
|
@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-terraform-redhat-terraform-rhcs-rosa-hcp-release-1.6.4-pre-push-checks |
|
@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Replace separate verify-format (make verify) and verify-gen presubmits with a single pre-push-checks job running make pre-push-checks on main, release-1.6.3, and release-1.6.4 for terraform-rhcs-rosa-hcp and terraform-rhcs-rosa-classic. Regenerated prow job manifests. Signed-off-by: Amanda Hager Lopes de Andrade Katz <amanda.katz@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
amandahla
force-pushed
the
OCM-24672-OCM-24673
branch
from
149fddc to
f56c6ee
Compare
|
/pj-rehearse |
|
@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse |
|
@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-terraform-redhat-terraform-rhcs-rosa-hcp-main-pre-push-checks |
|
@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@amandahla: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Summary
Consolidate
verify-formatandverify-genpresubmit jobs into a singlepre-push-checksjob for allterraform-redhat/rosamodules across three branches (main,release-1.6.3,release-1.6.4).Note: Only the six ci-operator/config/terraform-redhat/terraform-rhcs-rosa-{hcp,classic}/*.yaml files were edited by hand; the matching presubmit manifests under ci-operator/jobs/terraform-redhat/ were regenerated by make ci-operator-prowgen and should not be edited manually.
Type of change
ciRelated
OCM-24672, OCM-24673
Changes
verify-format(make verify) andverify-genpresubmit jobs with a unifiedpre-push-checksjob runningmake pre-push-checksterraform-rhcs-rosa-hcpandterraform-rhcs-rosa-classicreposBreaking changes
No.
Testing / validation
Prow job manifests regenerated via
make update;make checkconfigvalidates Prow configuration. No logic change—job consolidation only.Summary by CodeRabbit
This PR consolidates redundant CI presubmit checks for the terraform-rhcs ROSA modules into a single unified step.
What's changing
The PR updates CI operator configuration for two terraform-redhat repositories (
terraform-rhcs-rosa-classicandterraform-rhcs-rosa-hcp) across three branches each (main,release-1.6.3, andrelease-1.6.4). Previously, these modules ran two separate presubmit verification steps:verify-format– runningmake verifyverify-gen– runningmake verify-genThese are now consolidated into a single
pre-push-checksstep that runsmake pre-push-checks, which presumably includes both validations in one command.Files modified
Six CI operator configuration files were edited directly under
ci-operator/config/terraform-redhat/:terraform-rhcs-rosa-classic/{main, release-1.6.3, release-1.6.4}.yamlterraform-rhcs-rosa-hcp/{main, release-1.6.3, release-1.6.4}.yamlThe corresponding Prow job manifests under
ci-operator/jobs/terraform-redhat/were regenerated viamake ci-operator-prowgen, resulting in 337 insertions and 751 deletions across the generated job definitions – a net reduction of approximately 50% of the manifest code.Impact
make pre-push-checksrather than split across multiple targets