stolostron/multicluster-global-hub: use go1.26-linux builder for release-2.16 by birsanv · Pull Request #81274 · openshift/release

birsanv · 2026-06-30T15:26:58Z

Summary

Bump OpenShift CI build_root and base_images from go1.25-linux to go1.26-linux for stolostron-multicluster-global-hub-release-2.16

Why

Companion to GH 1.7 hub go.mod bump / ACM-36289 — release-2.16 bumps go.mod to 1.26.3 and Dockerfiles to go1.26-linux. Without this change, Prow jobs using from: src (unit, integration, sonarcloud) fail with go.mod requires go >= 1.26.3.

Follows #81216 pattern for 5.0.

Test plan

ci/prow/checkconfig passes on this PR
Merge with or after multicluster-global-hub release-2.16 go bump PR

Made with Cursor

Summary by CodeRabbit

This updates the OpenShift CI configuration for stolostron-multicluster-global-hub-release-2.16 to use the Go 1.26 builder image instead of Go 1.25. In practical terms, it keeps the repo’s Prow jobs aligned with the module’s move to Go 1.26.3, preventing from: src jobs such as unit, integration, and sonarcloud from failing due to an older build environment.

…ase-2.16 Companion to GH 1.7 go.mod bump (ACM-36289) — release-2.16 Prow jobs using from: src need go1.26-linux after hub go.mod moves to 1.26.3. Signed-off-by: Valentina Birsan <vbirsan@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Valentina Birsan <vbirsan@redhat.com>

coderabbitai · 2026-06-30T15:27:25Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e6071016-ef6d-4735-9a65-18dae6ca722e

📥 Commits

Reviewing files that changed from the base of the PR and between 5486e70 and 7d5a561.

📒 Files selected for processing (1)

ci-operator/config/stolostron/multicluster-global-hub/stolostron-multicluster-global-hub-release-2.16.yaml

Walkthrough

Updates the CI operator config for stolostron/multicluster-global-hub release-2.16 to replace the Go builder image tag from go1.25-linux to go1.26-linux, affecting both the base_images entry and build_root.image_stream_tag.tag.

Changes

Go 1.26 Builder Bump

Layer / File(s)	Summary
Builder image tag update `ci-operator/config/stolostron/multicluster-global-hub/stolostron-multicluster-global-hub-release-2.16.yaml`	Replaces `stolostron_builder_go1.25-linux` with `stolostron_builder_go1.26-linux` in `base_images` and updates `build_root.image_stream_tag.tag` to `go1.26-linux`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

openshift/release#81159: Updates build_root.image_stream_tag.tag to a Go 1.26-based builder image in a release YAML, same pattern as this PR.
openshift/release#81216: Also updates the Stolostron multicluster-global-hub CI config to switch from go1.25-linux to go1.26-linux, directly parallel change.
openshift/release#81256: Bumps build_root.image_stream_tag.tag from Go 1.25 to Go 1.26 in a CI config.

Suggested labels

lgtm, approved, rehearsals-ack, jira/valid-reference

Suggested reviewers

bjoydeep

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and accurately describes the main change: switching the release-2.16 builder to go1.26-linux.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR only modifies a CI YAML config and contains no Ginkgo test definitions or titles, so there are no unstable test names to flag.
Test Structure And Quality	✅ Passed	PASS: PR only changes an OpenShift CI YAML to bump Go builder images; no Ginkgo/spec test code, setup/cleanup, or timeout patterns are introduced.
Microshift Test Compatibility	✅ Passed	Only ci-operator YAML changed; no new Ginkgo tests or MicroShift-unsupported APIs/resources were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only adds a CI config YAML for Go 1.26; no new Ginkgo test code or SNO-sensitive test logic was introduced.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a Prow CI YAML changed, bumping Go base images; no deployment manifests, operators, or controllers were modified, so no topology-sensitive scheduling risk.
Ote Binary Stdout Contract	✅ Passed	PR only updates an OpenShift CI YAML build_root/base_images tag; no Go/process-level code or suite setup was changed, so no stdout contract risk.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only a CI config YAML changed; no new Ginkgo e2e test code or network assumptions were added.
No-Weak-Crypto	✅ Passed	PR only bumps CI build_root/base_images from go1.25-linux to go1.26-linux in a YAML config; no weak crypto, custom crypto, or secret comparisons present.
Container-Privileges	✅ Passed	The touched CI YAML only bumps builder tags to go1.26; it contains no privileged, root, hostPID/hostNetwork/hostIPC, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only bumps Go image tags; its log lines echo image refs and OPENSHIFT_CI, with no passwords, tokens, PII, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

openshift-merge-bot · 2026-06-30T15:34:24Z

[REHEARSALNOTIFIER]
@birsanv: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-stolostron-multicluster-global-hub-release-2.16-images	stolostron/multicluster-global-hub	presubmit	Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.16-sonarcloud	stolostron/multicluster-global-hub	presubmit	Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.16-test-e2e	stolostron/multicluster-global-hub	presubmit	Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.16-test-integration	stolostron/multicluster-global-hub	presubmit	Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.16-test-unit	stolostron/multicluster-global-hub	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

birsanv · 2026-06-30T15:43:02Z

/pj-rehearse

openshift-merge-bot · 2026-06-30T15:43:06Z

@birsanv: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

birsanv · 2026-06-30T18:15:20Z

/retest-required

birsanv · 2026-06-30T18:17:06Z

/pj-rehearse

openshift-merge-bot · 2026-06-30T18:17:09Z

@birsanv: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

birsanv · 2026-06-30T18:51:58Z

/pj-rehearse pull-ci-stolostron-multicluster-global-hub-release-2.16-sonarcloud

openshift-merge-bot · 2026-06-30T18:52:01Z

@birsanv: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

birsanv · 2026-06-30T20:05:24Z

/pj-rehearse pull-ci-stolostron-multicluster-global-hub-release-2.16-sonarcloud

openshift-merge-bot · 2026-06-30T20:05:30Z

@birsanv: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

bjoydeep · 2026-06-30T22:03:46Z

/lgtm /approve

openshift-ci · 2026-06-30T22:04:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: birsanv, bjoydeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/stolostron/multicluster-global-hub/OWNERS~~ [birsanv,bjoydeep]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Use Go tool directive and `go install tool` in go.yml so gci/gofumpt versions come from go.sum. Resolves the two open githubactions:S8545 findings that keep release-2.16 security rating at C and block the sonarcloud Prow job (openshift/release#81274 rehearse). Signed-off-by: Valentina Birsan <vbirsan@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

birsanv · 2026-06-30T22:27:54Z

/pj-rehearse pull-ci-stolostron-multicluster-global-hub-release-2.16-sonarcloud

openshift-merge-bot · 2026-06-30T22:27:56Z

@birsanv: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

birsanv · 2026-06-30T22:47:01Z

/pj-rehearse ack

openshift-merge-bot · 2026-06-30T22:47:04Z

@birsanv: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci · 2026-06-30T23:16:04Z

@birsanv: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

…ub-1.4] (#2602) * Bump Go toolchain to 1.26.3 for GH 1.4 z-stream Update go.mod, Konflux/Prow builder images, GitHub Actions workflows, and go tool directive for gci/gofumpt on release-2.13. Clears SonarCloud S8545 findings and aligns with openshift/release go1.26-linux builder. Companion to GH 1.7.2 pattern (PRs #2581/#2589, openshift/release#81274). Signed-off-by: Valentina Birsan <vbirsan@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Valentina Birsan <vbirsan@redhat.com> * Retrigger Konflux manager build after clamav-scan flake One of four arch clamav-scan tasks failed in 14s (infra); amd64 scan passed clean. Empty commit to re-run on-pull-request pipeline. Signed-off-by: Valentina Birsan <vbirsan@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> --------- Signed-off-by: Valentina Birsan <vbirsan@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

…ub-1.5] (#2603) * Bump Go toolchain to 1.26.3 for GH 1.5 z-stream Update go.mod, Konflux/Prow builder images, GitHub Actions workflows, and go tool directive for gci/gofumpt on release-2.14. Clears SonarCloud S8545 findings and aligns with openshift/release go1.26-linux builder. Companion to GH 1.7.2 pattern (PRs #2581/#2589, openshift/release#81274). Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Valentina Birsan <vbirsan@redhat.com> * Fix CI failures for Go 1.26.3 bump on release-2.14 - Add bash shebang and fix decision typo in policy.sh (Konflux sast-shell-check) - Avoid send on closed channel during DB worker pool shutdown (integration test) Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Valentina Birsan <vbirsan@redhat.com> * Add workerpool unit tests for shutdown race fix Cover context-cancelled shutdown paths in worker.start() so SonarCloud new-code coverage meets the 70% gate on release-2.14. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Valentina Birsan <vbirsan@redhat.com> --------- Signed-off-by: Valentina Birsan <vbirsan@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

…ase-2.16 (openshift#81274) Companion to GH 1.7 go.mod bump (ACM-36289) — release-2.16 Prow jobs using from: src need go1.26-linux after hub go.mod moves to 1.26.3. Signed-off-by: Valentina Birsan <vbirsan@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

openshift-ci Bot requested review from bjoydeep and eemurphy June 30, 2026 15:28

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2026

birsanv mentioned this pull request Jun 30, 2026

Fix SonarCloud quality gate GitHub Actions findings stolostron/multicluster-global-hub#2582

Merged

3 tasks

birsanv mentioned this pull request Jun 30, 2026

Pin checkout and setup-go to full SHAs for SonarCloud quality gate stolostron/multicluster-global-hub#2584

Merged

4 tasks

birsanv mentioned this pull request Jun 30, 2026

Fix SonarCloud S8545: install gci/gofumpt via go tool directive stolostron/multicluster-global-hub#2589

Merged

3 tasks

bjoydeep approved these changes Jun 30, 2026

View reviewed changes

openshift-ci Bot assigned bjoydeep Jun 30, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2026

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 30, 2026

openshift-merge-bot Bot merged commit 429e5eb into openshift:main Jun 30, 2026
19 checks passed

coderabbitai Bot mentioned this pull request Jul 1, 2026

Add odf-operator ci config for 4.23 #81319

Merged

Uh oh!

Conversation

birsanv commented Jun 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Uh oh!

openshift-merge-bot Bot commented Jun 30, 2026

Uh oh!

birsanv commented Jun 30, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 30, 2026

Uh oh!

birsanv commented Jun 30, 2026

Uh oh!

birsanv commented Jun 30, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 30, 2026

Uh oh!

birsanv commented Jun 30, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 30, 2026

Uh oh!

birsanv commented Jun 30, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 30, 2026

Uh oh!

bjoydeep commented Jun 30, 2026

Uh oh!

openshift-ci Bot commented Jun 30, 2026

Uh oh!

birsanv commented Jun 30, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 30, 2026

Uh oh!

birsanv commented Jun 30, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 30, 2026

Uh oh!

openshift-ci Bot commented Jun 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

birsanv commented Jun 30, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 30, 2026 •

edited

Loading