Skip to content

[DO NOT MERGE] Point e2e periodic to fork for RHOAI version bump testing#81372

Open
are-ces wants to merge 2 commits into
openshift:mainfrom
are-ces:lcore-e2e-periodic
Open

[DO NOT MERGE] Point e2e periodic to fork for RHOAI version bump testing#81372
are-ces wants to merge 2 commits into
openshift:mainfrom
are-ces:lcore-e2e-periodic

Conversation

@are-ces

@are-ces are-ces commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Points the lightspeed-stack e2e periodic job to a fork branch for RHOAI version bump testing

Test plan

  • Verify the periodic job triggers and clones from the correct fork/branch
  • Confirm the e2e pipeline executes successfully

🤖 Generated with Claude Code

Summary by CodeRabbit

Updated the OpenShift CI lightspeed-stack e2e periodic job (e2e-lcore-cluster-periodics) to clone lightspeed-stack from the are-ces fork and check out the lcore-2860-fix-rhoai-pipeline branch. This redirects the periodic e2e run to exercise the RHOAI version-bump path using the forked branch instead of the default upstream source.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 2, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@are-ces: This pull request references LCORE-1496 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Points the lightspeed-stack e2e periodic job to a fork branch for RHOAI version bump testing

Test plan

  • Verify the periodic job triggers and clones from the correct fork/branch
  • Confirm the e2e pipeline executes successfully

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@are-ces

are-ces commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@are-ces: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@are-ces are-ces changed the title LCORE-1496: Point e2e periodic to fork for RHOAI version bump testing [DO NOT MERGE] Point e2e periodic to fork for RHOAI version bump testing Jul 2, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@are-ces: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Summary

  • Points the lightspeed-stack e2e periodic job to a fork branch for RHOAI version bump testing

Test plan

  • Verify the periodic job triggers and clones from the correct fork/branch
  • Confirm the e2e pipeline executes successfully

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 2, 2026
@openshift-ci openshift-ci Bot requested review from joshuawilson and tisnik July 2, 2026 07:34
@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: are-ces
Once this PR has been reviewed and has the lgtm label, please assign joshuawilson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The e2e test step now clones lightspeed-stack from a forked repository and checks out a specific branch instead of using the default branch.

Changes

Test source override

Layer / File(s) Summary
Repo URL and branch checkout
ci-operator/config/lightspeed-core/lightspeed-stack/lightspeed-core-lightspeed-stack-main.yaml
REPO_URL now points to are-ces/lightspeed-stack, and git clone uses -b lcore-2860-fix-rhoai-pipeline.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: redirecting the e2e periodic job to a fork for RHOAI version bump testing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Changed file only updates a clone URL/branch in ci-operator YAML; no Ginkgo It/Describe/Context titles were added or modified.
Test Structure And Quality ✅ Passed Not applicable: the PR only edits a ci-operator YAML to clone a fork/branch; it adds no Ginkgo test code, so test-structure quality can't be assessed here.
Microshift Test Compatibility ✅ Passed PR only changes ci-operator clone URL/branch in a periodic job config; no new Ginkgo tests or MicroShift-unsupported APIs were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only changes a ci-operator YAML clone target/branch; no new Ginkgo e2e test code is added, so the SNO check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only the e2e job’s clone URL/branch changed; no deployment manifests, controllers, or scheduling constraints were modified.
Ote Binary Stdout Contract ✅ Passed PR only edits ci-operator YAML to change clone repo/branch; no OTE binary main/init/suite code or stdout writes were touched.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo test definitions were added; the PR only changes a ci-operator YAML command that clones a fork/branch.
No-Weak-Crypto ✅ Passed Touched YAML only changes git clone repo/branch; no weak-crypto algorithms, custom crypto, or secret comparisons were introduced.
Container-Privileges ✅ Passed The only PR change is a clone URL/branch in the ci-operator config; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings are present.
No-Sensitive-Data-In-Logs ✅ Passed The only new output is a generic clone message; no passwords, tokens, PII, or internal/customer data are logged.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@are-ces

are-ces commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@are-ces: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@are-ces

are-ces commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@are-ces: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@are-ces: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-lightspeed-core-lightspeed-stack-main-e2e-lcore-cluster-periodics N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/lightspeed-core/lightspeed-stack/lightspeed-core-lightspeed-stack-main.yaml`:
- Line 43: The periodic e2e job is still cloning from a temporary fork/branch
override, so update the job definition in the lightspeed-stack main config to
remove the hardcoded branch override and restore the canonical
repository/default branch, or gate this change behind the rehearsal-only
workflow tied to the PR’s temporary testing path. Use the git clone step in the
lightspeed-stack periodic job as the anchor and ensure the override cannot
persist into a merged config.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8af0d513-bc4e-41b3-bdb0-d46e6d55cb83

📥 Commits

Reviewing files that changed from the base of the PR and between 06c8307 and 927a6ff.

📒 Files selected for processing (1)
  • ci-operator/config/lightspeed-core/lightspeed-stack/lightspeed-core-lightspeed-stack-main.yaml

REPO_URL="https://github.com/are-ces/lightspeed-stack.git"
echo "===== Cloning lightspeed-stack repo ====="
git clone "$REPO_URL"
git clone -b lcore-2860-fix-rhoai-pipeline "$REPO_URL"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win

Temporary fork/branch override — confirm before merge.

This points the periodic e2e job's clone at a fork (are-ces) and a fixed branch (lcore-2860-fix-rhoai-pipeline) rather than the canonical lightspeed-stack repo/default branch. This is consistent with the PR's stated purpose (rehearsal for RHOAI version bump testing) and the [DO NOT MERGE] title, but since this drives a periodic job, an accidental merge would silently redirect the production nightly e2e signal to an unmaintained fork branch indefinitely.

Please ensure this is reverted (or replaced with a /pj-rehearse-only workflow) before this PR is closed/merged.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/lightspeed-core/lightspeed-stack/lightspeed-core-lightspeed-stack-main.yaml`
at line 43, The periodic e2e job is still cloning from a temporary fork/branch
override, so update the job definition in the lightspeed-stack main config to
remove the hardcoded branch override and restore the canonical
repository/default branch, or gate this change behind the rehearsal-only
workflow tied to the PR’s temporary testing path. Use the git clone step in the
lightspeed-stack periodic job as the anchor and ensure the override cannot
persist into a merged config.

@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@are-ces: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-lightspeed-core-lightspeed-stack-main-e2e-lcore-cluster-periodics 927a6ff link unknown /pj-rehearse periodic-ci-lightspeed-core-lightspeed-stack-main-e2e-lcore-cluster-periodics

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants