[DO NOT MERGE] Point e2e periodic to fork for RHOAI version bump testing#81372
[DO NOT MERGE] Point e2e periodic to fork for RHOAI version bump testing#81372are-ces wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@are-ces: This pull request references LCORE-1496 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pj-rehearse |
|
@are-ces: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@are-ces: No Jira issue is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: are-ces The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughThe e2e test step now clones ChangesTest source override
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/pj-rehearse |
|
@are-ces: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
/pj-rehearse |
|
@are-ces: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/lightspeed-core/lightspeed-stack/lightspeed-core-lightspeed-stack-main.yaml`:
- Line 43: The periodic e2e job is still cloning from a temporary fork/branch
override, so update the job definition in the lightspeed-stack main config to
remove the hardcoded branch override and restore the canonical
repository/default branch, or gate this change behind the rehearsal-only
workflow tied to the PR’s temporary testing path. Use the git clone step in the
lightspeed-stack periodic job as the anchor and ensure the override cannot
persist into a merged config.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 8af0d513-bc4e-41b3-bdb0-d46e6d55cb83
📒 Files selected for processing (1)
ci-operator/config/lightspeed-core/lightspeed-stack/lightspeed-core-lightspeed-stack-main.yaml
| REPO_URL="https://github.com/are-ces/lightspeed-stack.git" | ||
| echo "===== Cloning lightspeed-stack repo =====" | ||
| git clone "$REPO_URL" | ||
| git clone -b lcore-2860-fix-rhoai-pipeline "$REPO_URL" |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
Temporary fork/branch override — confirm before merge.
This points the periodic e2e job's clone at a fork (are-ces) and a fixed branch (lcore-2860-fix-rhoai-pipeline) rather than the canonical lightspeed-stack repo/default branch. This is consistent with the PR's stated purpose (rehearsal for RHOAI version bump testing) and the [DO NOT MERGE] title, but since this drives a periodic job, an accidental merge would silently redirect the production nightly e2e signal to an unmaintained fork branch indefinitely.
Please ensure this is reverted (or replaced with a /pj-rehearse-only workflow) before this PR is closed/merged.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/lightspeed-core/lightspeed-stack/lightspeed-core-lightspeed-stack-main.yaml`
at line 43, The periodic e2e job is still cloning from a temporary fork/branch
override, so update the job definition in the lightspeed-stack main config to
remove the hardcoded branch override and restore the canonical
repository/default branch, or gate this change behind the rehearsal-only
workflow tied to the PR’s temporary testing path. Use the git clone step in the
lightspeed-stack periodic job as the anchor and ensure the override cannot
persist into a merged config.
|
@are-ces: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Updated the OpenShift CI lightspeed-stack e2e periodic job (
e2e-lcore-cluster-periodics) to clonelightspeed-stackfrom theare-cesfork and check out thelcore-2860-fix-rhoai-pipelinebranch. This redirects the periodic e2e run to exercise the RHOAI version-bump path using the forked branch instead of the default upstream source.