Skip to content

OSSM: enable auto pipeline mode for sail-operator#81402

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
fjglira:fix-ossm-pipeline
Jul 2, 2026
Merged

OSSM: enable auto pipeline mode for sail-operator#81402
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
fjglira:fix-ossm-pipeline

Conversation

@fjglira

@fjglira fjglira commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

The e2e-ocp presubmit job in openshift-service-mesh/sail-operator was never running automatically on pull requests. The job was correctly marked as a second-stage job (always_run: false, pipeline_skip_if_only_changed), but the repository was not registered with the pipeline-controller, so nothing ever triggered it. As a result, PRs merged without OCP e2e coverage.

Solution
Register openshift-service-mesh/sail-operator in the pipeline-controller config with trigger: auto mode for all active branches (main, release-3.0 through release-3.4).

With this change:

  • First stage (unit, lint, gencheck, integration) runs automatically on every push — unchanged behavior
  • Second stage (e2e-ocp) is triggered automatically once all first-stage required jobs pass — no cluster wasted on lint failures
  • pipeline_skip_if_only_changed on e2e-ocp already handles doc-only PRs correctly — the OCP job is skipped when only docs/, .github/, .md, OWNERS, or LICENSE files change

Summary by CodeRabbit

This change enables automated CI pipeline handling for openshift-service-mesh/sail-operator by registering the repository with trigger: auto on the supported branches (main and release-3.0 through release-3.4). In practical terms, this lets the e2e-ocp presubmit job run as the intended second-stage job after the required first-stage checks pass, while preserving the existing skip behavior for docs-only changes.

Register openshift-service-mesh/sail-operator in the pipeline-controller
config with trigger: auto so that e2e-ocp jobs are automatically triggered
only after the required first-stage jobs (unit, lint, gencheck, integration)
pass, rather than running all jobs in parallel or requiring manual /test commands.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 2, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@fjglira: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci openshift-ci Bot requested review from danilo-gemoli and psalajova July 2, 2026 14:02
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: cd8d27e9-9e47-4664-801c-6287f4727579

📥 Commits

Reviewing files that changed from the base of the PR and between 8dd19f2 and fe80fb4.

📒 Files selected for processing (1)
  • core-services/pipeline-controller/config.yaml

Walkthrough

Adds a new orgs configuration entry for openshift-service-mesh in the pipeline-controller config, defining the sail-operator repo with mode.trigger set to auto and branch coverage for main and five release-3.x branches.

Changes

Pipeline Controller Configuration

Layer / File(s) Summary
Add sail-operator config entry
core-services/pipeline-controller/config.yaml
New orgs block for openshift-service-mesh adds sail-operator repo config with mode.trigger: auto and branches main, release-3.0 through release-3.4.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: lgtm, approved

Suggested reviewers: dcillera, dgn, FilipB

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: enabling auto pipeline mode for sail-operator in OSSM.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only core-services/pipeline-controller/config.yaml changed; it adds repo registration YAML, not Ginkgo test titles, so the check is not applicable.
Test Structure And Quality ✅ Passed PASS: The PR only changes pipeline-controller YAML; no Ginkgo test files or It blocks were touched, so the test-structure checklist is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo tests were added; the PR only registers sail-operator in pipeline-controller config.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only pipeline-controller config changed; no new Ginkgo tests or SNO-sensitive logic were added, so this check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only pipeline-controller config changed; no deployment manifests, controllers, or scheduling logic were added, so no topology-aware scheduling risk is introduced.
Ote Binary Stdout Contract ✅ Passed Only core-services/pipeline-controller/config.yaml changed; no process-level code or stdout writes were added, so the OTE stdout contract is unaffected.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only adds pipeline-controller YAML for sail-operator; no new Ginkgo tests or network/IP-handling code were introduced.
No-Weak-Crypto ✅ Passed Changed file is pipeline-controller YAML only; no weak-crypto algorithms, custom crypto, or secret comparisons appear in the diff.
Container-Privileges ✅ Passed PR only adds a pipeline-controller repo entry; no privileged, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings were introduced.
No-Sensitive-Data-In-Logs ✅ Passed PASS: The only change is a pipeline-controller config entry for sail-operator; no code, log statements, or sensitive fields were added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@fjglira: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hector-vido

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2026
@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fjglira, hector-vido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 509ffd5 into openshift:main Jul 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants