Skip to content

Configure tide for the rhds/workbenches-operator repository#81433

Open
jstourac wants to merge 1 commit into
openshift:mainfrom
jstourac:onboardRhdsWorkbenchesOperator
Open

Configure tide for the rhds/workbenches-operator repository#81433
jstourac wants to merge 1 commit into
openshift:mainfrom
jstourac:onboardRhdsWorkbenchesOperator

Conversation

@jstourac

@jstourac jstourac commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

https://redhat.atlassian.net/browse/RHOAIENG-62574

Summary by CodeRabbit

This PR adds Prow configuration for the red-hat-data-services/workbenches-operator repository. It enables self-approval via the approve plugin (require_self_approval: true), activates lgtm with review_acts_as_lgtm: true, and registers the standard internal plugin set (e.g., assign/label/jira/hold/lifecycle/wip, etc.) for the repo.

It also wires up external plugin actions (refresh, cherrypick, needs-rebase, backport-verifier) to run on issue_comment and/or pull_request events, and allows openshift-merge-bot through repo-scoped trusted app triggers. Finally, it explicitly disables Prow branch protection for the repo (protect: false).

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a0331450-15f5-46d6-b04b-8c0e1621de78

📥 Commits

Reviewing files that changed from the base of the PR and between 1a9f001 and 3533216.

📒 Files selected for processing (2)
  • core-services/prow/02_config/red-hat-data-services/workbenches-operator/_pluginconfig.yaml
  • core-services/prow/02_config/red-hat-data-services/workbenches-operator/_prowconfig.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • core-services/prow/02_config/red-hat-data-services/workbenches-operator/_pluginconfig.yaml

Walkthrough

Adds repo-scoped Prow configuration for red-hat-data-services/workbenches-operator, including plugin settings, trusted trigger access, and branch-protection settings.

Changes

Prow Configuration for workbenches-operator

Layer / File(s) Summary
Plugin configuration
core-services/prow/02_config/red-hat-data-services/workbenches-operator/_pluginconfig.yaml
Enables self-approval for approve, configures external plugin actions and triggers, enables lgtm review behavior, lists internal plugins, and allows openshift-merge-bot triggers.
Branch protection
core-services/prow/02_config/red-hat-data-services/workbenches-operator/_prowconfig.yaml
Adds branch-protection config for the repository and sets protect: false.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding Tide/Prow configuration for the rhds/workbenches-operator repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only adds Prow YAML config files; no Ginkgo test titles or test code were introduced.
Test Structure And Quality ✅ Passed PR only adds Prow config YAML; no Ginkgo test code was added or modified, so the check is not applicable.
Microshift Test Compatibility ✅ Passed Only Prow config YAML changed; no Ginkgo tests or runtime API usage were added, so MicroShift compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only adds Prow config files; no Ginkgo tests were added or modified, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only changes Prow config files; no manifests, controllers, or scheduling constraints were added or modified.
Ote Binary Stdout Contract ✅ Passed Only two Prow YAML config files changed; no process-level code, main/TestMain setup, or stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only Prow config YAML was added; no Ginkgo e2e tests or network code were introduced.
No-Weak-Crypto ✅ Passed The PR only adds two Prow YAML configs; neither file contains weak-crypto terms, custom crypto, or secret/token comparison logic.
Container-Privileges ✅ Passed The PR only adds two Prow config YAMLs; no Kubernetes/container manifests or privileged settings (privileged, hostPID/Network/IPC, SYS_ADMIN, root, allowPrivilegeEscalation) are present.
No-Sensitive-Data-In-Logs ✅ Passed Added Prow config only; no logging statements, secrets, tokens, PII, or customer data found in the changed files.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from droslean and hector-vido July 3, 2026 08:57
@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2026
@jstourac

jstourac commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

@harshad16 could you, please, check this one once you are available? Thank you!

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 3, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
core-services/prow/02_config/red-hat-data-services/workbenches-operator/_prowconfig.yaml (1)

8-19: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Missing jira/invalid-bug in missingLabels?

The jira plugin is enabled in _pluginconfig.yaml, but the tide missingLabels list here doesn't block jira/invalid-bug, unlike the reference config for other repos (e.g., kn-plugin-event). If Jira validation is expected to gate merges for this repo, consider adding it; otherwise this is fine as-is.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@core-services/prow/02_config/red-hat-data-services/workbenches-operator/_prowconfig.yaml`
around lines 8 - 19, The tide query config for the workbenches-operator repo is
missing the jira/invalid-bug gate in missingLabels. Update the _prowconfig.yaml
entry under the relevant queries block to include jira/invalid-bug alongside the
other blocked labels, matching the pattern used by the reference repo configs,
so merge validation is consistent when the jira plugin is enabled.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In
`@core-services/prow/02_config/red-hat-data-services/workbenches-operator/_prowconfig.yaml`:
- Around line 8-19: The tide query config for the workbenches-operator repo is
missing the jira/invalid-bug gate in missingLabels. Update the _prowconfig.yaml
entry under the relevant queries block to include jira/invalid-bug alongside the
other blocked labels, matching the pattern used by the reference repo configs,
so merge validation is consistent when the jira plugin is enabled.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0173c9b6-8200-444d-b630-285fb0bfa643

📥 Commits

Reviewing files that changed from the base of the PR and between fdfa3b1 and 1a9f001.

📒 Files selected for processing (2)
  • core-services/prow/02_config/red-hat-data-services/workbenches-operator/_pluginconfig.yaml
  • core-services/prow/02_config/red-hat-data-services/workbenches-operator/_prowconfig.yaml

@jstourac jstourac force-pushed the onboardRhdsWorkbenchesOperator branch from 1a9f001 to 3533216 Compare July 3, 2026 09:12
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jstourac: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

@jstourac: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant