Configure tide for the rhds/workbenches-operator repository#81433
Configure tide for the rhds/workbenches-operator repository#81433jstourac wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds repo-scoped Prow configuration for ChangesProw Configuration for workbenches-operator
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@harshad16 could you, please, check this one once you are available? Thank you! |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
core-services/prow/02_config/red-hat-data-services/workbenches-operator/_prowconfig.yaml (1)
8-19: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winMissing
jira/invalid-buginmissingLabels?The
jiraplugin is enabled in_pluginconfig.yaml, but the tidemissingLabelslist here doesn't blockjira/invalid-bug, unlike the reference config for other repos (e.g.,kn-plugin-event). If Jira validation is expected to gate merges for this repo, consider adding it; otherwise this is fine as-is.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@core-services/prow/02_config/red-hat-data-services/workbenches-operator/_prowconfig.yaml` around lines 8 - 19, The tide query config for the workbenches-operator repo is missing the jira/invalid-bug gate in missingLabels. Update the _prowconfig.yaml entry under the relevant queries block to include jira/invalid-bug alongside the other blocked labels, matching the pattern used by the reference repo configs, so merge validation is consistent when the jira plugin is enabled.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@core-services/prow/02_config/red-hat-data-services/workbenches-operator/_prowconfig.yaml`:
- Around line 8-19: The tide query config for the workbenches-operator repo is
missing the jira/invalid-bug gate in missingLabels. Update the _prowconfig.yaml
entry under the relevant queries block to include jira/invalid-bug alongside the
other blocked labels, matching the pattern used by the reference repo configs,
so merge validation is consistent when the jira plugin is enabled.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 0173c9b6-8200-444d-b630-285fb0bfa643
📒 Files selected for processing (2)
core-services/prow/02_config/red-hat-data-services/workbenches-operator/_pluginconfig.yamlcore-services/prow/02_config/red-hat-data-services/workbenches-operator/_prowconfig.yaml
1a9f001 to
3533216
Compare
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@jstourac: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
https://redhat.atlassian.net/browse/RHOAIENG-62574
Summary by CodeRabbit
This PR adds Prow configuration for the
red-hat-data-services/workbenches-operatorrepository. It enables self-approval via theapproveplugin (require_self_approval: true), activateslgtmwithreview_acts_as_lgtm: true, and registers the standard internal plugin set (e.g., assign/label/jira/hold/lifecycle/wip, etc.) for the repo.It also wires up external plugin actions (
refresh,cherrypick,needs-rebase,backport-verifier) to run onissue_commentand/orpull_requestevents, and allowsopenshift-merge-botthrough repo-scoped trusted app triggers. Finally, it explicitly disables Prow branch protection for the repo (protect: false).