Skip to content

openshift/cluster-capi-operator: skip post-install test for manifests-gen changes#81452

Open
damdo wants to merge 1 commit into
openshift:mainfrom
damdo:ccapio-donot-run-post-install-for-manifestsgen
Open

openshift/cluster-capi-operator: skip post-install test for manifests-gen changes#81452
damdo wants to merge 1 commit into
openshift:mainfrom
damdo:ccapio-donot-run-post-install-for-manifestsgen

Conversation

@damdo

@damdo damdo commented Jul 3, 2026

Copy link
Copy Markdown
Member

Summary

  • Add manifests-gen/ to the pipeline_skip_if_only_changed pattern for the e2e-aws-capi-techpreview-post-install test in openshift/cluster-capi-operator configs (main, 4.23, 5.0, 5.1)
  • The test was the only one in the config missing this pattern, causing it to run unnecessarily on PRs that only touch manifests-gen/ files
  • Aligns the skip pattern with all other tests in the same configs

Test plan

  • Verify CI passes on this PR (rehearsal)
  • Confirm e2e-aws-capi-techpreview-post-install is skipped on a manifests-gen-only PR after merge

Summary by CodeRabbit

Updated the openshift/cluster-capi-operator CI configuration across main, 4.23, 5.0, and 5.1 so the e2e-aws-capi-techpreview-post-install job now skips runs when only manifests-gen/ files change.

This aligns that job’s pipeline_skip_if_only_changed behavior with the rest of the cluster-capi-operator test suite, preventing unnecessary execution on manifests-gen-only PRs.

…nstall for manifests-gen changes

The e2e-aws-capi-techpreview-post-install test was missing manifests-gen/
from its pipeline_skip_if_only_changed pattern, causing it to run
unnecessarily on PRs that only touch manifests-gen/ files.

Update the skip pattern to match the one used by all other tests in
the cluster-capi-operator config.
@openshift-ci openshift-ci Bot requested review from RadekManak and racheljpg July 3, 2026 15:11
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

An error occurred during the review process. Please try again later.

Walkthrough

This PR updates the pipeline_skip_if_only_changed regex pattern for the e2e-aws-capi-techpreview-post-install job across four cluster-capi-operator CI config files (main, release-4.23, release-5.0, release-5.1), standardizing which file path changes cause the test to be skipped.

Changes

Skip regex update

Layer / File(s) Summary
Standardize pipeline skip regex across branches
ci-operator/config/openshift/cluster-capi-operator/openshift-cluster-capi-operator-main.yaml, ...release-4.23.yaml, ...release-5.0.yaml, ...release-5.1.yaml
The pipeline_skip_if_only_changed regex for the e2e-aws-capi-techpreview-post-install job is updated in each file to match .md files, docs/, LICENSE, manifests-gen/, and OWNERS paths with consistent anchoring, replacing prior varying patterns.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Related PRs: None identified.

Suggested labels: ci, config

Suggested reviewers: None identified.

🐰 Poem

A regex hop, from branch to branch,
Skipping docs and LICENSE at a glance,
manifests-gen joins the skip-worthy crew,
OWNERS too, in patterns anew,
Four configs aligned in a tidy dance.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2026
@damdo

damdo commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@damdo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 3, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@damdo: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-capi-operator-release-4.23-e2e-aws-capi-techpreview-post-install openshift/cluster-capi-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-capi-operator-release-5.0-e2e-aws-capi-techpreview-post-install openshift/cluster-capi-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-capi-operator-release-5.1-e2e-aws-capi-techpreview-post-install openshift/cluster-capi-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview-post-install openshift/cluster-capi-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant