ci-operator/step-registry/openshift: Push e2e flavors under e2e/ #9612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
This collects similar workflow definitions together instead of having a growing dump of sibling directories. Also use symlinks to parent OWNERS files for subdirectories had the same content. I haven't used symlinks for things like: * aws/ovn/OWNERS * vsphere/ovn/OWNERS despite them having the same content, because it's not clear which location would be more canonical. Will be nice if/when [1] gets fixed and we can go back to using aliases. [1]: openshift/ci-tools#115 (comment)
Keeping all the gather logic collected under one step subdirectory.
wking
force-pushed
the
organize-e2e-steps
branch
from
513c8f0 to
e0f511e
Compare
Contributor
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Member
Author
|
ovn-hybrid hung in the with the hilarious: vsphere failed a bunch of tests on a Kube-API-server flake, with errors like: But all of those look like valid product issues. I don't see anything that looks related to the changes I'm making in this PR, so we should be good to merge. |
Member
|
I don't have any strong opinion about the directories layout. More up to the step registry architects to say yes/no based on their design. |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@wking: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Jun 17, 2020
Step-registry CI currently requires each directory to contain an OWNERS file (ci/prow/owners). Often, those OWNERS sets are the same as the parent-directory's OWNERS file. To ease maintenance, we can use symlinks to ../OWNERS to explicitly say "this is the same set", as we started to do in 0f27f00 (ci-operator/step-registry/openshift: Push e2e flavors under e2e/, 2020-06-10, openshift#9612). This commit adds a script to automate that deduping, and also commits the state generated by: $ hack/dedup-owners.sh ci-operator/step-registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This collects similar workflow definitions together instead of having a growing dump of sibling directories.
CCing affected approvers: @danwinship, @dcbw, @ingvagabund, @knobunc, @pecameron, @squeed