Bug 1017536 - Duplication warning messages when creating scalable app with empty git repo

[jhadvig]

Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1017536
When creating new scalable app with empty git repo, will return message that empty git repo has been created twice.

This is second part of the bug fix. First part is at -> openshift/origin-server#4077

[jhadvig]

@smarterclayton cloud you please review this one. The first part was reviewed by @mfojtik

[smarterclayton]

@jhadvig this message doesn't seem to be correct. If from-code is nil that means the application may already have contents in the repo, which is definitely not empty. A git push would not work.

[jhadvig]

@smarterclayton, yes I see, also I was told that CLIENT_MESSAGEs that I had deleted in https://github.com/openshift/origin-server/pull/4077/files are used for some reason, so they have to stay there.

And so I want to ask if the client messages should stay where they are because of their further usage?
Because if so, the duplicity is inevitable due to the output of building each cartridge in the scalable app and in this order I will close both the PRs.

Asking because I dont see so deep into the messages and their usage.

[smarterclayton]

This if statement should be

if options.from_code == "empty"

[smarterclayton]

@jhadvig why is the message being returned twice? Is post-configure being called on each scalable gear? The message should only be printed on the gears which have a git repository - it may be that the message should move into a different area of code (the code where the repository is created the first time) instead of post-configure.

That would be a better solution than adding a message to RHC - all clients probably need to display that message for consistency, vs. having one in the console and a different one in the CLI.

[jhadvig]

@smarterclayton the post-configure was called on all the cartridges that were used for the deployment of the scalable app. Figured out that it's the message has to be printed only on the primary cartridge.
Due to this Im closing this PR and will update the one for the origin-server.
Thanks!