ROSAENG-00000 | test: Fixing id:77149,id:75603,id:45745 - #3428
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughUpdates ROSA CLI end-to-end tests for proxy, registry, autoscaler, IAM, subnet, and cluster configuration validation. Reworks STS external-ID testing to update both role trust policies and verify matching and non-matching IDs. Changes automatic operator-role upgrade testing to prepare for a Y-stream upgrade and wait for an available target before deriving the upgrade version. Also includes formatting and whitespace adjustments. Suggested reviewers: 🚥 Pre-merge checks | ✅ 13 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (13 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/e2e/test_rosacli_cluster.go`:
- Around line 4141-4151: Update the GetRole polling closure to check err before
accessing result.Role or AssumeRolePolicyDocument; on error, return false with
the established retry behavior used by the nearby subnet-availability poll, and
only inspect the policy document after a successful, non-nil response.
In `@tests/e2e/test_rosacli_operator_roles.go`:
- Around line 1196-1197: Update the scheduledDate and scheduledTime
initialization in the test to derive both values from a single UTC timestamp
created after adding the 10-minute offset. Format that same timestamp with the
existing date and time layouts so both components represent the same scheduled
instant.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 2340e5e3-5853-4712-8a13-f0994b9433a6
📒 Files selected for processing (2)
tests/e2e/test_rosacli_cluster.gotests/e2e/test_rosacli_operator_roles.go
b14b413 to
5428f3f
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amandahla, jerichokeyne The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a1f269c
into
openshift:master
|
@jerichokeyne: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
PR Summary
Fixing a few test cases from recent CI failures:
Detailed Description of the Issue
Related Issues and PRs
#Type of Change
Previous Behavior
Behavior After This Change
How to Test (Step-by-Step)
Preconditions
Test Steps
Expected Results
Proof of the Fix
id:45745id:75603id:77149Breaking Changes
Breaking Change Details / Migration Plan
Developer Verification Checklist
[JIRA-TICKET] | [TYPE]: <MESSAGE>.make install-hookshas been run in this clone.make testpasses.make lintpasses.make rosapasses.Summary by CodeRabbit