NE-2767: Bump Kubernetes to 1.36.2#100
Conversation
Bump k8s.io modules to v0.36.2 (k8s.io/kubernetes to v1.36.2), and update OpenShift dependencies to latest. Fix Go 1.26 vet error for non-constant format string in Eventf call. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
|
Skipping CI for Draft Pull Request. |
|
@aswinsuryan: This pull request references NE-2767 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 WalkthroughThe pull request updates direct and indirect Go dependencies, including OpenShift and Kubernetes components, and changes the ingress IP reallocation warning event to use an explicit format string. ChangesDependency modernization
Ingress event formatting
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aswinsuryan The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/assign |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
/retest-required |
1 similar comment
|
/retest-required |
|
@aswinsuryan: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
relda88
left a comment
There was a problem hiding this comment.
Approach is solid. Minor nit: this would benefit from a brief comment explaining why we skip validation for internal callers.
Summary by CodeRabbit
Bug Fixes
Chores