Skip to content

Delete obsolete F5 code - #46

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
ironcladlou:delete-old-stuff
Oct 7, 2019
Merged

Delete obsolete F5 code#46
openshift-merge-robot merged 1 commit into
openshift:masterfrom
ironcladlou:delete-old-stuff

Conversation

@ironcladlou

Copy link
Copy Markdown
Contributor

This code is no longer supported in v4. Start cleaning up.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2019
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 7, 2019
This code is no longer supported in v4. Start cleaning up.
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2019
@Miciah

Miciah commented Oct 7, 2019

Copy link
Copy Markdown
Contributor

/lgtm
Need to delete images/router/f5 in a follow-up.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
openshift-merge-robot merged commit f976016 into openshift:master Oct 7, 2019
redhat-chai-bot added a commit to redhat-chai-bot/openshift_router that referenced this pull request Jul 27, 2026
Delete the images/router/f5/ directory, which contained the
Dockerfile and supporting files for the F5 BIG-IP router plugin image.
These are the last remaining artifacts of the F5 router plugin, whose
Go implementation was already removed.

The F5 router code was deleted in three stages:

  1. The Go source and tests were removed from this repository in
     PR openshift#46 (commit 2c04e3a).

  2. The F5 router image was removed from the Prow CI
     configuration in openshift/release PR #74313 (commit
     7a5d5f1a3cd66a16ae8d28a8c4e7ffdd43f8fde1).

  3. The F5 router image was removed from the ART build
     configuration in openshift-eng/ocp-build-data (commit
     ccb97c75b58a1706d2111c396cf6c3437bc6e05e).

This commit completes the cleanup by deleting the four files that
remained under images/router/f5/:

  - Dockerfile           (CentOS-based image definition)
  - Dockerfile.rhel      (RHEL-based image definition)
  - .cccp.yml            (container build service config)
  - bin/.gitignore        (placeholder for copied binary)

This commit resolves NE-2829.

https://issues.redhat.com/browse/NE-2829

* images/router/f5/Dockerfile: Delete file.
* images/router/f5/Dockerfile.rhel: Delete file.
* images/router/f5/.cccp.yml: Delete file.
* images/router/f5/bin/.gitignore: Delete file.

Assisted-by: Chai Bot (OpenShift AI Helpdesk)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants