Set HOME=/tmp in Dockerfile.integration for CI compatibility - #3878
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
Warning Review limit reached
Next review available in: 54 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe integration Docker image now sets ChangesIntegration container configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 21✅ Passed checks (21 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Dockerfile.integration`:
- Line 21: Document the new HOME environment setting alongside the Dockerfile
integration changes, noting that nested-podman-entrypoint.sh writes Podman
configuration under /tmp/.config/containers. Keep the documentation focused on
this runtime behavior and include it in the same PR.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: ad9badb8-ccc6-4328-98ed-d6dcfd47172a
📒 Files selected for processing (1)
Dockerfile.integration
ci-operator's nested_podman runs the container as runAsUser:1000 without a proper home directory, so HOME defaults to '/' (not writable). The Docker ENTRYPOINT invokes nested-podman-entrypoint.sh which needs a writable HOME to create .config/containers/ for podman configuration. Setting HOME=/tmp in the Dockerfile ensures it is available when the ENTRYPOINT runs, before ci-operator's commands field is evaluated.
6196495 to
7c88815
Compare
|
Scheduling required tests: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mstaeble, redhat-chai-bot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@redhat-chai-bot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ci-operator's
nested_podmanruns the container asrunAsUser:1000without a proper home directory, soHOMEdefaults to/(not writable). The DockerENTRYPOINTinvokesnested-podman-entrypoint.shwhich needs a writableHOMEto create.config/containers/for podman configuration.\n\nSettingHOME=/tmpin the Dockerfile ensures it is available when theENTRYPOINTruns, before ci-operator'scommandsfield is evaluated.\n\nThis unblocks openshift/release#82684 which adds the integration test presubmit for sippy.\n\nLinked: TRT-2865AI-generated. Review for accuracy.
@mstaeble requested in Slack thread
Summary by CodeRabbit
/tmpas the home directory.