Skip to content

Set HOME=/tmp in Dockerfile.integration for CI compatibility - #3878

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
redhat-chai-bot:env-home-dockerfile-integration
Aug 5, 2026
Merged

Set HOME=/tmp in Dockerfile.integration for CI compatibility#3878
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
redhat-chai-bot:env-home-dockerfile-integration

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

ci-operator's nested_podman runs the container as runAsUser:1000 without a proper home directory, so HOME defaults to / (not writable). The Docker ENTRYPOINT invokes nested-podman-entrypoint.sh which needs a writable HOME to create .config/containers/ for podman configuration.\n\nSetting HOME=/tmp in the Dockerfile ensures it is available when the ENTRYPOINT runs, before ci-operator's commands field is evaluated.\n\nThis unblocks openshift/release#82684 which adds the integration test presubmit for sippy.\n\nLinked: TRT-2865


AI-generated. Review for accuracy.

@mstaeble requested in Slack thread

Summary by CodeRabbit

  • Chores
    • Updated the integration environment to use /tmp as the home directory.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Aug 5, 2026
@openshift-ci
openshift-ci Bot requested review from deads2k and mstaeble August 5, 2026 03:26
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@redhat-chai-bot, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 54 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 99fc6fc2-b7a5-45cd-aa7f-3c2f5c566750

📥 Commits

Reviewing files that changed from the base of the PR and between 59a59fe and 7c88815.

📒 Files selected for processing (1)
  • Dockerfile.integration

Walkthrough

The integration Docker image now sets HOME=/tmp.

Changes

Integration container configuration

Layer / File(s) Summary
Set integration container home directory
Dockerfile.integration
Sets the container HOME environment variable to /tmp.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: mstaeble

🚥 Pre-merge checks | ✅ 21
✅ Passed checks (21 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the change to set HOME=/tmp in Dockerfile.integration for CI compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Go Error Handling ✅ Passed The commit changes only Dockerfile.integration and adds ENV HOME=/tmp; it contains no Go-file changes, so Go error handling is not applicable.
Sql Injection Prevention ✅ Passed The commit changes only Dockerfile.integration by adding ENV HOME=/tmp; it contains no SQL, query construction, or user-input handling.
Excessive Css In React Should Use Styles ✅ Passed The pull request changes only Dockerfile.integration by adding ENV HOME=/tmp; it contains no React components or inline CSS changes to assess.
Test Coverage For New Features ✅ Passed The commit only adds ENV HOME=/tmp to Dockerfile.integration, which is a configuration-only change covered by the stated exception.
Single Responsibility And Clear Naming ✅ Passed The PR adds only the clearly named Docker ENV HOME=/tmp; it introduces no package, struct, or method and keeps the entrypoint change single-purpose.
Feature Documentation ✅ Passed The sole change sets HOME=/tmp for the integration container entrypoint; it does not alter a feature documented in docs/features/, whose only document covers job symptoms.
Stable And Deterministic Test Names ✅ Passed The PR changes only Dockerfile.integration by adding static ENV HOME=/tmp; it adds or alters no Ginkgo test titles.
Test Structure And Quality ✅ Passed The patch changes only Dockerfile.integration by adding ENV HOME=/tmp; it changes no Go or Ginkgo test files, so these test-quality criteria are not applicable.
Microshift Test Compatibility ✅ Passed The pull request changes only Dockerfile.integration by adding ENV HOME=/tmp; it adds no Ginkgo e2e tests or MicroShift API references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only Dockerfile.integration by adding ENV HOME=/tmp; it adds no Ginkgo e2e tests or cluster-topology assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The commit changes only Dockerfile.integration by adding ENV HOME=/tmp; it adds no deployment, operator, controller, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only Dockerfile.integration; the repository has no OTE binary or Ginkgo suite, and no applicable stdout contract violation is introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The patch only adds ENV HOME=/tmp to Dockerfile.integration; it adds no Ginkgo e2e tests or networking behavior to assess.
No-Weak-Crypto ✅ Passed The PR adds only ENV HOME=/tmp; its patch and related entrypoint contain no weak crypto, custom crypto, or secret comparison.
Container-Privileges ✅ Passed The patch only adds ENV HOME=/tmp to Dockerfile.integration; it adds no privileged mode, host namespace, SYS_ADMIN capability, root user, or allowPrivilegeEscalation setting.
No-Sensitive-Data-In-Logs ✅ Passed The PR changes only Dockerfile.integration by adding HOME=/tmp; no logging code or sensitive values were added, and the referenced entrypoint writes configuration files rather than secrets to logs.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Dockerfile.integration`:
- Line 21: Document the new HOME environment setting alongside the Dockerfile
integration changes, noting that nested-podman-entrypoint.sh writes Podman
configuration under /tmp/.config/containers. Keep the documentation focused on
this runtime behavior and include it in the same PR.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: ad9badb8-ccc6-4328-98ed-d6dcfd47172a

📥 Commits

Reviewing files that changed from the base of the PR and between 59a59fe and 6196495.

📒 Files selected for processing (1)
  • Dockerfile.integration

Comment thread Dockerfile.integration
ci-operator's nested_podman runs the container as runAsUser:1000 without
a proper home directory, so HOME defaults to '/' (not writable). The
Docker ENTRYPOINT invokes nested-podman-entrypoint.sh which needs a
writable HOME to create .config/containers/ for podman configuration.

Setting HOME=/tmp in the Dockerfile ensures it is available when the
ENTRYPOINT runs, before ci-operator's commands field is evaluated.
@redhat-chai-bot
redhat-chai-bot force-pushed the env-home-dockerfile-integration branch from 6196495 to 7c88815 Compare August 5, 2026 03:31
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

@mstaeble mstaeble left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2026
@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mstaeble, redhat-chai-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2026
@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 726bff0 into openshift:main Aug 5, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants