CNF-24070: Use %w error wrapping in fmt.Errorf calls

[sebrandon1]

Summary

• Replace %v with %w for error arguments in all 25 fmt.Errorf calls across 8 files
• Preserves the error chain so callers can use errors.Is and errors.As for programmatic error handling (Go blog: Working with Errors in Go 1.13)
• One non-trivial change: reordered arguments in process.go to move err to the final position, since %w must be the last format verb

Jira: CNF-24070

Files changed (8)

k8s: client.go (5), process.go (2), tls.go (2), component.go (1)
output: csv.go (6), junit.go (4), json.go (3)
timing: timing.go (2)

Related to

• redhat-best-practices-for-k8s/certsuite#3730 — %w error wrapping in certsuite (open)
• openshift-kni/commatrix#482 — %w error wrapping in commatrix (merged)
• crc-org/crc#5180 — %w error wrapping in crc (merged)
• openshift-kni/lifecycle-agent#6319 — bare error wrapping in lifecycle-agent (open)
• redhat-best-practices-for-k8s/certsuite#3633 — bare error wrapping in certsuite (merged)
• redhat-best-practices-for-k8s/certsuite#3627 — bare error wrapping in certsuite (merged)

Test plan

• go build ./... passes
• go test ./... passes
• make lint passes
• grep -rn 'fmt.Errorf.*%v' --include='*.go' returns zero matches (excluding tests)

[openshift-ci-robot]

@sebrandon1: This pull request references CNF-24070 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

• Replace %v with %w for error arguments in all 25 fmt.Errorf calls across 8 files
• Preserves the error chain so callers can use errors.Is and errors.As for programmatic error handling (Go blog: Working with Errors in Go 1.13)
• One non-trivial change: reordered arguments in process.go to move err to the final position, since %w must be the last format verb

Jira: CNF-24070

Files changed (8)

k8s: client.go (5), process.go (2), tls.go (2), component.go (1)
output: csv.go (6), junit.go (4), json.go (3)
timing: timing.go (2)

Test plan

• go build ./... passes
• go test ./... passes
• make lint passes
• grep -rn 'fmt.Errorf.*%v' --include='*.go' returns zero matches (excluding tests)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@sebrandon1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[richardsonnick]

/lgtm

[richardsonnick]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsonnick, sebrandon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [richardsonnick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment