Add rustBench Wave Terminal widget - #1
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Reviewer's GuideAdds a rustBench Wave Terminal widget wired to the rust-bench container and introduces an option to update widget configuration without overwriting an existing launcher. Sequence diagram for rustBench widget launching rust-bench containersequenceDiagram
actor User
participant WaveTerminal
participant wave_container_shell_sh as wave-container-shell.sh
participant resolve_bench_defaults
participant docker_compose as docker-compose
participant zsh
User->>WaveTerminal: select rustBench widget
WaveTerminal->>wave_container_shell_sh: wave-container-shell.sh --check rustBench
wave_container_shell_sh->>resolve_bench_defaults: resolve_bench_defaults rustBench
resolve_bench_defaults-->>wave_container_shell_sh: container=rust-bench, bench_dir, compose_file
wave_container_shell_sh->>docker_compose: docker-compose -f compose_file up -d rust-bench
wave_container_shell_sh->>zsh: zsh with workBenches mounts
Sequence diagram for installer with optional launcher replacementsequenceDiagram
actor User
participant install_widgets_sh as install-workbenches-widgets.sh
participant launcher as wave-container-shell.sh
User->>install_widgets_sh: install-workbenches-widgets.sh [options]
install_widgets_sh->>install_widgets_sh: parse --skip-launcher
alt install_launcher true
install_widgets_sh->>launcher: install -m 755 wave-container-shell.sh
install_widgets_sh-->>User: echo Installed launcher
else install_launcher false
install_widgets_sh-->>User: echo Launcher unchanged
end
install_widgets_sh-->>User: echo Updated widgets and connections
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
resolve_bench_defaultsfunction is starting to accumulate a lot of hard‑coded case branches; consider refactoring this to a data-driven map of bench key → container/paths so adding new benches likerustBenchdoesn’t require editing shell logic in multiple places. - When
--skip-launcheris used, the script always printsLauncher unchanged: ...even if the launcher does not yet exist; you might want to guard this message with a file existence check or clarify the wording so it’s not misleading on first-time installs.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `resolve_bench_defaults` function is starting to accumulate a lot of hard‑coded case branches; consider refactoring this to a data-driven map of bench key → container/paths so adding new benches like `rustBench` doesn’t require editing shell logic in multiple places.
- When `--skip-launcher` is used, the script always prints `Launcher unchanged: ...` even if the launcher does not yet exist; you might want to guard this message with a file existence check or clarify the wording so it’s not misleading on first-time installs.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
Adds a new rustBench Wave Terminal widget and wires the shared launcher to open the rust-bench devcontainer, alongside the existing bench widgets. Also introduces an installer option to refresh Wave config without overwriting the launcher script.
Changes:
- Add
rustBenchwidget definition to the Wave widgets template and document it. - Teach
wave-container-shell.shto resolverustBenchto therust-benchcontainer + bench directory. - Add
--skip-launcherto the widget installer to update Wave config without reinstalling the launcher.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| templates/workbenches.widgets.json | Adds the rustBench widget pointing to the shared launcher script. |
| scripts/install-workbenches-widgets.sh | Adds --skip-launcher option and conditional launcher installation. |
| README.md | Documents rustBench in the benches table. |
| docs/workbenches-widgets.md | Documents rustBench behavior and adds launcher check example. |
| bin/wave-container-shell.sh | Adds rustBench resolution to rust-bench defaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if [[ "$install_launcher" == true ]]; then | ||
| install -m 755 "$repo_dir/bin/wave-container-shell.sh" "$workbenches_root/scripts/wave-container-shell.sh" | ||
| fi |



Summary
brands@rustrustBench widget beside pyBench and C++BenchrustBenchto therust-benchcontainer launcherValidation
--skip-launcherpreserves the existing launcherSummary by Sourcery
Add a rustBench Wave Terminal widget mapped to the rust-bench container, and support updating Wave config without reinstalling the workBenches launcher.
New Features:
Enhancements:
Documentation: