updated max password length to 255#123
Merged
barryo merged 1 commit intoopensolutions:masterfrom Jan 5, 2015
Merged
Conversation
users want to set longer passwords and there is no reason why a password which is stored as hash is limited. the length of 255 chars should be long enough for every user and it fits in the password field if any crazy admin wants to store them in plain text
barryo
added a commit
that referenced
this pull request
Jan 5, 2015
updated max password length to 255
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
password limits are not necessary, due to the fact that the password will be hashed before storing. the length of 255 chars should be long enough for every user and it fits in the password field if any crazy admin wants to store them in plain text. if the application ensures that passwords can not be stored in plain text, the limit can be removed.