Disallow non-super admins to add/edit domains#201
Merged
barryo merged 2 commits intoopensolutions:masterfrom Aug 3, 2016
Merged
Disallow non-super admins to add/edit domains#201barryo merged 2 commits intoopensolutions:masterfrom
barryo merged 2 commits intoopensolutions:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-super admins simply don't have to visit the domain edit page. The only option non-super admins have write access to, is
toggle-active. However, this option is already accessibly through the AJAX toggle button on the domain list page. The easiest solution is therefore to disallow navigating to the add (btw, non-super admins were able to create domains until now, however, they weren't able to assign admins to domains) and edit page.Fixes #30, #181