Use DIRECTORY_SEPARATOR instead of DS#218
Merged
barryo merged 1 commit intoopensolutions:masterfrom Jan 3, 2017
Merged
Conversation
The smarty_modifier_date_formatter function uses system path to determine if the target OS is Windows. PHP 4 introduced DIRECTORY_SEPARATOR, and DS isn't defined in the current configuration and Smarty bootstrap process. It so seems safe to switch to DIRECTORY_SEPARATOR. Fixes opensolutions#217.
Member
|
Looks sane to me, thanks 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smarty_modifier_date_formatter function uses system path
to determine if the target OS is Windows.
PHP 4 introduced DIRECTORY_SEPARATOR, and DS isn't defined in
the current configuration and Smarty bootstrap process.
It so seems safe to switch to DIRECTORY_SEPARATOR.
Fixes #217.