Bugfix for alias queries when using regular account#63
Closed
rozwell wants to merge 1 commit intoopensolutions:masterfrom
Closed
Bugfix for alias queries when using regular account#63rozwell wants to merge 1 commit intoopensolutions:masterfrom
rozwell wants to merge 1 commit intoopensolutions:masterfrom
Conversation
Contributor
Author
There was a problem hiding this comment.
domain_admin table has only 2 id columns, so I guess this was wrong all along, not to mention the DomainAdmin entity doesn't exist.
Member
|
Thanks @rozwell - I didn't merge your commit only because I wanted to test and check for myself locally. The errors here were queries incorrectly ported from V2 which used Doctrine 1.2 to V3 using Doctrine2. |
Contributor
Author
|
Not a problem, I'm just glad it's fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no DomainAdmin entity and it's handled by Doctrine automagically when using joins for m2m tables.
Without this fix, errors will occur when you try to remove mailbox or view it's aliases using regular account.