Skip to content

greptile: edit severity level to critical in string-safety#253

Merged
suphawitwanl merged 1 commit intomasterfrom
greptile-first-roll-out-5
May 1, 2026
Merged

greptile: edit severity level to critical in string-safety#253
suphawitwanl merged 1 commit intomasterfrom
greptile-first-roll-out-5

Conversation

@yutanaofficial
Copy link
Copy Markdown

Bump the string-safety rule in .greptile/config.json from high to critical

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 1, 2026

Greptile Summary

This PR elevates the string-safety rule severity in .greptile/config.json from high to critical, aligning it with the existing memory-allocation rule. The change means Greptile will now treat any use of strcpy(), strcat(), or sprintf() in C/C++ source as a critical violation, consistent with the seriousness of buffer-overflow risk in the FRR codebase.

Confidence Score: 5/5

Safe to merge — trivial one-line config change with no runtime impact.

The change is a single severity-field update in a Greptile config file. It is intentional, justified by the buffer-overflow risk of unsafe string functions in C, and consistent with how the parallel memory-allocation rule is already configured. No code logic, build artifacts, or protocol behaviour is affected.

No files require special attention.

Important Files Changed

Filename Overview
.greptile/config.json Single-field change: string-safety rule severity bumped from high to critical; no structural or logic issues.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR touches C/C++ file] --> B{Greptile rule scan}
    B --> C[memory-allocation rule\nseverity: critical]
    B --> D[string-safety rule\nseverity: critical ← was high]
    B --> E[logging-api rule\nseverity: high]
    C --> F[Block / flag as critical]
    D --> F
    E --> G[Flag as high]
Loading

Reviews (1): Last reviewed commit: "greptile: edit severity level to critica..." | Re-trigger Greptile

@suphawitwanl suphawitwanl merged commit d01dde4 into master May 1, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants