adminURL may not be available, prevent crash#8
Closed
reidrac wants to merge 1 commit intoopenstack:masterfrom
reidrac:master
Closed
adminURL may not be available, prevent crash#8reidrac wants to merge 1 commit intoopenstack:masterfrom reidrac:master
reidrac wants to merge 1 commit intoopenstack:masterfrom
reidrac:master
Conversation
If there's no adminURL endpoint in the serviceCatalog (ie. in a objtect-store, in Rackspace identity service there's onlu publicURL and internalURL), unconditionally accessing the first element of management_url property of AccesInfo may raise: Authorization Failed: 'NoneType' object has no attribute '__getitem__' This change verifies that management_url is a tuple, otherwise management_url will be None.
|
Thank you for contributing to OpenStack! openstack/python-keystoneclient uses Gerrit for code review. Please visit http://wiki.openstack.org/GerritWorkflow and follow the instructions there to upload your change to Gerrit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there's no adminURL endpoint in the serviceCatalog (ie. in a objtect-store,
in Rackspace identity service there's onlu publicURL and internalURL), unconditionally
accessing the first element of management_url property of AccesInfo may raise:
Authorization Failed: 'NoneType' object has no attribute 'getitem'
This change verifies that management_url is a tuple, otherwise management_url will be None.