v2.40.0

[tyrasd]

📣 Release Highlights

New rendering style for shared bike and foot paths

The new style indicates a way that is designated for bike and foot traffic in cases where we have established tagging for this kind of infrastructure:

• highway=path: When bicycle+foot=designated are explicitly tagged, the way is displayed in our new, shared infrastructure style.
• highway=cycleway: When foot=designated is present, the way is displayed in our new, shared infrastructure style (bicycle=designated can, but does not have to be tagged as it is implicit by the highway=cycleway tag)
• highway=footway: does not change, regardless of the presence of bicycle+foot=designated tags, because there is no established tagging that fits this new style

Dynamic level of detail for created circular objects

This leads to more accurately round geometries for large circular objects like large roundabouts, etc., and at the same time also reduces the previously sometimes slightly excessive number of nodes produced used on small round objects like circular huts, etc.

Fixed and improved tag-cleanup when changing presets

This improves how tags are handled when the preset of an object is changed. The goal is to prevent straggling tags to remain on the OSM object after changing its preset: For example, when a POI changes in the real world from a restaurant to a shop, it does not make sense for the restaurant's cuisine tag to be preserved in the shop POI.¹

Now, only tags are preserved that are also valid tags of the newly applied preset. For the example above, general attributes like the address and phone number would be preserved, but restaurant-specific tags like the cuisine or dietary options would be removed.

As this is a relatively big change compared to how iD previously handled tags when changing presets, please report any bugs, inconsistencies or other oddities you notice.

Full Changelog

✨ Usability & Accessibility

• Render shared bicycle/foot paths with a dedicated colour (render shared bicycle/foot paths with a dedicated colour #10256, thanks @k-yle)
• Expand input element of multi-combo fields while typing to fit content (Move along with source text input also if there is an autocomplete #12169)
• When searching presets, include presets when the preset label is included in the search input (preset search - match when preset text is in term #12159, thanks @matkoniecz)

✂️ Operations

• Create fewer points when circularizing small features (and vice versa): the number of vertices in the resulting circle is now dynamic between a 12 and 32 depending on the radius of the circle (instead of always resulting in 19 nodes) (dynamic number of nodes for circularized way, depending on size of circularized feature #12139)
• Correctly split a way on all selected vertices when three or more nodes are selected (Splitting a way in multiple places simultaneously may fail to work properly #12120)

✅ Validation

• Treat most aerialways as part of the routable network when checking other ways' connectivity (Footways in ID are flagged as disconnected when between ski lifts and ski piste #9406)
• Only consider well known tags containing URLs during website validation (restrict url/website validation to specific tags #12178, thanks @bhavyaKhatri2703)
• Sort full issues list by issue type first (instead of only by distance from map center), such that similar issues are always listed next to each other (Allow further filtering or sorting in the Issues pane #9017)
• For disconnected routable multipolygon areas: report the relation in the validation warning (warning on outer way instead of a pedestrian multipolygon #12245)

🐛 Bugfixes

• Fix title of preset search results not updating correctly (Preset search bar linebreaking issue #12050, thanks @bhavyaKhatri2703)
• Prevent duplicate nodes from being created while using spacebar key to draw a way (Using spacebar for drawing way/areas can result in multiple nodes with the same coordinates #12051)
• Fix user images and upload help text from showing up as duplicates in upload dialog (bug in 2.39: "changes you will send as" x4 #12063)
• Fix some tags automatically deleted when re-selecting the same preset (fix: preserves all tags when re-selecting the same preset #12070, thanks @k-yle)
• Fix crash when a checkbox-field is rendered using a custom (non-yes/no) value (Unable to edit highway=* with covered=arcade/colonnade #12078)
• Fix a bug that caused step_count to be set to NaN when merging features with non-numeric step count values (merging features with non-numeric step_count can lead to NaN values #12110, thanks @JaiswalShivang)
• Fix a bug that caused duplicates of new notes to appear when such a note is dragged on the map (Dragged notes create duplicates #9092)
• Prevent keyboard shortcuts from triggering an additional input after their action is performed (F to follow causes the letter f to be inserted into search field upon completion of area #9071)
• Include railway and building features with lifecycle status only in past/future features category (Filtering of "Past/Future Features" don't affect 'railway=construction' #9058)
• Disable autocomplete on changeset comment box on mobile Firefox to work around buggy/glitchy behavior of the input field (Autocomplete on changeset comment field is glitchy on Firefox mobile #9011)
• Fix crash when trying to delete a single-node way (Cannot delete single-node ways #9007)
• Make sure the available options of multi/semi-combo fields are updated properly when a previous tag change caused a change of the feature's preset (leisure=pitch and adding sports again #12217)
• Handle OSM API responses with 200 status code, but a runtime error in the response (Handle OSM API response including <error> tag #6454)
• Keep natural=coastline tag on outer way of created multipolygon when combining areas (preserve natural=coastline on outer ways during Merge operation (Fixes #11816) #11818, thanks @Kaushik4141)
• Show correct cursor on headings of quality assurance results in the sidebar (Ensure only clickable qaItem icons show the pointer cursor (fixes #9073) #12276, thanks @Quantum-Cucumber)
• Fix exception when a onewayCheck field is present on a non-way feature (e.g. a ferry route) (Sidebar UI errors out for NYC Ferry relations #12272)
• Make sure that disable_features parameter from URL hash is not overwritten by locally cached value from last session
• Fix feature filter falsely hiding boundary relation members while in dragging mode when other features are hidden (Boundary line disappears after edit when filter are active #12267)
• Make sure long autocomplete-suggestions in input fields do not scroll the input field beyond the cursor location in Firefox

🚀 Presets

• Standardize tooltips in combo boxes: always show (full) raw tag, don't duplicate the already rendered titles, and show descriptions from wiki/taginfo where available (Combo/access: standardize tooltips to Tag: key=value, add formatTag helper #12010, thanks @tordans)
• Use full width for the dropdown box for the values of the access field (changes in 2.39: the values of the access key take up a lot of space #12065)
• Preserve the order of options when a combo field accepts both static options as well as autosuggestions from taginfo and display additional tag values from taginfo as raw-options only (Dropdown values set by presets is not respected, if list of values is inherited and reduced #12117)
• When removing tags while changing presets: include all tags associated with localized, multiCombo and directionalCombo fields (Handle special fields like localized names in tag removal logic #12075, when changing presets, delete keys from the old preset which are not in the new preset #11696)
• Preserve all feature tags when changing to a new preset that includes the old preset's primary tags as a field (Preserve old preset's field tags when selecting a new preset which has the old presets primary tag as a field #12071)

🔨 Development

• Replace sinon with vitest's built in spy/mock library (Replace sinon with vitest's built in spy/mock library #12058)
• Add type annotations to context.js module (add JSDoc annotations to context.js #11589, thanks @k-yle)
• Drop netlify-cli dependency and run it during CI via npx (execute netlify-cli via npx #12237)

---

This discussion was created from the release v2.40.0.

Footnotes

1. Note that the previous release already tried to fix this, but had to be reverted due to some bugs in the first implementation. ↩

[TheTechnician27]

I noticed that now surface= and material= values are alphabetized. I use these tags a lot, and it seemed before like values were sorted in order of usedness. For example, asphalt and concrete were the top values for surface=. Alphabetizing makes things extremely annoying for me, because now I'm scrolling past a bunch of options like surface=clay that are functionally useless to me. I understand a potential upside of making it marginally easier for a brand-new user to find a value, but values they were likely to use were already near the top, and when I'm doing this thousands of times, it's going to be a persistent annoyance and will add up.

I know this it teetering into xkcd 1172 about "my workflow", but would it be possible, if there's a decision to make it alphabetized by default, to add a user preference to sort by commonness (or whatever the old metric was) instead? Even better, maybe in the future there could be a user-specified personal list of frequently used values for various keys (like an XML import), as even the previous had one or two "useless" values I would always scroll past for more useful ones.

Also, I really appreciate the cycle & foot path distinction! It freaked me out for a second seeing it the first time, but I quickly realized. It's very, very useful.

[matkoniecz]

Maybe it should be changed in iD to remove that side-effect of #12117 as it was not intended anyway?

See #5049 which would add support for custom presets (sadly, no active work on it is happening)

[tyrasd]

side-effect of #12117 as it was not intended anyway?

I would not say that it was unintended. It merely surfaced the suboptimal ordering of the options in the tagging schema. 😉

Also, previously we would have had the same issue in case taginfo was unavailable for some reason (e.g. service down, flaky internet, etc.).

[TheTechnician27]

🤔 this made me think: iD could locally remember the tag values a mapper has actively used recently, which would be an information we could use to influence the order of the options1, on the other hand it might also be a little confusing when the order of options "suddenly" changes.

I considered suggesting that before deciding against it. Don't get me wrong: I think it'd be neat to have that as an option (but I've also done enough UI work to know that Preference Hell is a real place), yet like I think you also suggest, most users who use iD enough to get actual mileage out of this would likely prefer to develop muscle memory on a static list; unless their work is highly homogenous, values competing for positions would probably hurt productivity over even a very suboptimally ordered static list.

I see you made the issue (which I'm thankful for; this is outside my expertise), so I'll check it out!

[matkoniecz]

I created openstreetmap/id-tagging-schema#2237

Feedback/testing welcome

[matkoniecz]

openstreetmap/id-tagging-schema#2231 (comment) lists what else needs to be changed, help with those is welcome (if someone wants to contribute to iD tagging schema and is not scared by text but unsure how to start... please ping me and I will help)

[ireun]

OMG finally ID will render cycleway/footway! So happy to see this!